From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E13BC4743C for ; Wed, 23 Jun 2021 11:27:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D06116113B for ; Wed, 23 Jun 2021 11:27:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D06116113B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A8E656B0011; Wed, 23 Jun 2021 07:27:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A3E986B0036; Wed, 23 Jun 2021 07:27:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B7E06B006C; Wed, 23 Jun 2021 07:27:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0059.hostedemail.com [216.40.44.59]) by kanga.kvack.org (Postfix) with ESMTP id 56A0B6B0011 for ; Wed, 23 Jun 2021 07:27:11 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8AAB0253B6 for ; Wed, 23 Jun 2021 11:27:11 +0000 (UTC) X-FDA: 78284762262.23.EADA413 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by imf19.hostedemail.com (Postfix) with ESMTP id A342D9002397 for ; Wed, 23 Jun 2021 11:27:08 +0000 (UTC) Received: by mail-lf1-f42.google.com with SMTP id x24so3447880lfr.10 for ; Wed, 23 Jun 2021 04:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=UWr5bBdzre6zz0XMKZOGH1iTjAFUl0PtpeleXTfI3Xk=; b=qAIu1qD4S0I+cth0RweLmSX0Bse2NaMmHfSlyVrjBAQleGDbUcw6falwFJq57HdSYJ OeyJuYhSJummHyKV6WkMnlSJWv6C0XNHB94K8Lfe1ElcnM8g3e719edBHh55sfNWwTzg I/cMfyBwIAs1lktX5wJLAOwR+QxbQxrMYzpW7wAaNNdcah+xtdoaNanPcTXcg5uHzIoW r7AhySM1h3K9ySSdkBM4/rcSRVuszVFWnd5zRvMEsjhB5b8ptZBxCOSQvs4fK1VZ0KhY ukUDi8JhZLaTxp1s1i03s3njCOddQc1B1syf1Nv11Y5Zu8Ob04ja9JcgkY8UpIk3xuu8 AE3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=UWr5bBdzre6zz0XMKZOGH1iTjAFUl0PtpeleXTfI3Xk=; b=sAhSpiwadYQlINi5cwbSaP7FOqfYIoYaTYl2BVYP91QtrwLWKPhrgGVPQ+cCufaDBX R7ccHAn8I7lO6Y28FDlkzTQPzvQy851LGntMDoWjAnJPoPE4TxWHAIVpTeOXjgZVev/t 7zDq8r64QGEMXE85TdNOxcCa3Nr6vR3BH695a/QuLf4jrAmAkLs6/PrcTOn9A13w4eid Rap36sQfVB6/VjU5Zsz6mDNmrx/j/tTB+vM1y6saDs/X6kHEihVgR7/cnNSpZNlT/tuy E+UAfbHLgwtOrnpeWBA8iOw554noRBhTyvHmqSMZ8pVNAgqB31G8P1sLmFFvzJXfKXAV /NuQ== X-Gm-Message-State: AOAM532ddnNMVeXaQmMoNHs3YZUe7uEvyAi72ll8lR9tshGbP+34Y8Ka 5rpQIvDmqzLGJ/+t3pdd2ag= X-Google-Smtp-Source: ABdhPJxp7DJyqYd59MyfSejJoNoBRKlU8/OCPghwEvO5PIZ6Y/2nsF2LvVuARAL+idkBd3i/thYJVg== X-Received: by 2002:ac2:5feb:: with SMTP id s11mr6685710lfg.591.1624447627153; Wed, 23 Jun 2021 04:27:07 -0700 (PDT) Received: from pc638.lan (h5ef52e3d.seluork.dyn.perspektivbredband.net. [94.245.46.61]) by smtp.gmail.com with ESMTPSA id br18sm1002444lfb.120.2021.06.23.04.27.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Jun 2021 04:27:06 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 23 Jun 2021 13:27:04 +0200 To: Rafael Aquini Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: vmalloc: add cond_resched() in __vunmap() Message-ID: <20210623112704.GA1911@pc638.lan> References: <20210622225030.478384-1-aquini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622225030.478384-1-aquini@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A342D9002397 X-Stat-Signature: fdprcxp6u84ioyc47atwcxx9w9w8ypmb Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=qAIu1qD4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=urezki@gmail.com X-HE-Tag: 1624447628-887006 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On non-preemptible kernel builds the watchdog can complain > about soft lockups when vfree() is called against large > vmalloc areas: > > [ 210.851798] kvmalloc-test: vmalloc(2199023255552) succeeded > [ 238.654842] watchdog: BUG: soft lockup - CPU#181 stuck for 26s! [rmmod:5203] > [ 238.662716] Modules linked in: kvmalloc_test(OE-) ... > [ 238.772671] CPU: 181 PID: 5203 Comm: rmmod Tainted: G S OE 5.13.0-rc7+ #1 > [ 238.781413] Hardware name: Intel Corporation PURLEY/PURLEY, BIOS PLYXCRB1.86B.0553.D01.1809190614 09/19/2018 > [ 238.792383] RIP: 0010:free_unref_page+0x52/0x60 > [ 238.797447] Code: 48 c1 fd 06 48 89 ee e8 9c d0 ff ff 84 c0 74 19 9c 41 5c fa 48 89 ee 48 89 df e8 b9 ea ff ff 41 f7 c4 00 02 00 00 74 01 fb 5b <5d> 41 5c c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 f0 29 77 > [ 238.818406] RSP: 0018:ffffb4d87868fe98 EFLAGS: 00000206 > [ 238.824236] RAX: 0000000000000000 RBX: 000000001da0c945 RCX: ffffb4d87868fe40 > [ 238.832200] RDX: ffffd79d3beed108 RSI: ffffd7998501dc08 RDI: ffff9c6fbffd7010 > [ 238.840166] RBP: 000000000d518cbd R08: ffffd7998501dc08 R09: 0000000000000001 > [ 238.848131] R10: 0000000000000000 R11: ffffd79d3beee088 R12: 0000000000000202 > [ 238.856095] R13: ffff9e5be3eceec0 R14: 0000000000000000 R15: 0000000000000000 > [ 238.864059] FS: 00007fe082c2d740(0000) GS:ffff9f4c69b40000(0000) knlGS:0000000000000000 > [ 238.873089] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 238.879503] CR2: 000055a000611128 CR3: 000000f6094f6006 CR4: 00000000007706e0 > [ 238.887467] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > [ 238.895433] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > [ 238.903397] PKRU: 55555554 > [ 238.906417] Call Trace: > [ 238.909149] __vunmap+0x17c/0x220 > [ 238.912851] __x64_sys_delete_module+0x13a/0x250 > [ 238.918008] ? syscall_trace_enter.isra.20+0x13c/0x1b0 > [ 238.923746] do_syscall_64+0x39/0x80 > [ 238.927740] entry_SYSCALL_64_after_hwframe+0x44/0xae > > Like in other range zapping routines that iterate over > a large list, lets just add cond_resched() within __vunmap()'s > page-releasing loop in order to avoid the watchdog splats. > > Signed-off-by: Rafael Aquini > --- > mm/vmalloc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index a13ac524f6ff..cd4b23d65748 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2564,6 +2564,7 @@ static void __vunmap(const void *addr, int deallocate_pages) > > BUG_ON(!page); > __free_pages(page, page_order); > + cond_resched(); > } > atomic_long_sub(area->nr_pages, &nr_vmalloc_pages); > > -- > 2.26.3 > I have a question about a test case you run to trigger such soft lockup. Is that test_vmalloc.sh test-suite or something local? Do you use a huge vmalloc mappings so high-order pages are used? Thanks! -- Vlad Rezki