From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4569C2B9F4 for ; Tue, 22 Jun 2021 09:34:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 85DFA61353 for ; Tue, 22 Jun 2021 09:34:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85DFA61353 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 208D26B0036; Tue, 22 Jun 2021 05:34:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 191BB6B0062; Tue, 22 Jun 2021 05:34:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F25DA6B006C; Tue, 22 Jun 2021 05:34:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0020.hostedemail.com [216.40.44.20]) by kanga.kvack.org (Postfix) with ESMTP id BC6E26B0036 for ; Tue, 22 Jun 2021 05:34:03 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 538B69898 for ; Tue, 22 Jun 2021 09:34:03 +0000 (UTC) X-FDA: 78280848366.39.81596AF Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf14.hostedemail.com (Postfix) with ESMTP id 249FAC01C096 for ; Tue, 22 Jun 2021 09:34:01 +0000 (UTC) Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 15M9QmjQ013362; Tue, 22 Jun 2021 09:33:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2020-01-29; bh=30mLyG5r281Mr2ZPZ0PibVn8/aFXcgwIY98a0doQw6c=; b=sAQxjKEj/jiS6pxNDFJusDqIOErBGebVJdsEiTqsdilwOK6gag83gJKMFdFV/8g1JvEa fBnUIw6nDzcBvYSmLgrGpVUKwx6Awj6FNEs3WErR1PHByu2MMF6UdZsOGKtwtMX4L8h0 PSdPTanc0XFvMrcxvmdw5Ba8WLtIRPLCEbi/IWVFJMNyI6XwGwc5F8MDOFrKq/aDJJ1T wHj3dVLT1Is/MyfE0SZpvdjnf3auecLvAPedC+7BsXMF8tAppY1U0BBfYpj2RX9QPOFw PBWDqI3j+WF7jZuDKBguBas4+K5a7NBXvOLCDVBJ5ui6fpvQW5fnGPdHiLi2pehjy3XC dw== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 39anputxjh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 22 Jun 2021 09:33:54 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 15M9PCuD105328; Tue, 22 Jun 2021 09:33:53 GMT Received: from pps.reinject (localhost [127.0.0.1]) by userp3030.oracle.com with ESMTP id 3995pvwx3u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 22 Jun 2021 09:33:53 +0000 Received: from userp3030.oracle.com (userp3030.oracle.com [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 15M9U1pe123536; Tue, 22 Jun 2021 09:33:53 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 3995pvwx39-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 22 Jun 2021 09:33:52 +0000 Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 15M9XpNH013084; Tue, 22 Jun 2021 09:33:51 GMT Received: from kadam (/102.222.70.252) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 22 Jun 2021 09:33:51 +0000 Date: Tue, 22 Jun 2021 12:33:44 +0300 From: Dan Carpenter To: kbuild@lists.01.org, Aurabindo Pillai Cc: lkp@intel.com, kbuild-all@lists.01.org, Linux Memory Management List , Alex Deucher , Chris Park Subject: [linux-next:master 2996/11714] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn303/dcn303_resource.c:531 dcn303_stream_encoder_create() warn: possible memory leak of 'enc1' Message-ID: <202106221722.yp3fNeWU-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-GUID: PWrFHhBea1JvA2Tm4omz3_GKERffFthp X-Proofpoint-ORIG-GUID: PWrFHhBea1JvA2Tm4omz3_GKERffFthp Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2020-01-29 header.b=sAQxjKEj; dmarc=pass (policy=none) header.from=oracle.com; spf=none (imf14.hostedemail.com: domain of dan.carpenter@oracle.com has no SPF policy when checking 205.220.165.32) smtp.mailfrom=dan.carpenter@oracle.com X-Stat-Signature: hfnfaoduce176pny6gubdh69qmsbynru X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 249FAC01C096 X-HE-Tag: 1624354441-341081 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000191, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 889bab4c367a0ef58208fd80fafa74bb6e2dca26 commit: cd6d421e3d1ad5926b74091254e345db730e7706 [2996/11714] drm/amd/display: Initial DC support for Beige Goby config: i386-randconfig-m021-20210622 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter smatch warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn303/dcn303_resource.c:531 dcn303_stream_encoder_create() warn: possible memory leak of 'enc1' drivers/gpu/drm/amd/amdgpu/../display/dc/dcn303/dcn303_resource.c:533 dcn303_stream_encoder_create() error: buffer overflow 'stream_enc_regs' 2 <= 4 vim +/enc1 +531 drivers/gpu/drm/amd/amdgpu/../display/dc/dcn303/dcn303_resource.c cd6d421e3d1ad5 Aurabindo Pillai 2021-03-15 511 static struct stream_encoder *dcn303_stream_encoder_create(enum engine_id eng_id, struct dc_context *ctx) cd6d421e3d1ad5 Aurabindo Pillai 2021-03-15 512 { cd6d421e3d1ad5 Aurabindo Pillai 2021-03-15 513 struct dcn10_stream_encoder *enc1; cd6d421e3d1ad5 Aurabindo Pillai 2021-03-15 514 struct vpg *vpg; cd6d421e3d1ad5 Aurabindo Pillai 2021-03-15 515 struct afmt *afmt; cd6d421e3d1ad5 Aurabindo Pillai 2021-03-15 516 int vpg_inst; cd6d421e3d1ad5 Aurabindo Pillai 2021-03-15 517 int afmt_inst; cd6d421e3d1ad5 Aurabindo Pillai 2021-03-15 518 cd6d421e3d1ad5 Aurabindo Pillai 2021-03-15 519 /* Mapping of VPG, AFMT, DME register blocks to DIO block instance */ cd6d421e3d1ad5 Aurabindo Pillai 2021-03-15 520 if (eng_id <= ENGINE_ID_DIGE) { "eng_id" can be 4 here. cd6d421e3d1ad5 Aurabindo Pillai 2021-03-15 521 vpg_inst = eng_id; cd6d421e3d1ad5 Aurabindo Pillai 2021-03-15 522 afmt_inst = eng_id; cd6d421e3d1ad5 Aurabindo Pillai 2021-03-15 523 } else cd6d421e3d1ad5 Aurabindo Pillai 2021-03-15 524 return NULL; cd6d421e3d1ad5 Aurabindo Pillai 2021-03-15 525 cd6d421e3d1ad5 Aurabindo Pillai 2021-03-15 526 enc1 = kzalloc(sizeof(struct dcn10_stream_encoder), GFP_KERNEL); cd6d421e3d1ad5 Aurabindo Pillai 2021-03-15 527 vpg = dcn303_vpg_create(ctx, vpg_inst); cd6d421e3d1ad5 Aurabindo Pillai 2021-03-15 528 afmt = dcn303_afmt_create(ctx, afmt_inst); cd6d421e3d1ad5 Aurabindo Pillai 2021-03-15 529 cd6d421e3d1ad5 Aurabindo Pillai 2021-03-15 530 if (!enc1 || !vpg || !afmt) cd6d421e3d1ad5 Aurabindo Pillai 2021-03-15 @531 return NULL; Leaks. cd6d421e3d1ad5 Aurabindo Pillai 2021-03-15 532 cd6d421e3d1ad5 Aurabindo Pillai 2021-03-15 @533 dcn30_dio_stream_encoder_construct(enc1, ctx, ctx->dc_bios, eng_id, vpg, afmt, &stream_enc_regs[eng_id], stream_enc_regs[] is a two element array. cd6d421e3d1ad5 Aurabindo Pillai 2021-03-15 534 &se_shift, &se_mask); cd6d421e3d1ad5 Aurabindo Pillai 2021-03-15 535 cd6d421e3d1ad5 Aurabindo Pillai 2021-03-15 536 return &enc1->base; cd6d421e3d1ad5 Aurabindo Pillai 2021-03-15 537 } --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org