From: <yee.lee@mediatek.com>
To: <andreyknvl@gmail.com>
Cc: <wsd_upstream@mediatek.com>, Yee Lee <yee.lee@mediatek.com>,
"Andrey Ryabinin" <ryabinin.a.a@gmail.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"open list:KASAN" <kasan-dev@googlegroups.com>,
"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>
Subject: [PATCH] kasan: unpoison use memset to init unaligned object size
Date: Mon, 21 Jun 2021 23:44:41 +0800 [thread overview]
Message-ID: <20210621154442.18463-1-yee.lee@mediatek.com> (raw)
From: Yee Lee <yee.lee@mediatek.com>
This patch adds a memset to initialize object of unaligned size.
Duing to the MTE granulrity, the integrated initialization using
hwtag instruction will force clearing out bytes in granular size,
which may cause undesired effect, such as overwriting to the redzone
of SLUB debug. In this patch, for the unaligned object size, function
uses memset to initailize context instead of the hwtag instruction.
Signed-off-by: Yee Lee <yee.lee@mediatek.com>
---
mm/kasan/kasan.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h
index 8f450bc28045..d8faa64614b7 100644
--- a/mm/kasan/kasan.h
+++ b/mm/kasan/kasan.h
@@ -387,8 +387,11 @@ static inline void kasan_unpoison(const void *addr, size_t size, bool init)
if (WARN_ON((unsigned long)addr & KASAN_GRANULE_MASK))
return;
+ if (init && ((unsigned long)size & KASAN_GRANULE_MASK)) {
+ init = false;
+ memset((void *)addr, 0, size);
+ }
size = round_up(size, KASAN_GRANULE_SIZE);
-
hw_set_mem_tag_range((void *)addr, size, tag, init);
}
--
2.18.0
next reply other threads:[~2021-06-21 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 15:44 yee.lee [this message]
2021-06-21 17:42 ` Marco Elver
2021-06-22 14:03 ` Andrey Konovalov
2021-06-23 7:31 ` Yee Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210621154442.18463-1-yee.lee@mediatek.com \
--to=yee.lee@mediatek.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=matthias.bgg@gmail.com \
--cc=ryabinin.a.a@gmail.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox