From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C0EFC49361 for ; Thu, 17 Jun 2021 08:53:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E75FE61245 for ; Thu, 17 Jun 2021 08:53:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E75FE61245 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 68A2F6B0070; Thu, 17 Jun 2021 04:53:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 63A0F6B0071; Thu, 17 Jun 2021 04:53:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DA2A6B0072; Thu, 17 Jun 2021 04:53:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0245.hostedemail.com [216.40.44.245]) by kanga.kvack.org (Postfix) with ESMTP id 1F0D46B0070 for ; Thu, 17 Jun 2021 04:53:24 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A6202181AEF00 for ; Thu, 17 Jun 2021 08:53:23 +0000 (UTC) X-FDA: 78262601886.40.5FE458C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf09.hostedemail.com (Postfix) with ESMTP id DB3C9600014C for ; Thu, 17 Jun 2021 08:53:16 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id D1E741FDBF; Thu, 17 Jun 2021 08:53:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1623920001; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AqMZ6VDXQs8fACSxjEoTa3jWnXqlOeaX0ILKp41Ujpg=; b=vt+nizqaqNppg74ojCy5P9EV49Hx8U+2xEiapBW704yiHrbUGgs/d6MGdqxK3PVg/GkS/e RmLG2VCA7qqBsKJQ7MGYHGTGsmziJNs06z1QldT/CEjXmHCCf36WDqS67BmefBDMgvjlUV srhgdjuc1NB9pzfw/X19pQ/TcfLcXeQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1623920001; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AqMZ6VDXQs8fACSxjEoTa3jWnXqlOeaX0ILKp41Ujpg=; b=wNcM/bzZp+S6rae1Cjx+blaWgX6JIc/huCvNunJbz5gnULci61sK6dgac/Q02qOuAkVL3e V86JObPs0j//SiDQ== Received: from quack2.suse.cz (unknown [10.100.200.198]) by relay2.suse.de (Postfix) with ESMTP id 17E65A3BB7; Thu, 17 Jun 2021 08:53:20 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id E611F1F2C64; Thu, 17 Jun 2021 10:53:19 +0200 (CEST) Date: Thu, 17 Jun 2021 10:53:19 +0200 From: Jan Kara To: Christoph Hellwig Cc: Jan Kara , linux-fsdevel@vger.kernel.org, Dave Chinner , ceph-devel@vger.kernel.org, Chao Yu , Damien Le Moal , "Darrick J. Wong" , Jaegeuk Kim , Jeff Layton , Johannes Thumshirn , linux-cifs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-xfs@vger.kernel.org, Miklos Szeredi , Steve French , Ted Tso , Matthew Wilcox , Pavel Reichl , Dave Chinner , Eric Sandeen Subject: Re: [PATCH 07/14] xfs: Refactor xfs_isilocked() Message-ID: <20210617085319.GD32587@quack2.suse.cz> References: <20210615090844.6045-1-jack@suse.cz> <20210615091814.28626-7-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=vt+nizqa; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="wNcM/bzZ"; dmarc=none; spf=pass (imf09.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz X-Stat-Signature: wjjpznyqj3ggi7w9e3iofa67d8b5mht3 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: DB3C9600014C X-HE-Tag: 1623919996-919627 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 17-06-21 08:53:28, Christoph Hellwig wrote: > On Tue, Jun 15, 2021 at 11:17:57AM +0200, Jan Kara wrote: > > From: Pavel Reichl > > > > Refactor xfs_isilocked() to use newly introduced __xfs_rwsem_islocked(). > > __xfs_rwsem_islocked() is a helper function which encapsulates checking > > state of rw_semaphores hold by inode. > > Looks good with the updated commit log: > > Signed-off-by: Christoph Hellwig I suppose you mean Reviewed-by, don't you? Honza -- Jan Kara SUSE Labs, CR