From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA456C2B9F4 for ; Mon, 14 Jun 2021 15:52:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4C4D261185 for ; Mon, 14 Jun 2021 15:52:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C4D261185 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B53D16B006C; Mon, 14 Jun 2021 11:52:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B038A6B006E; Mon, 14 Jun 2021 11:52:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A4B56B0070; Mon, 14 Jun 2021 11:52:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 6760E6B006C for ; Mon, 14 Jun 2021 11:52:31 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E87125825 for ; Mon, 14 Jun 2021 15:52:30 +0000 (UTC) X-FDA: 78252771660.26.28BB7ED Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf09.hostedemail.com (Postfix) with ESMTP id A17216000143 for ; Mon, 14 Jun 2021 15:52:25 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 13D1068AFE; Mon, 14 Jun 2021 17:52:28 +0200 (CEST) Date: Mon, 14 Jun 2021 17:52:27 +0200 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , Andrew Morton , Jan Kara , Al Viro , Greg Kroah-Hartman , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] fs: unexport __set_page_dirty Message-ID: <20210614155227.GA2413@lst.de> References: <20210614061512.3966143-1-hch@lst.de> <20210614061512.3966143-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Authentication-Results: imf09.hostedemail.com; dkim=none; spf=none (imf09.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A17216000143 X-Stat-Signature: 9pqm6qgj189noun57u5qyguzbde61h6f X-HE-Tag: 1623685945-590769 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 14, 2021 at 01:32:42PM +0100, Matthew Wilcox wrote: > On Mon, Jun 14, 2021 at 08:15:10AM +0200, Christoph Hellwig wrote: > > __set_page_dirty is only used by built-in code. > > > > Signed-off-by: Christoph Hellwig > > Reviewed-by: Matthew Wilcox (Oracle) > > You might also want to do the equivalent of this: > > https://git.infradead.org/users/willy/pagecache.git/commitdiff/19b3bf0d1a51f41ce5450fdd863969c3d32dfe12 This looks nice, but not really directly related. I think you should just send it to Andrew.