From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EA56C48BE8 for ; Mon, 14 Jun 2021 09:42:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BFFBF61283 for ; Mon, 14 Jun 2021 09:42:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BFFBF61283 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3F3716B0072; Mon, 14 Jun 2021 05:42:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A3EF6B0073; Mon, 14 Jun 2021 05:42:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21EAE6B0074; Mon, 14 Jun 2021 05:42:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0037.hostedemail.com [216.40.44.37]) by kanga.kvack.org (Postfix) with ESMTP id E10646B0072 for ; Mon, 14 Jun 2021 05:42:10 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 780EF83EB for ; Mon, 14 Jun 2021 09:42:10 +0000 (UTC) X-FDA: 78251838420.25.F7330BD Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf11.hostedemail.com (Postfix) with ESMTP id 2A80120010A9 for ; Mon, 14 Jun 2021 09:42:00 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id CB7A02197F; Mon, 14 Jun 2021 09:42:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1623663728; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5VF4wx4G0e9qQliL3bw5l2XjtGudNuzSi9PypR4ch/k=; b=qS3qeTEwHHk2ClQI9IqN2xnn23QuCeY/p7Y7u5V1ouVelgJinu3EAnm4YeqHrxDzC1P6ib RxGdWArQt3sesHgrDUUwsjg+3Ql3tk0FlrZNFQHwKld/Y09ptjpKw0Uf3XHACCkEWrokJj ozH5hmnKGBhimQ4ACT/udVMkAsLW0Ro= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1623663728; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5VF4wx4G0e9qQliL3bw5l2XjtGudNuzSi9PypR4ch/k=; b=PbBkgy11v0GhAnNa/KM/Lnm81zc2i/7dLHHtMm8d8We9FY1/WjGwOC8LyXDiFuOWSKvfvr /LGPMiQ08+jcdqCw== Received: from quack2.suse.cz (unknown [10.100.200.198]) by relay2.suse.de (Postfix) with ESMTP id B57CFA3B93; Mon, 14 Jun 2021 09:42:08 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id E96891F2B82; Mon, 14 Jun 2021 11:42:07 +0200 (CEST) Date: Mon, 14 Jun 2021 11:42:07 +0200 From: Jan Kara To: Christoph Hellwig Cc: Andrew Morton , Jan Kara , Al Viro , Greg Kroah-Hartman , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] fs: unexport __set_page_dirty Message-ID: <20210614094207.GB26615@quack2.suse.cz> References: <20210614061512.3966143-1-hch@lst.de> <20210614061512.3966143-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210614061512.3966143-2-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 2A80120010A9 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qS3qeTEw; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=PbBkgy11; spf=pass (imf11.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none X-Stat-Signature: jrm9txqrfo71att6bcfdyanxbwxtk5i7 X-HE-Tag: 1623663720-699800 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 14-06-21 08:15:10, Christoph Hellwig wrote: > __set_page_dirty is only used by built-in code. > > Signed-off-by: Christoph Hellwig Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/buffer.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/buffer.c b/fs/buffer.c > index ea48c01fb76b..3d18831c7ad8 100644 > --- a/fs/buffer.c > +++ b/fs/buffer.c > @@ -611,7 +611,6 @@ void __set_page_dirty(struct page *page, struct address_space *mapping, > } > xa_unlock_irqrestore(&mapping->i_pages, flags); > } > -EXPORT_SYMBOL_GPL(__set_page_dirty); > > /* > * Add a page to the dirty page list. > -- > 2.30.2 > -- Jan Kara SUSE Labs, CR