From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05D52C48BE6 for ; Mon, 14 Jun 2021 09:35:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8A37161357 for ; Mon, 14 Jun 2021 09:35:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A37161357 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0C85D6B0070; Mon, 14 Jun 2021 05:35:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 078726B0071; Mon, 14 Jun 2021 05:35:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE52A6B0072; Mon, 14 Jun 2021 05:35:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0069.hostedemail.com [216.40.44.69]) by kanga.kvack.org (Postfix) with ESMTP id AA7846B0070 for ; Mon, 14 Jun 2021 05:35:09 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 44AFC181AEF00 for ; Mon, 14 Jun 2021 09:35:09 +0000 (UTC) X-FDA: 78251820738.33.7E90F78 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf26.hostedemail.com (Postfix) with ESMTP id 292C94202A1D for ; Mon, 14 Jun 2021 09:35:04 +0000 (UTC) Received: by mail-qt1-f178.google.com with SMTP id e3so8063571qte.0 for ; Mon, 14 Jun 2021 02:35:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to; bh=BwLjKWDoIuboclHNzBKSWqFVNk7NANaHk7eW7w1fojQ=; b=NSenXLth4ExLalDSsPdx1a/0En/1GiMUEWVLE1c9oTCt+ltSE6PoiCUjw4wRTXnWv8 dbdvEmd0Zx2cyggbnePNGBTVsFhSS2X1gRmVyAB1i8Tf0Hx5j9aVFZSyXehXtFRlqqh3 mhhf3NgoE/37JgviAQIln2r595REzo0HjIO6InwZsSooBuRPKxAcJ0FKiXtyco6DjYtx mEa46nX9g8A5kBiFkN+61MEpTJo1XHVnCmdUOdCXeenBTOIU0CftMAI9M60WCOYY4Mkk 3aynH5wpJNNZEg/flyDwcmD35qtwLsM339I+wYcfoNCxHQA7jCW4dqoV8RBE9aQvsO/y rM2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to; bh=BwLjKWDoIuboclHNzBKSWqFVNk7NANaHk7eW7w1fojQ=; b=jB4Lc7eliWAYYs04c0pgQKUKZ88z8KIQWeA7egLm1KzYeyWwtVnpGmBJt42fhDbHFL kjE+tMlyYSeIkGWvfcjWYQt6zTcmG7RdbmB0yC0FQZxN9rZyXL9eBkvd7PlXcO+JkcH7 CNY+0tJQ2hvgRUyp92cB6FiXLuOjmjAmldn3ql5Pshtbkg6wPM+EZ2BoslodnTICsToV 2+OtbX8TeSMmUfRU8qfUPlWryb20ISadYgr7pgWAraaJaV1nU6CxtfMqLztGIJ4JdGSL NpDX9C4SXI6VCuhm8Bls5UZsC8+HrUJIvAdtXFAD3vfl02dE1uNrOITQkD9h7HCP2sQn +75w== X-Gm-Message-State: AOAM530biEhlTtJ1jonHbw1hqqM1gpBFAVVPqXCO46RA23S6IsB4rYl0 gMzPY8TsN+sXD1R4R+Io1Ls= X-Google-Smtp-Source: ABdhPJxPDuTJ9Z4g2Bn1ljNEHiu6Qv3EmX7yNvDm1YA4tZMupp6hTU8Gh8HJK1CkfnCzIOwLaL2blQ== X-Received: by 2002:ac8:5558:: with SMTP id o24mr15734991qtr.18.1623663308342; Mon, 14 Jun 2021 02:35:08 -0700 (PDT) Received: from localhost.localdomain (ec2-35-169-212-159.compute-1.amazonaws.com. [35.169.212.159]) by smtp.gmail.com with ESMTPSA id h12sm9397095qkj.52.2021.06.14.02.35.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jun 2021 02:35:07 -0700 (PDT) From: SeongJae Park X-Google-Original-From: SeongJae Park To: sieberf@amazon.com Cc: sj38.park@gmail.com, Jonathan.Cameron@Huawei.com, acme@kernel.org, akpm@linux-foundation.org, alexander.shishkin@linux.intel.com, amit@kernel.org, benh@kernel.crashing.org, brendanhiggins@google.com, corbet@lwn.net, david@redhat.com, dwmw@amazon.com, elver@google.com, fan.du@intel.com, foersleo@amazon.de, greg@kroah.com, gthelen@google.com, guoju.fgj@alibaba-inc.com, linux-damon@amazon.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mgorman@suse.de, minchan@kernel.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, riel@surriel.com, rientjes@google.com, rostedt@goodmis.org, rppt@kernel.org, shakeelb@google.com, shuah@kernel.org, sjpark@amazon.de, snu@amazon.de, vbabka@suse.cz, vdavydov.dev@gmail.com, zgf574564920@gmail.com Subject: Re: [PATCH v29 09/13] mm/damon/dbgfs: Support multiple contexts Date: Mon, 14 Jun 2021 09:35:02 +0000 Message-Id: <20210614093502.16797-1-sjpark@amazon.de> X-Mailer: git-send-email 2.17.1 In-Reply-To: <98a75d0c-2d1a-807e-050b-fb8e7d92f447@amazon.com> Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=NSenXLth; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of sj38park@gmail.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=sj38park@gmail.com X-Rspamd-Server: rspam02 X-Stat-Signature: adgau8uzxuesx71gz1qh4j1a3hekn99c X-Rspamd-Queue-Id: 292C94202A1D X-HE-Tag: 1623663304-321042 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: SeongJae Park On Mon, 14 Jun 2021 11:30:12 +0200 wrote: > + new_dir = debugfs_create_dir(name, root); > + dbgfs_dirs[dbgfs_nr_ctxs] = new_dir; > > debugfs_create_dir might return ERR_PTR, should this be checked? Greg, the maintainer of debugfs, recommended to just ignore that: https://lore.kernel.org/linux-mm/YB1kZaD%2F7omxXztF@kroah.com/ Thanks, SeongJae Park