From: Mel Gorman <mgorman@techsingularity.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Zi Yan <ziy@nvidia.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Vlastimil Babka <vbabka@suse.cz>,
Michal Hocko <mhocko@kernel.org>,
Jesper Dangaard Brouer <brouer@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>
Subject: Re: [PATCH v2] mm/page_alloc: Allow high-order pages to be stored on the per-cpu lists
Date: Sat, 12 Jun 2021 11:07:06 +0100 [thread overview]
Message-ID: <20210612100706.GE30378@techsingularity.net> (raw)
In-Reply-To: <20210611162331.272f67eabffa491fc83798b4@linux-foundation.org>
On Fri, Jun 11, 2021 at 04:23:31PM -0700, Andrew Morton wrote:
> > +static inline int pindex_to_order(unsigned int pindex)
> > +{
> > + int order = pindex / MIGRATE_PCPTYPES;
> > +
> > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> > + if (order > PAGE_ALLOC_COSTLY_ORDER) {
> > + order = pageblock_order;
> > + VM_BUG_ON(order != pageblock_order);
>
> Somebody has trust issues?
>
Just a little bit :P
> > + }
> > +#else
> > + VM_BUG_ON(order > PAGE_ALLOC_COSTLY_ORDER);
> > +#endif
> > +
> > + return order;
> > +}
>
> Do we really need all these assertions, long-term?
>
No, definitely not. Even now it's but already the patch caught me by
surprise (breaking kvm boot) so I'd like to leave them in for at least
one release given the number of changes queued in your tree for the next
merge window.
Thanks.
--
Mel Gorman
SUSE Labs
prev parent reply other threads:[~2021-06-12 10:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 13:57 Mel Gorman
2021-06-11 23:23 ` Andrew Morton
2021-06-12 10:07 ` Mel Gorman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210612100706.GE30378@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=brouer@redhat.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=vbabka@suse.cz \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox