From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28480C48BD1 for ; Fri, 11 Jun 2021 14:04:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A4C49613C8 for ; Fri, 11 Jun 2021 14:04:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4C49613C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 37AED6B0036; Fri, 11 Jun 2021 10:04:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 32AD16B006C; Fri, 11 Jun 2021 10:04:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A5166B006E; Fri, 11 Jun 2021 10:04:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0142.hostedemail.com [216.40.44.142]) by kanga.kvack.org (Postfix) with ESMTP id D9A756B0036 for ; Fri, 11 Jun 2021 10:04:43 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 75A0782499A8 for ; Fri, 11 Jun 2021 14:04:43 +0000 (UTC) X-FDA: 78241613646.10.1A69E2A Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) by imf16.hostedemail.com (Postfix) with ESMTP id 7198B8019723 for ; Fri, 11 Jun 2021 14:04:35 +0000 (UTC) Received: by mail-qk1-f172.google.com with SMTP id i67so31015073qkc.4 for ; Fri, 11 Jun 2021 07:04:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to; bh=r/c6iN3kChwZor0LAKmN98reQDKw83m+JgMq3vlOYzk=; b=ApDhLfg6/OlZ3RoOxGam3o/qxZ2520nuCsT2ZvtlKeCf13BySsJVqmyq3y51GUlPE3 /Y9pNKNsv5BaP0KapqgZv7ymPxHgG+FVf6hHUvKh163Cd4MbBJKrMoZZBsbWKk76xIWu E7qathQcaDUGd1ViWpsjQEmMzpxjdewizGhbBZyWlbE37jOlLLJXkhMiqb0PS8e2eLfn Gq7nIg3MK7SIk51GnYMH8jEVltPSj3G4siJCHmQmpYcUXAug7XfU9Ewu4TcTjmhvHD8A SRwuOfdH6mOjggwx9wbWQr6OoNFbCtNlnKv9u833qffzAb90VygB2HQQlZl9i5J8XrW8 tI6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to; bh=r/c6iN3kChwZor0LAKmN98reQDKw83m+JgMq3vlOYzk=; b=EpxF4Pt+YwGU5mgnChF3C1fD6A8sCO3R1KwiTXvJBJywygWbt9ftV4RfCdJ+XOSNlL HMH3CTxfSvdkKNMvaUuDaYDmJpuOVOxgPZiQu+EF0qVTqUhNpMOQNewsmIDHzyWo1Nca J5+/KoP0iChHSwQX2up+MPjVz0J44Fq0biuTKOc8dRm0+U/ns7GMPfUN1RKyvlf2TsR2 CuER05R6ugrlltcIOL2VJlVyNNsZqS59JqxS7RiRFMkNQYz+imwPOQg6Er7WcHV9ARyq EE/+kfJH1PzvceS8sunodBLnn+w92vhbMnNR+eI9yk1Ko8L6t7sMEtI+wiBPJJ5V+96m WIkg== X-Gm-Message-State: AOAM5318maa9riZhebZso0P+kO5nAElmSM2yUAW4QkTosYRZJXTlgO21 N7HWd3wEQQNPik4MfPmdT0A= X-Google-Smtp-Source: ABdhPJxgRZdWfm7ahjsIsz3WmPJBB/+VALtMbNk/7sYup+DVGb/A3CDSjRETs3ADDHvlMwU2NTQgeA== X-Received: by 2002:a05:620a:29d4:: with SMTP id s20mr3939788qkp.287.1623420275669; Fri, 11 Jun 2021 07:04:35 -0700 (PDT) Received: from localhost.localdomain (ec2-35-169-212-159.compute-1.amazonaws.com. [35.169.212.159]) by smtp.gmail.com with ESMTPSA id x8sm4316376qkl.110.2021.06.11.07.04.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jun 2021 07:04:35 -0700 (PDT) From: SeongJae Park X-Google-Original-From: SeongJae Park To: Cc: SeongJae Park , akpm@linux-foundation.org, SeongJae Park , Jonathan.Cameron@Huawei.com, acme@kernel.org, alexander.shishkin@linux.intel.com, amit@kernel.org, benh@kernel.crashing.org, brendanhiggins@google.com, corbet@lwn.net, david@redhat.com, dwmw@amazon.com, elver@google.com, fan.du@intel.com, foersleo@amazon.de, greg@kroah.com, gthelen@google.com, guoju.fgj@alibaba-inc.com, mgorman@suse.de, minchan@kernel.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, riel@surriel.com, rientjes@google.com, rostedt@goodmis.org, rppt@kernel.org, shakeelb@google.com, shuah@kernel.org, snu@amazon.de, vbabka@suse.cz, vdavydov.dev@gmail.com, zgf574564920@gmail.com, linux-damon@amazon.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v29 12/13] mm/damon: Add user space selftests Date: Fri, 11 Jun 2021 14:04:27 +0000 Message-Id: <20210611140427.6375-1-sjpark@amazon.de> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210611135737.104838-1-mheyne@amazon.de> Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=ApDhLfg6; spf=pass (imf16.hostedemail.com: domain of sj38park@gmail.com designates 209.85.222.172 as permitted sender) smtp.mailfrom=sj38park@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: bakfsq395dodiuk3ntygg4dkzg7qdr5n X-Rspamd-Queue-Id: 7198B8019723 X-Rspamd-Server: rspam06 X-HE-Tag: 1623420275-850866 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: SeongJae Park Hello Max, > On Thu, 20 May 2021 07:56:28 +0000 SeongJae Park wrote: > > > From: SeongJae Park > > > > This commit adds a simple user space tests for DAMON. The tests are > > using kselftest framework. > > > > Signed-off-by: SeongJae Park > > --- > > tools/testing/selftests/damon/Makefile | 7 ++ > > .../selftests/damon/_chk_dependency.sh | 28 ++++++ > > .../testing/selftests/damon/debugfs_attrs.sh | 98 +++++++++++++++++++ > > 3 files changed, 133 insertions(+) > > create mode 100644 tools/testing/selftests/damon/Makefile > > create mode 100644 tools/testing/selftests/damon/_chk_dependency.sh > > create mode 100755 tools/testing/selftests/damon/debugfs_attrs.sh > > [...] > > diff --git a/tools/testing/selftests/damon/debugfs_attrs.sh b/tools/testing/selftests/damon/debugfs_attrs.sh > > new file mode 100755 > > index 000000000000..4a8ab4910ee4 > > --- /dev/null > > +++ b/tools/testing/selftests/damon/debugfs_attrs.sh > > @@ -0,0 +1,98 @@ > > +#!/bin/bash > > +# SPDX-License-Identifier: GPL-2.0 > > + > > +source ./_chk_dependency.sh > > + > > +# Test attrs file > > +file="$DBGFS/attrs" > > + > > +ORIG_CONTENT=$(cat $file) > > Missing quotes around $file. Can you run shellcheck on this code and fix all > reportings, please? Thanks for the nice suggestion. I will do so in the next spin. > > > + > > +echo 1 2 3 4 5 > $file > > +if [ $? -ne 0 ] > > +then > > + echo "$file write failed" > > + echo $ORIG_CONTENT > $file > > + exit 1 > > +fi > > + > > +echo 1 2 3 4 > $file > > +if [ $? -eq 0 ] > > +then > > + echo "$file write success (should failed)" > > + echo $ORIG_CONTENT > $file > > + exit 1 > > +fi > > + > > +CONTENT=$(cat $file) > > +if [ "$CONTENT" != "1 2 3 4 5" ] > > +then > > + echo "$file not written" > > + echo $ORIG_CONTENT > $file > > + exit 1 > > +fi > > I'd add test cases for the contents written to the attrs, like checking that > input min_nr_regions is actually smaller than the input max_nr_regions values. Good point. Will add the test case in the next spin. > > > + > > +echo $ORIG_CONTENT > $file > > + > > +# Test target_ids file > > +file="$DBGFS/target_ids" > > + > > +ORIG_CONTENT=$(cat $file) > > + > > +echo "1 2 3 4" > $file > > +if [ $? -ne 0 ] > > +then > > + echo "$file write fail" > > + echo $ORIG_CONTENT > $file > > + exit 1 > > +fi > > + > > +echo "1 2 abc 4" > $file > > +if [ $? -ne 0 ] > > +then > > + echo "$file write fail" > > + echo $ORIG_CONTENT > $file > > + exit 1 > > +fi > > I've seen this construct more than once. Any chance to refactor this code? Or is > this selftest not expected to grow in the future? Good point. Will modularize code for reducing duplicates. Thanks, SeongJae Park [...]