From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,URIBL_RED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7967C48BDF for ; Thu, 10 Jun 2021 19:40:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 00FCA613F1 for ; Thu, 10 Jun 2021 19:40:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00FCA613F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 99AB16B0078; Thu, 10 Jun 2021 15:40:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 94B9D6B007B; Thu, 10 Jun 2021 15:40:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 728FB6B007E; Thu, 10 Jun 2021 15:40:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0155.hostedemail.com [216.40.44.155]) by kanga.kvack.org (Postfix) with ESMTP id 6EEF46B0078 for ; Thu, 10 Jun 2021 15:40:26 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 2196F180AD820 for ; Thu, 10 Jun 2021 19:40:22 +0000 (UTC) X-FDA: 78238830684.23.42A8ABD Received: from smtprelay.test.hostedemail.com (mail.test.hostedemail.com [216.40.41.5]) by imf27.hostedemail.com (Postfix) with ESMTP id 28007801935A for ; Thu, 10 Jun 2021 19:40:16 +0000 (UTC) Received: from forelay.test.hostedemail.com (10.5.29.251.rfc1918.com [10.5.29.251]) by smtprelay01.test.hostedemail.com (Postfix) with ESMTP id 5B30D11CEC for ; Thu, 10 Jun 2021 19:40:21 +0000 (UTC) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve01.test.hostedemail.com (Postfix) with ESMTP id 3D1AA23810 for ; Thu, 10 Jun 2021 19:40:21 +0000 (UTC) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 86DBE942F for ; Thu, 10 Jun 2021 19:39:20 +0000 (UTC) X-FDA: 78238828080.20.F26DE1E Received: from smtprelay.test.hostedemail.com (mail.test.hostedemail.com [216.40.41.5]) by imf04.hostedemail.com (Postfix) with ESMTP id 78567549 for ; Thu, 10 Jun 2021 19:39:16 +0000 (UTC) Received: from forelay.test.hostedemail.com (10.5.29.251.rfc1918.com [10.5.29.251]) by smtprelay01.test.hostedemail.com (Postfix) with ESMTP id C04E311CEC for ; Thu, 10 Jun 2021 19:39:19 +0000 (UTC) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve01.test.hostedemail.com (Postfix) with ESMTP id A1D3323810 for ; Thu, 10 Jun 2021 19:39:19 +0000 (UTC) Received: from smtpin35.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A5A9C180AD807 for ; Thu, 10 Jun 2021 19:38:18 +0000 (UTC) X-FDA: 78238825476.35.E705F6B Received: from smtprelay.test.hostedemail.com (mail.test.hostedemail.com [216.40.41.5]) by imf02.hostedemail.com (Postfix) with ESMTP id 6C1994000290 for ; Thu, 10 Jun 2021 19:38:15 +0000 (UTC) Received: from forelay.test.hostedemail.com (10.5.29.251.rfc1918.com [10.5.29.251]) by smtprelay01.test.hostedemail.com (Postfix) with ESMTP id ED22E11CEC for ; Thu, 10 Jun 2021 19:38:17 +0000 (UTC) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve01.test.hostedemail.com (Postfix) with ESMTP id CF13723810 for ; Thu, 10 Jun 2021 19:38:17 +0000 (UTC) Received: from smtpin35.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 00D3D181AEF21 for ; Thu, 10 Jun 2021 19:37:16 +0000 (UTC) X-FDA: 78238822914.35.D8FCB32 Received: from smtprelay.test.hostedemail.com (mail.test.hostedemail.com [216.40.41.5]) by imf08.hostedemail.com (Postfix) with ESMTP id 8583480192EE for ; Thu, 10 Jun 2021 19:37:11 +0000 (UTC) Received: from forelay.test.hostedemail.com (10.5.29.251.rfc1918.com [10.5.29.251]) by smtprelay01.test.hostedemail.com (Postfix) with ESMTP id 5D14711CEC for ; Thu, 10 Jun 2021 19:37:16 +0000 (UTC) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve01.test.hostedemail.com (Postfix) with ESMTP id 40BF023810 for ; Thu, 10 Jun 2021 19:37:16 +0000 (UTC) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 8C14B942F for ; Thu, 10 Jun 2021 19:36:15 +0000 (UTC) X-FDA: 78238820310.05.4A35A91 Received: from smtprelay.test.hostedemail.com (mail.test.hostedemail.com [216.40.41.5]) by imf17.hostedemail.com (Postfix) with ESMTP id 67B69400028D for ; Thu, 10 Jun 2021 19:36:11 +0000 (UTC) Received: from forelay.test.hostedemail.com (10.5.29.251.rfc1918.com [10.5.29.251]) by smtprelay01.test.hostedemail.com (Postfix) with ESMTP id D7C4A11CEC for ; Thu, 10 Jun 2021 19:36:14 +0000 (UTC) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve01.test.hostedemail.com (Postfix) with ESMTP id B9C4F23810 for ; Thu, 10 Jun 2021 19:36:14 +0000 (UTC) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id EB4678249980 for ; Thu, 10 Jun 2021 19:35:08 +0000 (UTC) X-FDA: 78238817496.23.4C93623 Received: from smtprelay.test.hostedemail.com (mail.test.hostedemail.com [216.40.41.5]) by imf29.hostedemail.com (Postfix) with ESMTP id 3CBF3544 for ; Thu, 10 Jun 2021 19:35:01 +0000 (UTC) Received: from forelay.test.hostedemail.com (10.5.29.251.rfc1918.com [10.5.29.251]) by smtprelay01.test.hostedemail.com (Postfix) with ESMTP id 989EC11CEC for ; Thu, 10 Jun 2021 19:35:07 +0000 (UTC) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve01.test.hostedemail.com (Postfix) with ESMTP id 5E7DA23810 for ; Thu, 10 Jun 2021 19:35:06 +0000 (UTC) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 77D0398B3 for ; Thu, 10 Jun 2021 19:34:05 +0000 (UTC) X-FDA: 78238814850.24.17458A8 Received: from smtprelay.test.hostedemail.com (mail.test.hostedemail.com [216.40.41.5]) by imf28.hostedemail.com (Postfix) with ESMTP id 2EF2020010B3 for ; Thu, 10 Jun 2021 19:34:00 +0000 (UTC) Received: from forelay.test.hostedemail.com (10.5.29.251.rfc1918.com [10.5.29.251]) by smtprelay01.test.hostedemail.com (Postfix) with ESMTP id D95DF11CEC for ; Thu, 10 Jun 2021 19:34:04 +0000 (UTC) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve01.test.hostedemail.com (Postfix) with ESMTP id BB39423810 for ; Thu, 10 Jun 2021 19:34:04 +0000 (UTC) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id F2060A745 for ; Thu, 10 Jun 2021 19:33:03 +0000 (UTC) X-FDA: 78238812246.01.0F62BE4 Received: from smtprelay.test.hostedemail.com (mail.test.hostedemail.com [216.40.41.5]) by imf16.hostedemail.com (Postfix) with ESMTP id EC1C480192EE for ; Thu, 10 Jun 2021 19:32:58 +0000 (UTC) Received: from forelay.test.hostedemail.com (10.5.29.251.rfc1918.com [10.5.29.251]) by smtprelay01.test.hostedemail.com (Postfix) with ESMTP id 6E77D11CEC for ; Thu, 10 Jun 2021 19:33:03 +0000 (UTC) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve01.test.hostedemail.com (Postfix) with ESMTP id 55CFB23810 for ; Thu, 10 Jun 2021 19:33:01 +0000 (UTC) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B0FB0181AEF23 for ; Thu, 10 Jun 2021 19:32:00 +0000 (UTC) X-FDA: 78238809600.09.C5A09C8 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf13.hostedemail.com (Postfix) with ESMTP id 80CB8E00026C for ; Thu, 10 Jun 2021 19:31:55 +0000 (UTC) Received: by mail-lf1-f53.google.com with SMTP id f30so4992558lfj.1 for ; Thu, 10 Jun 2021 12:32:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ceEFCfaWcCIy0ElzDio4qVx5/HAKi3T4+rWQRTQywmk=; b=uTMmqKV1/EHV2IkJR+zozPe+lbZxHXntZRGKJ8BGJXBWDl7IfUoj83QbMq9vsWP9iL B8CLwVHTKzMobvTu9QYxYVCXWgiHZJlepd5QN95Ca3q2eChFOGqEjTtaYpR6xS8T/31e Bks6kNrS5X2KFxZJDsY2HobnnexCzqbw58fOXFxmNIX+2cmTyDZbKmsvCPaAHwi2UZkw BgFuBFqAMuK5oTkaomSeXQ0KclouWjis7nD/on4oIigkf6RZpNXP8QaCg/RewiTR/bi9 gXc6aptsZOYJtSJ4xNwNbKZZHkoTOptEO1thdiSFc8efeFUPzRDVhkkXAv2xmxOP/dAo Xsjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ceEFCfaWcCIy0ElzDio4qVx5/HAKi3T4+rWQRTQywmk=; b=B7KGT817QaXD9yRdJVWLJrG58FOpaKSnpP3YaG6rXsAuk5dEF1ZAjkWSCHOhhpX8ua JG0QoyHXa+PLxJdWDMWAQ/cMqnXF+OdKnlY7+WwBrWKxg9mmy7x1d1KY2ev7+/Ea5Dzd ueGKBsVGMFFbucv05anL3Lpz402mwyhSz/QCS/e96w9yjKidxxfbg6Gx5Gs6AMG2vD/z 7SLaFQmXJkiS10o/KrOF/0Rm1HZhPUwMVxc4wswxiiu3Xx1LaUcFQnWpNMzuLuVJK8mO iWwrXMgmhIqnrRCjV4XYXM9n43NIhodrxdV4byZX78pT/uogZWO08/CNT9RLwW08+uJm 3jQg== X-Gm-Message-State: AOAM530Ys8Ep+9a84Y7Rpsy/SrDzxRrcTX4AcdS2qylnDRBIjwDAK8EY kXIZecqCF3V8zo/F4bqz1x8= X-Google-Smtp-Source: ABdhPJzeKGA5ayEBXmZhKvS0JSerAdTETjvEF7FnTPCA+SF5O5wL34fvbQ+0BOjnrh5IGR0T0Yj+Ew== X-Received: by 2002:ac2:5a4b:: with SMTP id r11mr259219lfn.338.1623353518654; Thu, 10 Jun 2021 12:31:58 -0700 (PDT) Received: from pc638.lan (h5ef52e3d.seluork.dyn.perspektivbredband.net. [94.245.46.61]) by smtp.gmail.com with ESMTPSA id s12sm270903lfg.44.2021.06.10.12.31.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jun 2021 12:31:57 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 10 Jun 2021 21:31:55 +0200 To: Claudio Imbrenda Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, frankja@linux.ibm.com, borntraeger@de.ibm.com, cohuck@redhat.com, david@redhat.com, linux-mm@kvack.org, Andrew Morton , Nicholas Piggin , Uladzislau Rezki , Catalin Marinas , Thomas Gleixner , Ingo Molnar , David Rientjes , Christoph Hellwig Subject: Re: [PATCH v3 1/2] mm/vmalloc: add vmalloc_no_huge Message-ID: <20210610193155.GA1854@pc638.lan> References: <20210610154220.529122-1-imbrenda@linux.ibm.com> <20210610154220.529122-2-imbrenda@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210610154220.529122-2-imbrenda@linux.ibm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-HE-Tag: 1623353515-777695 X-HE-Tag: 1623353578-611885 X-HE-Tag: 1623353640-156195 X-HE-Tag: 1623353701-23648 X-HE-Tag: 1623353771-705074 X-HE-Tag: 1623353831-775825 X-HE-Tag: 1623353895-877651 X-HE-Tag: 1623353956-738519 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 28007801935A X-Stat-Signature: njxjpfqgfcgrhb4e5uuf1jf9uytwk36n Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=uTMmqKV1; dmarc=pass (policy=none) header.from=gmail.com; spf=softfail (imf27.hostedemail.com: 216.40.41.5 is neither permitted nor denied by domain of urezki@gmail.com) smtp.mailfrom=urezki@gmail.com X-HE-Tag: 1623354016-400741 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello. See below a small nit: > The recent patches to add support for hugepage vmalloc mappings added a > flag for __vmalloc_node_range to allow to request small pages. > This flag is not accessible when calling vmalloc, the only option is to > call directly __vmalloc_node_range, which is not exported. > > This means that a module can't vmalloc memory with small pages. > > Case in point: KVM on s390x needs to vmalloc a large area, and it needs > to be mapped with small pages, because of a hardware limitation. > > This patch adds the function vmalloc_no_huge, which works like vmalloc, > but it is guaranteed to always back the mapping using small pages. This > function is exported, therefore it is usable by modules. > > Signed-off-by: Claudio Imbrenda > Cc: Andrew Morton > Cc: Nicholas Piggin > Cc: Uladzislau Rezki (Sony) > Cc: Catalin Marinas > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: David Rientjes > Cc: Christoph Hellwig > --- > include/linux/vmalloc.h | 1 + > mm/vmalloc.c | 16 ++++++++++++++++ > 2 files changed, 17 insertions(+) > > diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h > index 4d668abb6391..bfaaf0b6fa76 100644 > --- a/include/linux/vmalloc.h > +++ b/include/linux/vmalloc.h > @@ -135,6 +135,7 @@ extern void *__vmalloc_node_range(unsigned long size, unsigned long align, > const void *caller); > void *__vmalloc_node(unsigned long size, unsigned long align, gfp_t gfp_mask, > int node, const void *caller); > +void *vmalloc_no_huge(unsigned long size); > > extern void vfree(const void *addr); > extern void vfree_atomic(const void *addr); > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index a13ac524f6ff..296a2fcc3fbe 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2998,6 +2998,22 @@ void *vmalloc(unsigned long size) > } > EXPORT_SYMBOL(vmalloc); > > +/** > + * vmalloc_no_huge - allocate virtually contiguous memory using small pages > + * @size: allocation size > + * You state that it allocates using "small pages". I think it might be confused for people because of that vague meaning. The comment should be improved, imho, saying rather about order-0 pages what we call "small pages". > + * Allocate enough non-huge pages to cover @size from the page level > + * allocator and map them into contiguous kernel virtual space. > + * > + * Return: pointer to the allocated memory or %NULL on error > + */ > +void *vmalloc_no_huge(unsigned long size) > +{ > + return __vmalloc_node_range(size, 1, VMALLOC_START, VMALLOC_END, GFP_KERNEL, PAGE_KERNEL, > + VM_NO_HUGE_VMAP, NUMA_NO_NODE, __builtin_return_address(0)); > +} > +EXPORT_SYMBOL(vmalloc_no_huge); > + > /** > * vzalloc - allocate virtually contiguous memory with zero fill > * @size: allocation size > -- > 2.31.1 > anyone looks good to me, please use: Reviewed-by: Uladzislau Rezki (Sony) Thanks. -- Vlad Rezki