From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BB1BC47094 for ; Thu, 10 Jun 2021 09:43:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C3DB6613FE for ; Thu, 10 Jun 2021 09:42:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3DB6613FE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 463F16B006E; Thu, 10 Jun 2021 05:42:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 413A96B0070; Thu, 10 Jun 2021 05:42:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 266A66B0071; Thu, 10 Jun 2021 05:42:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0215.hostedemail.com [216.40.44.215]) by kanga.kvack.org (Postfix) with ESMTP id E95E16B006E for ; Thu, 10 Jun 2021 05:42:58 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9C0538134 for ; Thu, 10 Jun 2021 09:42:58 +0000 (UTC) X-FDA: 78237325236.24.5C0019E Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by imf19.hostedemail.com (Postfix) with ESMTP id B6E219001E40 for ; Thu, 10 Jun 2021 09:42:52 +0000 (UTC) Received: by mail-lj1-f172.google.com with SMTP id a19so788863ljq.12 for ; Thu, 10 Jun 2021 02:42:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FZtPqiacUMa3RR146lKg3ZwOABR6cRUS7jKKlWzO7H4=; b=H5Sa0qVjQ2xgyVmHndXCzmF7Ekl/Myz3sUzhz7fRE8DMJ+q6hL9fxVGm8HMyEpD5Pq sDqyNz7EgRWEhguXWOhfVzX/oqdjpTJDgw9Tu0aQj04ruORnmNSCUvD91KS36KjQaWzv JaCEejKWRs4Ex6vRaxZ9zZce+0tRxeskRat4zSA/8NZ+YWK9RHGfy8bf9/9FSczBy2B5 SZmsukCbTs3vJdCKuq2AWtlu+tXHf0TxjpZhODhtjVV5dh5u+QJINfUcsxOLsDm1CreL FQCB17qdyLrdDe8H5m4+VZW9YIfXV6TCLnmjmVuGsVH883+MvbSnrFRwT64WpMJXnzEB Nx/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FZtPqiacUMa3RR146lKg3ZwOABR6cRUS7jKKlWzO7H4=; b=JeJ476wX1TzDshcjHRsFkYps2HV6S+keNI8EK4kx8ElzDEDgNhV5Ploi7b7FdSIY/6 T8AJKd7g/bTODUr1Py3nr8kvL2B2IgsTuk7ZZSc+D5JdIZbMHNz5INfjBlzKWr8iEGfT XYH0KpOVj9DT+ogdEPRnJfPbJr6JPsz3r//vaUa/aDkTlECavSmJ3Hpn+xpYUT9La5Ow vmFmae8duoNBZov3ivvyiXbTHbuKVMlHd64GivpS+xAWWjFzG8+4MQ02agtiT+8qCy6m hIgOaNQg7+u4DItmr1j7yZfV7LjaliNhhso/JPXRb2IefSyZUxPYSMj+nGk7dlvIEiYc kN5Q== X-Gm-Message-State: AOAM532xFsKvrN9t1LC5TVHjgEuurveFeamv53Ioez40J2sSIgvqC7qu xBumOf2fMOHOiq7TQ7hcig9yrA== X-Google-Smtp-Source: ABdhPJzlJTLZaCZNALHstNwyYrOK83yVaDPi5AM+4+CAkOVPrhmvIkRvQJVcwwM+1qOOHl8GjbRKCA== X-Received: by 2002:a2e:5cc4:: with SMTP id q187mr1426076ljb.177.1623318177119; Thu, 10 Jun 2021 02:42:57 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id 76sm277284ljj.32.2021.06.10.02.42.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jun 2021 02:42:56 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id BCC361027EE; Thu, 10 Jun 2021 12:43:12 +0300 (+03) Date: Thu, 10 Jun 2021 12:43:12 +0300 From: "Kirill A. Shutemov" To: Hugh Dickins Cc: Andrew Morton , "Kirill A. Shutemov" , Yang Shi , Wang Yugui , Matthew Wilcox , Alistair Popple , Ralph Campbell , Zi Yan , Peter Xu , Will Deacon , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/11] mm/thp: another PVMW_SYNC fix in page_vma_mapped_walk() Message-ID: <20210610094312.kzhhqyz4abe2yizg@box.shutemov.name> References: <589b358c-febc-c88e-d4c2-7834b37fa7bf@google.com> <1bdf384c-8137-a149-2a1e-475a4791c3c@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1bdf384c-8137-a149-2a1e-475a4791c3c@google.com> Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=shutemov-name.20150623.gappssmtp.com header.s=20150623 header.b=H5Sa0qVj; spf=none (imf19.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.208.172) smtp.mailfrom=kirill@shutemov.name; dmarc=none X-Stat-Signature: 75hjws5fy38kzkus7xs1myjx5jycu5ix X-Rspamd-Queue-Id: B6E219001E40 X-Rspamd-Server: rspam06 X-HE-Tag: 1623318172-287806 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 09, 2021 at 11:54:46PM -0700, Hugh Dickins wrote: > Aha! Shouldn't that quick scan over pte_none()s make sure that it holds > ptlock in the PVMW_SYNC case? That too might have been responsible for > BUGs or WARNs in split_huge_page_to_list() or its unmap_page(), though > I've never seen any. > > Fixes: ace71a19cec5 ("mm: introduce page_vma_mapped_walk()") > Signed-off-by: Hugh Dickins > Cc: Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov