From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01463C47094 for ; Thu, 10 Jun 2021 09:09:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6A001613F5 for ; Thu, 10 Jun 2021 09:09:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A001613F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F36D96B0070; Thu, 10 Jun 2021 05:09:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F0DDE6B0071; Thu, 10 Jun 2021 05:09:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD55E6B0072; Thu, 10 Jun 2021 05:09:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0182.hostedemail.com [216.40.44.182]) by kanga.kvack.org (Postfix) with ESMTP id AEBEF6B0070 for ; Thu, 10 Jun 2021 05:09:48 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 396F4181AEF21 for ; Thu, 10 Jun 2021 09:09:48 +0000 (UTC) X-FDA: 78237241656.22.E5CADD3 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf30.hostedemail.com (Postfix) with ESMTP id 030A0E000279 for ; Thu, 10 Jun 2021 09:09:44 +0000 (UTC) Received: by mail-lf1-f50.google.com with SMTP id v22so2087999lfa.3 for ; Thu, 10 Jun 2021 02:09:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RioqOdzdRiLsc62ht2G8+44sOJidvgbpfl8gprWW3as=; b=Uo0N65qx8MhaEKrrRkjcPKeXi7/fw07uTt89i+jf3zUHDlLLx+Nt8onjDOTMMc9mD9 8IN7kVb9V5KSRFfYdF4fST77xelWZtJRonVk9vpDBrEQB5Q2bY6rNRLNlZbDFqAgLTsx 8P6dCRzVD8+gHQq7YaIlcc0JIbOVTvVGP05jAftAlAnqCXV2uPZhb52nHMmb6d1cZRmh qFvUSL5ecV4aRtTfDXMzu/6JyEghU+qQx8+Z9EPt77bc8zW5Q0sAAyYegzA9YdAKjzUX VVgRHL/m/eeOSj1zjkZV0XUwcnZ2/H6pFQx//cw+fcmWe11oBEOpRCYAXXQgCmAF7b07 E8yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RioqOdzdRiLsc62ht2G8+44sOJidvgbpfl8gprWW3as=; b=NiT6eHwsGwkAlC1PpL2QbC6kvOPzZwzauhA+NHr2onS0yS2+Z9GZVK3ByS7nvhGI/1 W7f0sUXLtszvmMPgaX6n1lOlhbBOLhtdRFEhA1ApPWGUU6Gde3blzAwNn0eRcw8X65MB VGGGQRoEwBXA9Qu5xDgzXSyAmzWdtqc0zqi28/LmwIqEyd9+JO2m6RK5Z2JU7/a/AsIs e4BaZuZ2T+Jw6GYW8N/ptVTY8wMYr+hGWh+WWBNiNa0yS0gO5sD4VoooQvsx/Xn8QF/A 2DE8Y52HHV4f0AzFp3SfRBrc+F9Y95Edo7Vhyou2T9X2nY7i4tMMVbeN0mzYZokSMyMA +j0Q== X-Gm-Message-State: AOAM533ntAvqT9rfKVwxW3SuuoopBeq6cdUU2LZ5NNisLwT4Sgdc5MgZ /MfDSlndbxQUEWM7DNzdynvsiA== X-Google-Smtp-Source: ABdhPJyC1PrGEvvLqGrNBku7nlmRbDcEmp8p+n1RvzmX/dPGnBC4VPLnvPcd41jK3jQ+m36vQ15SFQ== X-Received: by 2002:ac2:4f92:: with SMTP id z18mr1234396lfs.343.1623316186435; Thu, 10 Jun 2021 02:09:46 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id v10sm238581lfg.224.2021.06.10.02.09.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jun 2021 02:09:45 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id AC8221027EE; Thu, 10 Jun 2021 12:10:01 +0300 (+03) Date: Thu, 10 Jun 2021 12:10:01 +0300 From: "Kirill A. Shutemov" To: Hugh Dickins Cc: Andrew Morton , "Kirill A. Shutemov" , Yang Shi , Wang Yugui , Matthew Wilcox , Alistair Popple , Ralph Campbell , Zi Yan , Peter Xu , Will Deacon , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/11] mm: page_vma_mapped_walk(): use pmde for *pvmw->pmd Message-ID: <20210610091001.mbkj7wu3qww474nt@box.shutemov.name> References: <589b358c-febc-c88e-d4c2-7834b37fa7bf@google.com> <53fbc9d-891e-46b2-cb4b-468c3b19238e@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53fbc9d-891e-46b2-cb4b-468c3b19238e@google.com> Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=shutemov-name.20150623.gappssmtp.com header.s=20150623 header.b=Uo0N65qx; dmarc=none; spf=none (imf30.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.167.50) smtp.mailfrom=kirill@shutemov.name X-Stat-Signature: afxewhmhe3d5zsebrzqfzqugw5bpyr48 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 030A0E000279 X-HE-Tag: 1623316184-941055 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 09, 2021 at 11:40:08PM -0700, Hugh Dickins wrote: > page_vma_mapped_walk() cleanup: re-evaluate pmde after taking lock, then > use it in subsequent tests, instead of repeatedly dereferencing pointer. > > Signed-off-by: Hugh Dickins > Cc: Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov