From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D92ABC48BCF for ; Wed, 9 Jun 2021 10:22:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8E1C3611AE for ; Wed, 9 Jun 2021 10:22:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E1C3611AE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 226B26B0036; Wed, 9 Jun 2021 06:22:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D6AD6B006E; Wed, 9 Jun 2021 06:22:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 029206B0070; Wed, 9 Jun 2021 06:22:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0039.hostedemail.com [216.40.44.39]) by kanga.kvack.org (Postfix) with ESMTP id C249E6B0036 for ; Wed, 9 Jun 2021 06:22:33 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6B494180AD815 for ; Wed, 9 Jun 2021 10:22:33 +0000 (UTC) X-FDA: 78233796186.13.88929C6 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by imf06.hostedemail.com (Postfix) with ESMTP id 56A6DC00CBE2 for ; Wed, 9 Jun 2021 10:22:29 +0000 (UTC) Received: by mail-lj1-f173.google.com with SMTP id u18so10789437lju.12 for ; Wed, 09 Jun 2021 03:22:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=o6uruXXgycz3PzmsGxFp0d1BH6LTSufRmzFrWdqQ4mc=; b=WB4dEGpOdPinEm37yCSXeOb6D6NGmvodkCMIURE5OEsPRgAChjTgjUOf1BPGpxDlSt XZ37m8l/AMowyMdfL8Tk5AmkhDlZN5ZO4DRPLEggRE/Fw4t0dCRTTQO5okB7njurPmm8 HHC0xGkm9eD8c1tAt+RaST4qnWogEoyparX5k+PHvDIbOKnIugRkigaogQE+eDphZ0R8 MkjmwjqyN5bDSVB8gpNUAM6KScvwAWU02bchsevARH3lUNk/m70Qt6TKpbJVnZ2z+heZ V156Rd6p2c/GNE0qgY7PKicdhzhWr9EpgkomRMyujgbsb5758ggedPeKi0m4ktFO2Kof 3rVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=o6uruXXgycz3PzmsGxFp0d1BH6LTSufRmzFrWdqQ4mc=; b=GDlLda2YylQmWhm+zHM0rK4JeTbgJ1c/wbpZRMpG2HIHxsejJai+mlNQCmIpGLTay6 6gT+4tRN8N1KyQ4Bt9uWtVFPGt+dj/Xh+uWFUsXgkszUOF84xPCCcqi96JodXJYIPvwP pWJc/JCs9ZfZ9ccLSuSh2A2y8CliwRhw0pjmyTkOqQ/760oqf1uc6pOsR/b58rjX4uhU gb9HBdk611VE51Q0fMO20BhcUupNR0rzPPtXx3V9giiYvTRGMa2nr99ODR9gam/J9cCA I4IQG9zeN7/LIRYV0EMrtPhQgBQBKJJJVxXmMxqf/l9dXyzVMM5FFlSnUXBLMrlibbQJ W/Nw== X-Gm-Message-State: AOAM5332TzEMHDtGxvjYGCIbEKG2jWVia6j8hWVh2Ma+nF0qRO7Ia+vt 9o8yHaYFqT4NOJCy0p68uXq+VQ== X-Google-Smtp-Source: ABdhPJzQoY/oPwGbmN/H6HFABut1q+iI/R7BfG6S7+o2muaOpqU8h056D2LLtf6t/RTpZlzRYWWqhA== X-Received: by 2002:a2e:a378:: with SMTP id i24mr1750832ljn.303.1623234151918; Wed, 09 Jun 2021 03:22:31 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id v12sm309344lfi.6.2021.06.09.03.22.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jun 2021 03:22:31 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 7DC7810265B; Wed, 9 Jun 2021 13:22:46 +0300 (+03) Date: Wed, 9 Jun 2021 13:22:46 +0300 From: "Kirill A. Shutemov" To: Hugh Dickins Cc: Andrew Morton , "Kirill A. Shutemov" , Yang Shi , Wang Yugui , Matthew Wilcox , Naoya Horiguchi , Alistair Popple , Ralph Campbell , Zi Yan , Miaohe Lin , Minchan Kim , Jue Wang , Peter Xu , Jan Kara , Shakeel Butt , Oscar Salvador , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 02/10] mm/thp: make is_huge_zero_pmd() safe and quicker Message-ID: <20210609102246.hgw23tsqyw7jxts3@box.shutemov.name> References: <21ea9ca-a1f5-8b90-5e88-95fb1c49bbfa@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21ea9ca-a1f5-8b90-5e88-95fb1c49bbfa@google.com> Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=shutemov-name.20150623.gappssmtp.com header.s=20150623 header.b=WB4dEGpO; spf=none (imf06.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.208.173) smtp.mailfrom=kirill@shutemov.name; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 56A6DC00CBE2 X-Stat-Signature: 5az6hgy9uptyyispb335y65yxrzz8ymu X-HE-Tag: 1623234149-944357 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 08, 2021 at 09:08:09PM -0700, Hugh Dickins wrote: > Most callers of is_huge_zero_pmd() supply a pmd already verified present; > but a few (notably zap_huge_pmd()) do not - it might be a pmd migration > entry, in which the pfn is encoded differently from a present pmd: which > might pass the is_huge_zero_pmd() test (though not on x86, since L1TF > forced us to protect against that); or perhaps even crash in pmd_page() > applied to a swap-like entry. > > Make it safe by adding pmd_present() check into is_huge_zero_pmd() itself; > and make it quicker by saving huge_zero_pfn, so that is_huge_zero_pmd() > will not need to do that pmd_page() lookup each time. > > __split_huge_pmd_locked() checked pmd_trans_huge() before: that worked, > but is unnecessary now that is_huge_zero_pmd() checks present. > > Fixes: e71769ae5260 ("mm: enable thp migration for shmem thp") > Signed-off-by: Hugh Dickins > Cc: Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov