From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 221A3C47082 for ; Tue, 8 Jun 2021 23:08:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C5CCE61364 for ; Tue, 8 Jun 2021 23:08:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5CCE61364 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6CA876B0072; Tue, 8 Jun 2021 19:08:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A11F6B0073; Tue, 8 Jun 2021 19:08:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 542346B0074; Tue, 8 Jun 2021 19:08:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0163.hostedemail.com [216.40.44.163]) by kanga.kvack.org (Postfix) with ESMTP id 21ADC6B0072 for ; Tue, 8 Jun 2021 19:08:17 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B9EED180AD815 for ; Tue, 8 Jun 2021 23:08:16 +0000 (UTC) X-FDA: 78232096992.17.A007FB0 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf11.hostedemail.com (Postfix) with ESMTP id 8F5FB200107C for ; Tue, 8 Jun 2021 23:08:12 +0000 (UTC) Received: by mail-pf1-f179.google.com with SMTP id u126so12920985pfu.13 for ; Tue, 08 Jun 2021 16:08:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tsOcayd7p5kwqaMZLuvyzUWjmMCtq6s6XW4ouQcpv3A=; b=QMsOr2yQt+lG5XNDYgmPFgMNQJAvua9p+XthSAPE+eIp8BKveU8h4RyuEA7ciOfD5d WDAite/miimuOfLX+uyImyaV5lmmPxMzbY5I5fr0A/R4E1newY8zeP6EJEhA+BGgtgIH +fD5lp0/HCXcUHXxIiI7AHmIbSQaNKlQ2AnRA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tsOcayd7p5kwqaMZLuvyzUWjmMCtq6s6XW4ouQcpv3A=; b=dTGQYlnsNOMmBwgMFyWyqGHUGwSox1aaDylHvCo5FjQ+JjbcWxYIR7N9GDlW1ABX4n jw/G9rpZEdYf7UClFuJWuLXSnWJWlMNy9HbrHd5CUP+983pCLJCEI7BJ/gTM9AW4vaWc E24TiRDKGUyE0f7oFU7G3bvykqxJM8TvwSDweV8Bys8r8FIMVfZD9UKqzhxSZs/mZpgO tL8KyaS75v70+RZVaS3obFr63dL+yJDV+GBQoozfEPwSX5K9zbSZWfh0HH9U/gUvsQP1 zBUPrGpnMbePF5OUhXXggNQEeM5INIX/uLWej4lPlHDCjKrgBTBNme/kjK5ACk9OHd68 ZMwg== X-Gm-Message-State: AOAM533QX/Z1giHPKmILpBsLIdtKK4Rl+Y6nwsz9iP16d+qZd5XMoMVr uZJSmw8/bq/1pandBBFxixZwIA== X-Google-Smtp-Source: ABdhPJxdn40QcfCA8eMkWU77J6EILIfV1TmIfUiG/sD+ni3fAblwXt+tWs27PX2+QOvKae8ApCvJxA== X-Received: by 2002:a63:1a4f:: with SMTP id a15mr641484pgm.136.1623193695104; Tue, 08 Jun 2021 16:08:15 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id h20sm11596260pfq.83.2021.06.08.16.08.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jun 2021 16:08:14 -0700 (PDT) Date: Tue, 8 Jun 2021 16:08:13 -0700 From: Kees Cook To: Andrew Morton Cc: Vlastimil Babka , Marco Elver , Christoph Lameter , "Lin, Zhenpeng" , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v4 0/3] Actually fix freelist pointer vs redzoning Message-ID: <202106081605.929AF37@keescook> References: <20210608183955.280836-1-keescook@chromium.org> <20210608135327.be8a120ba3b1686bc62e6d7e@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210608135327.be8a120ba3b1686bc62e6d7e@linux-foundation.org> Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=QMsOr2yQ; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf11.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.179 as permitted sender) smtp.mailfrom=keescook@chromium.org X-Rspamd-Server: rspam02 X-Stat-Signature: 3qozbkcc1r35sa9pi4xpjh69mnpchtny X-Rspamd-Queue-Id: 8F5FB200107C X-HE-Tag: 1623193692-187326 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 08, 2021 at 01:53:27PM -0700, Andrew Morton wrote: > On Tue, 8 Jun 2021 11:39:52 -0700 Kees Cook wrote: > > > This fixes redzoning vs the freelist pointer (both for middle-position > > and very small caches). Both are "theoretical" fixes, in that I see no > > evidence of such small-sized caches actually be used in the kernel, but > > that's no reason to let the bugs continue to exist, especially since > > people doing local development keep tripping over it. :) > > So I don't think this is suitable -stable material? Yeah, I think it's -stable material, but I'd like some bake time in -next just in case. zplin saw that there was a 2 * sizeof(void *) case that existed in the kernel that would trip over the issue. > It's a bit odd that patches 2&3 were cc:stable but #1 was not. Makes > one afraid that 2&3 might have had a dependency anyway. #1 is entirely cosmetic. It should also be fine to put into -stable, but since it had no operational impact, I figured it didn't need to be. > So I'm thinking that the whole series can just be for 5.14-rc1, in the > sent order. Unless I'm missing something big, yeah, that would be my preference too. (And -stable can pick it up then.) -- Kees Cook