From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48462C47082 for ; Tue, 8 Jun 2021 18:41:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F2E7361439 for ; Tue, 8 Jun 2021 18:41:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2E7361439 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8E1826B006C; Tue, 8 Jun 2021 14:41:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 890E76B006E; Tue, 8 Jun 2021 14:41:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70CA06B0070; Tue, 8 Jun 2021 14:41:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0104.hostedemail.com [216.40.44.104]) by kanga.kvack.org (Postfix) with ESMTP id 3BC936B006C for ; Tue, 8 Jun 2021 14:41:29 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D9B4A181AEF23 for ; Tue, 8 Jun 2021 18:41:28 +0000 (UTC) X-FDA: 78231424656.17.0E687F7 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf20.hostedemail.com (Postfix) with ESMTP id 42BD1371 for ; Tue, 8 Jun 2021 18:41:24 +0000 (UTC) Received: by mail-pl1-f178.google.com with SMTP id 11so11143795plk.12 for ; Tue, 08 Jun 2021 11:41:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=SZp6uz2Ck8oIq6wxVt6GqttZt2gt5CtwcdeJ/a3AShI=; b=gxkzoJMIs1RdWPPYKkIoSxZbaqJWSHw2/p8KP+34Wz3lAHDzkQ+Yya+Tx7yyFMpbO/ O1q58Qi0o1eZNGwTDeS7MCZ+NGjFyPBOw5WsI9MiMf3GNDW9RPsgWOJTQ95b9x3KHaYw nsAtbgZPb7IvINIcBabLPQeRQCQioxH7CCpEQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SZp6uz2Ck8oIq6wxVt6GqttZt2gt5CtwcdeJ/a3AShI=; b=SEptAF7EY5QkvdXf06e2jRvAPeu4ijSfuZApIByXa4O9Hz2hbMTTDls8Og52ZhzF3/ KYo+v1qtvoYBjiQotxZmglo8+6fWQUwuvoND26Me7mMRMjsU7rKLJq5D25wgRiKj3pLm IXoCawW8uatXRKq6qgcrBIBYLHt2iL22t/9EtJureCSuSz1zZOKG9VuGR5ErbZyuwJnl r1a8E8CvB2O8M4f0JZv+ydB7t1CCJgCVW2Vw0q9TNbMUxR4ZKuS2lLRxEtpvhQVUn5Sp p2hqaT7k9d2tCCfQID1FME+cSqPLGz8mYFnuAgYGWgy/dD07HmaeX5cIHdiIbdYApdXE H6Kg== X-Gm-Message-State: AOAM530Px5subun8e+/C80gnkB8lsTbl7S/tGmiuw2/23hFSAFs+XKmU JVATQyRbZacfaghVo4X0P0CZbA== X-Google-Smtp-Source: ABdhPJzg4xbVxL+sJetdvwUdArunUtHsb9HqdCZTqZeAbHoy5EbCxi7M9F/X5M8IGoRayTZBUFiUZQ== X-Received: by 2002:a17:90a:390d:: with SMTP id y13mr6165642pjb.133.1623177687587; Tue, 08 Jun 2021 11:41:27 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id n129sm11194890pfn.167.2021.06.08.11.41.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jun 2021 11:41:27 -0700 (PDT) Date: Tue, 8 Jun 2021 11:41:26 -0700 From: Kees Cook To: "Lin, Zhenpeng" Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] slub: choose the right freelist pointer location when creating small caches Message-ID: <202106081140.F73F91F@keescook> References: <6746FEEA-FD69-4792-8DDA-C78F5FE7DA02@psu.edu> <202106081125.E2DA4DE8@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=gxkzoJMI; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf20.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.178 as permitted sender) smtp.mailfrom=keescook@chromium.org X-Stat-Signature: m5znaty96sfe8k3qjaeh4pdwb5yfe3ec X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 42BD1371 X-HE-Tag: 1623177684-794093 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001028, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 08, 2021 at 06:33:01PM +0000, Lin, Zhenpeng wrote: > There do exist objects whose size is smaller than 2*sizeof(void*). E.g. struct ccid in DCCP module. Yes, sorry, I meant sizeof(void *). I've sent an updated v4 series and CCed you. Are you able to test that and see if it fixes it for you too? Thanks for the push to dust this series off again! :) -Kees -- Kees Cook