From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D289C47082 for ; Sat, 5 Jun 2021 05:43:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DCF3661404 for ; Sat, 5 Jun 2021 05:43:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCF3661404 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3BCF16B0036; Sat, 5 Jun 2021 01:43:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 332BC6B006C; Sat, 5 Jun 2021 01:43:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 186156B006E; Sat, 5 Jun 2021 01:43:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0219.hostedemail.com [216.40.44.219]) by kanga.kvack.org (Postfix) with ESMTP id D7C786B0036 for ; Sat, 5 Jun 2021 01:43:54 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 7721CA765 for ; Sat, 5 Jun 2021 05:43:54 +0000 (UTC) X-FDA: 78218578788.36.412FE1D Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf23.hostedemail.com (Postfix) with ESMTP id 20A1FA00386F for ; Sat, 5 Jun 2021 05:43:52 +0000 (UTC) Received: by mail-lf1-f48.google.com with SMTP id f30so17287388lfj.1 for ; Fri, 04 Jun 2021 22:43:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qhFNdOFEb7tY8E3v9lMAy3fzJKa2EYZF1NmtM8kq03Y=; b=miPPXNCovT0YwVjgGfAqeZGUX8KyHm0bPfhSO4EFDMf1mmQLqeJOmpY5tMvpghjiIu 4DwPBK7hc9MdrSZMgVuFgSApNQyzdRu/qSDWptesD0BbMdZFAfPXF6rAhOerWnxC+Wrg lEtkOuhPN2OzxJGbwyYgWmK0lKc3RKqtDwv5kEJTH41eIC7vBxbHto7OdNztvCUDmjcp W/zTpaVqoud7n6bx+0BMDKuig+EC3qD3ELjgeRvx1ezMotXBDlfwdmgxVzz/5/mtGlVM cIiYs4DFSLe6cabD1lzMemB98fSMPIZAJmA/1lNyWHAgNiNzAVtb7BYzWSvcTYn3VhWA vKkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qhFNdOFEb7tY8E3v9lMAy3fzJKa2EYZF1NmtM8kq03Y=; b=WftgHyhQ7LlkWwPG4/SciR4lvcxqWQMXPVLj/HWj+GYLD9mEbLXD9wR6c12Lfb5DDo DjgfDhAGuD6BH0xeOGqH+R9JTBuodPQh+INGVcbcF+4t18kvJyH8CpNFANo9AkntqhQd pObOCqLdpaXfhSWNMixMCvJ/NQDBqFPH+pFCcq+QJzwoMUPbCzTitI03az33JbQgm+wA HRKzULlGL74sLDmJNU9zTuZIVMF4srbtjgvMgME9ESv1Bs5E0/1UJ/G8Ldh2JVi4YEb5 p8Y7d8x1o4rbTUGYxm/Hgbg4bcXOE5NajXsVx7wJslLweQpukDwH0OXZyjtbeCwkVEfH 7qvA== X-Gm-Message-State: AOAM530Sr1nyjZzB6n1Js+XY39+586XJ3k+RBGtor3sdoOIWGsCOtOgP W4d2ANJ3mbAGPosNPPcfW5r2tAfzQRpUIg== X-Google-Smtp-Source: ABdhPJzILO3kFES+M4ohJdIk/vUuefxXO0mz4bOoX24CboUrQZ1Fu36xaXBa/ZFslEz2wl3HJQAPRw== X-Received: by 2002:a2e:9945:: with SMTP id r5mr4111309ljj.324.1622824852172; Fri, 04 Jun 2021 09:40:52 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id f9sm190602lfu.71.2021.06.04.09.40.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jun 2021 09:40:51 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id E6EDD1027A9; Fri, 4 Jun 2021 19:41:03 +0300 (+03) Date: Fri, 4 Jun 2021 19:41:03 +0300 From: "Kirill A. Shutemov" To: Hugh Dickins Cc: Andrew Morton , "Kirill A. Shutemov" , Yang Shi , Wang Yugui , Matthew Wilcox , Naoya Horiguchi , Alistair Popple , Ralph Campbell , Zi Yan , Miaohe Lin , Minchan Kim , Jue Wang , Peter Xu , Jan Kara , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] mm/thp: remap_page() is only needed on anonymous THP Message-ID: <20210604164103.bvwe6a2avgjbjmyn@box.shutemov.name> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=shutemov-name.20150623.gappssmtp.com header.s=20150623 header.b=miPPXNCo; spf=none (imf23.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.167.48) smtp.mailfrom=kirill@shutemov.name; dmarc=none X-Stat-Signature: bihw7sefw5nhrsqmkdap9q5qomce4jhz X-Rspamd-Queue-Id: 20A1FA00386F X-Rspamd-Server: rspam01 X-HE-Tag: 1622871832-539720 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 01, 2021 at 02:17:19PM -0700, Hugh Dickins wrote: > THP splitting's unmap_page() only sets TTU_SPLIT_FREEZE when PageAnon, > and migration entries are only inserted when TTU_MIGRATION (unused here) > or TTU_SPLIT_FREEZE is set: so it's just a waste of time for remap_page() > to search for migration entries to remove when !PageAnon. > > Fixes: baa355fd3314 ("thp: file pages support for split_huge_page()") > Signed-off-by: Hugh Dickins Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov