From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FBBFC4708F for ; Fri, 4 Jun 2021 06:38:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 82C9761405 for ; Fri, 4 Jun 2021 06:38:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82C9761405 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CA6426B0036; Fri, 4 Jun 2021 02:38:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C2F896B006C; Fri, 4 Jun 2021 02:38:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD0736B006E; Fri, 4 Jun 2021 02:38:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0106.hostedemail.com [216.40.44.106]) by kanga.kvack.org (Postfix) with ESMTP id 7813B6B0036 for ; Fri, 4 Jun 2021 02:38:44 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 16440180AD806 for ; Fri, 4 Jun 2021 06:38:44 +0000 (UTC) X-FDA: 78215088168.03.433924D Received: from r3-18.sinamail.sina.com.cn (r3-18.sinamail.sina.com.cn [202.108.3.18]) by imf29.hostedemail.com (Postfix) with SMTP id 6D88E2BFE for ; Fri, 4 Jun 2021 06:38:14 +0000 (UTC) Received: from unknown (HELO localhost.localdomain)([221.199.207.228]) by sina.com (172.16.97.35) with ESMTP id 60B9C5B100008BCC; Fri, 4 Jun 2021 14:18:27 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 9442215073508 From: Hillf Danton To: Shakeel Butt Cc: Tejun Heo , Johannes Weiner , Muchun Song , Michal Hocko , Roman Gushchin , "=?UTF-8?q?Michal=20Koutn=C3=BD?=" , Huang Ying , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] memcg: periodically flush the memcg stats Date: Fri, 4 Jun 2021 14:18:16 +0800 Message-Id: <20210604061816.3110-1-hdanton@sina.com> In-Reply-To: <20210604015640.2586269-2-shakeelb@google.com> References: <20210604015640.2586269-1-shakeelb@google.com> MIME-Version: 1.0 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 6D88E2BFE Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.18 as permitted sender) smtp.mailfrom=hdanton@sina.com; dmarc=none X-Stat-Signature: zdo3gmihcuztx7hp8w6tsggayrxfb385 X-HE-Tag: 1622788694-441181 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 3 Jun 2021 18:56:40 -0700 Shakeel Butt wrote: > =20 > +static void flush_memcg_stats(struct work_struct *w) > +{ > + cgroup_rstat_flush(root_mem_cgroup->css.cgroup); > + schedule_delayed_work(&stats_flush, round_jiffies(2UL*HZ)); > +} Given flush may block, the unbound wq is what you need. queue_delayed_work(system_unbound_wq, &stats_flush, 2 * HZ);