From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E86FC47082 for ; Thu, 3 Jun 2021 23:04:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E060F6140D for ; Thu, 3 Jun 2021 23:04:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E060F6140D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5CCC26B0036; Thu, 3 Jun 2021 19:04:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 57C6E6B006C; Thu, 3 Jun 2021 19:04:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41DFB6B0070; Thu, 3 Jun 2021 19:04:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0210.hostedemail.com [216.40.44.210]) by kanga.kvack.org (Postfix) with ESMTP id 10E646B0036 for ; Thu, 3 Jun 2021 19:04:07 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A223AE097 for ; Thu, 3 Jun 2021 23:04:06 +0000 (UTC) X-FDA: 78213942492.32.D429471 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf06.hostedemail.com (Postfix) with ESMTP id B98B3C0237C2 for ; Thu, 3 Jun 2021 23:03:48 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id F11EB6140C; Thu, 3 Jun 2021 23:03:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1622761436; bh=wByxFJxnTm7v9o+6E3GNLvXbUPJPgwB/67F9gWvAVDE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NkrdoEWtnPYLNUZLyjrdXKwXShdPr3gw3NC6L5F+XGesj9h8qzYD9feJw6Zuq9pEL BSZvlhsCGwgdNSbsZSLmChCZGeRV4V6bDCNKXxEu54BKDRCBLAYWP031EmWQMpW5Io GL3peBGdSKhL3NhGgz46dK9/kbDXVVttWSMcUnCQ= Date: Thu, 3 Jun 2021 16:03:55 -0700 From: Andrew Morton To: Hugh Dickins Cc: "Kirill A. Shutemov" , Yang Shi , Wang Yugui , Matthew Wilcox , Naoya Horiguchi , Alistair Popple , Ralph Campbell , Zi Yan , Miaohe Lin , Minchan Kim , Jue Wang , Peter Xu , Jan Kara , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/7] mm/thp: fix THP splitting unmap BUGs and related Message-Id: <20210603160355.2f73daab711ece5b85f6d82e@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B98B3C0237C2 Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=NkrdoEWt; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam04 X-Stat-Signature: 8mxc7juu8prfjuxx98ezq76bxr1q6eic X-HE-Tag: 1622761428-643599 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 3 Jun 2021 15:21:35 -0700 (PDT) Hugh Dickins wrote: > And here's my attempt to rewrite history: mmotm-adjust.tar contains > > before/series > before/mm-remove-special-swap-entry-functions.patch > before/mm-rmap-split-try_to_munlock-from-try_to_unmap.patch > before/mm-huge_memoryc-remove-unnecessary-tlb_remove_page_size-for-huge-zero-pmd.patch > after/series > after/mm-remove-special-swap-entry-functions.patch > after/mm-rmap-split-try_to_munlock-from-try_to_unmap.patch > after/mm-huge_memoryc-remove-unnecessary-tlb_remove_page_size-for-huge-zero-pmd.patch > > "before" contains the originals from mmotm .DATE=2021-06-01-19-57: > your series file, two patches from Alistair and one from Miaohe, which > gave rejects when I inserted this 1-7/7 patchset and Yang Shi's 1-2/2 > earlier. All other patches applied cleanly, but could be refreshed. > > "after" contains my replacements to those: adjusting them to how they > would have been written if this patchset and Yang Shi's went first > (and in adjusting some of the comments in Alistair's, I did not > recognize the reason given for unmap_page() using try_to_unmap() > on file THPs, so substituted my own explanation). > > As diff'ing the series will show, first thing is to delete the old > > mm-rmap-make-try_to_unmap-void-function-fix-fix.patch > mm-rmap-make-try_to_unmap-void-function-fix.patch > mm-rmap-make-try_to_unmap-void-function.patch > mm-thp-replace-debug_vm-bug-with-vm_warn-when-unmap-fails-for-split.patch > mm-thp-check-total_mapcount-instead-of-page_mapcount-fix-fix-fix.patch > > Then insert, from the mailing list > > hughd1.patch > hughd2.patch > hughd3.patch > hughd4.patch > hughd5.patch > hughd6.patch > yangshi1.patch > yangshi2.patch > hughd7.patch There have been some significant-appearing review comments coming in on hughdN.patch just today. So... I think I'll pass for now. How about when the dust has settled you send out a complete series of the hughd and yahgshi patches against Linus mainline?