From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 546DCC4708F for ; Wed, 2 Jun 2021 03:04:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C67E561042 for ; Wed, 2 Jun 2021 03:04:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C67E561042 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 557476B006C; Tue, 1 Jun 2021 23:04:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5080D6B006E; Tue, 1 Jun 2021 23:04:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D07E6B0070; Tue, 1 Jun 2021 23:04:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0C0256B006C for ; Tue, 1 Jun 2021 23:04:06 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id ACD27180AD801 for ; Wed, 2 Jun 2021 03:04:06 +0000 (UTC) X-FDA: 78207289692.32.CDBA132 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 8B363C00CBE5 for ; Wed, 2 Jun 2021 03:03:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622603045; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pfb3/XreVqFVNMLi7DKOXN/l9kZ+q5QcC5gJlzdZ+/0=; b=gS3hvZNeaqOBXAG6ib1yTmVXS228TrCNc8hPdGruviLKF32FrxNbJgRlMS65eDsp9ROQdk wjo8CPtJ0TQwi2cXkADrcKhv+aKWWkPG8WLtFxbaJRRZoo2dRE8KEESaKp9dh6bK2cW/Jo S48yicPDvx/YrH0pv/3bD0gPuEsbH1w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-283-x4cRLKwLPL2Uxmuvdvs2xA-1; Tue, 01 Jun 2021 23:04:04 -0400 X-MC-Unique: x4cRLKwLPL2Uxmuvdvs2xA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2AE6F501E3; Wed, 2 Jun 2021 03:04:03 +0000 (UTC) Received: from localhost (ovpn-13-33.pek2.redhat.com [10.72.13.33]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B9BAE5D764; Wed, 2 Jun 2021 03:03:55 +0000 (UTC) Date: Wed, 2 Jun 2021 11:03:53 +0800 From: Baoquan He To: HAGIO =?utf-8?B?S0FaVUhJVE8o6JCp5bC+44CA5LiA5LuBKQ==?= Cc: Andrew Morton , David Hildenbrand , Dong Aisheng , Dong Aisheng , "linux-mm@kvack.org" , open list , Dave Young , Vivek Goyal , "kexec@lists.infradead.org" Subject: Re: [PATCH V2 4/6] mm: rename the global section array to mem_sections Message-ID: <20210602030353.GA409140@MiWiFi-R3L-srv> References: <20210531091908.1738465-1-aisheng.dong@nxp.com> <20210531091908.1738465-5-aisheng.dong@nxp.com> <42617372-c846-85fe-4739-abbe55eca8f6@redhat.com> <20210601165246.99d7374d07661b7e91e49cb6@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Rspamd-Queue-Id: 8B363C00CBE5 Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gS3hvZNe; spf=none (imf03.hostedemail.com: domain of bhe@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam04 X-Stat-Signature: kjji39wunq8c6xa4zpr1czgx53j8berq X-HE-Tag: 1622603033-536801 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06/02/21 at 01:11am, HAGIO KAZUHITO(=E8=90=A9=E5=B0=BE =E4=B8=80=E4=BB= =81) wrote: > -----Original Message----- > > On Tue, 1 Jun 2021 10:40:09 +0200 David Hildenbrand wrote: > >=20 > > > > Thanks, i explained the reason during my last reply. > > > > Andrew has already picked this patch to -mm tree. > > > > > > Just because it's in Andrews tree doesn't mean it will end up upstr= eam. ;) > > > > > > Anyhow, no really strong opinion, it's simply unnecessary code chur= n > > > that makes bisecting harder without real value IMHO. > >=20 > > I think it's a good change - mem_sections refers to multiple instance= s > > of a mem_section. Churn is a pain, but that's the price we pay for m= ore > > readable code. And for having screwed it up originally ;) >=20 > From a makedumpfile/crash-utility viewpoint, I don't deny kernel improv= ement > and probably the change will not be hard for them to support, but I'd l= ike > you to remember that the tool users will need to update them for the ch= ange. As VIM user, I can understand Aisheng's feeling on the mem_section variable which has the same symbol name as its type. Meanwhile it does cause makedumpfile/crash having to be changed accordingly. Maybe we can carry it when any essential change is needed in both kernel and makedumpfile/crash around it. >=20 > The situation where we need to update the tools for new kernels is usua= l, but > there are not many cases that they cannot even start session, and this = change By the way, Kazu, about a case starting session, could you be more specif= ic or rephrase? I may not get it clearly. Thanks. > will cause it. Personally I wonder the change is worth forcing users t= o update > them. >=20 > Thanks, > Kazu >=20