From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C7E3C4708F for ; Wed, 2 Jun 2021 02:26:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A97A56102A for ; Wed, 2 Jun 2021 02:26:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A97A56102A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0DD226B006C; Tue, 1 Jun 2021 22:26:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C4B86B006E; Tue, 1 Jun 2021 22:26:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0BF66B0071; Tue, 1 Jun 2021 22:26:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0119.hostedemail.com [216.40.44.119]) by kanga.kvack.org (Postfix) with ESMTP id A72CF6B006C for ; Tue, 1 Jun 2021 22:26:34 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4EC81824999B for ; Wed, 2 Jun 2021 02:26:34 +0000 (UTC) X-FDA: 78207195108.12.D658945 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf21.hostedemail.com (Postfix) with ESMTP id 31E72E000258 for ; Wed, 2 Jun 2021 02:26:17 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9DB0561351; Wed, 2 Jun 2021 02:26:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1622600792; bh=P+ozhEM6eflHK0MwGKnJouOmnGB98sXAB7sz7QooHj8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=izUDmZ0yW5RXom1irJcMa7khmSvK/tp6eQKZ3OE4277UMikg5+PhSgJxQfjmVlbV/ YIi+X35/pT+n0Nl3KJYdAjzSSV6lUKKwV68DUoJp/RrgQa1cAMfYyuEaAfhv/2m1eC 18K/W9I4IMnVV5TunslBdHnPtBzhKaNANy8YZwXk= Date: Tue, 1 Jun 2021 19:26:30 -0700 From: Andrew Morton To: HAGIO =?UTF-8?B?S0FaVUhJVE8=?=(=?UTF-8?B?6JCp5bC+44CA5LiA5LuB?=) Cc: David Hildenbrand , Dong Aisheng , Dong Aisheng , "linux-mm@kvack.org" , open list , Dave Young , Baoquan He , Vivek Goyal , "kexec@lists.infradead.org" Subject: Re: [PATCH V2 4/6] mm: rename the global section array to mem_sections Message-Id: <20210601192630.884b1f51b81f60f5f0823694@linux-foundation.org> In-Reply-To: References: <20210531091908.1738465-1-aisheng.dong@nxp.com> <20210531091908.1738465-5-aisheng.dong@nxp.com> <42617372-c846-85fe-4739-abbe55eca8f6@redhat.com> <20210601165246.99d7374d07661b7e91e49cb6@linux-foundation.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=izUDmZ0y; dmarc=none; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Stat-Signature: 5f6nx78ximrj6b8kqr49gyq49oczs99c X-Rspamd-Queue-Id: 31E72E000258 X-Rspamd-Server: rspam02 X-HE-Tag: 1622600777-93986 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2 Jun 2021 01:11:07 +0000 HAGIO KAZUHITO(=E8=90=A9=E5=B0=BE=E3=80= =80=E4=B8=80=E4=BB=81) wrote: > -----Original Message----- > > On Tue, 1 Jun 2021 10:40:09 +0200 David Hildenbrand wrote: > >=20 > > > > Thanks, i explained the reason during my last reply. > > > > Andrew has already picked this patch to -mm tree. > > > > > > Just because it's in Andrews tree doesn't mean it will end up upstr= eam. ;) > > > > > > Anyhow, no really strong opinion, it's simply unnecessary code chur= n > > > that makes bisecting harder without real value IMHO. > >=20 > > I think it's a good change - mem_sections refers to multiple instance= s > > of a mem_section. Churn is a pain, but that's the price we pay for m= ore > > readable code. And for having screwed it up originally ;) >=20 > >From a makedumpfile/crash-utility viewpoint, I don't deny kernel impro= vement > and probably the change will not be hard for them to support, but I'd l= ike > you to remember that the tool users will need to update them for the ch= ange. >=20 > The situation where we need to update the tools for new kernels is usua= l, but > there are not many cases that they cannot even start session, and this = change > will cause it. Personally I wonder the change is worth forcing users t= o update > them. Didn't know that. I guess I'll drop it then. We could do an assembly-level alias I assume..