From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA515C47080 for ; Tue, 1 Jun 2021 23:52:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6C67C613D3 for ; Tue, 1 Jun 2021 23:52:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C67C613D3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D838A6B006C; Tue, 1 Jun 2021 19:52:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D0CCB6B006E; Tue, 1 Jun 2021 19:52:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BACC76B0070; Tue, 1 Jun 2021 19:52:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0136.hostedemail.com [216.40.44.136]) by kanga.kvack.org (Postfix) with ESMTP id 895F86B006C for ; Tue, 1 Jun 2021 19:52:49 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 2633A180AD81D for ; Tue, 1 Jun 2021 23:52:49 +0000 (UTC) X-FDA: 78206807658.38.0E9B504 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf13.hostedemail.com (Postfix) with ESMTP id 08323E000245 for ; Tue, 1 Jun 2021 23:52:35 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 70F0E613AD; Tue, 1 Jun 2021 23:52:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1622591567; bh=dxjDIz0r0b7xu1n9w+LYp4IakkKBhTx8Jn5ZMEZwbhI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HCyhQjonnStyx/IAf6j38G5VoiTAkwlYEGBOjWwsTQRs9d74mqf0NIB6G9LdowvNg 06s4vaky2uliZYTTcrBHtdLErU12UipwM8Aqzb7u303acCyzFmTU6JaEsi+VvCVr0d B4feOWRTx/LtL6nVZMHV5JUfKevSWoHIaGwUrPTE= Date: Tue, 1 Jun 2021 16:52:46 -0700 From: Andrew Morton To: David Hildenbrand Cc: Dong Aisheng , Dong Aisheng , linux-mm@kvack.org, open list , Dave Young , Baoquan He , Vivek Goyal , kexec@lists.infradead.org Subject: Re: [PATCH V2 4/6] mm: rename the global section array to mem_sections Message-Id: <20210601165246.99d7374d07661b7e91e49cb6@linux-foundation.org> In-Reply-To: References: <20210531091908.1738465-1-aisheng.dong@nxp.com> <20210531091908.1738465-5-aisheng.dong@nxp.com> <42617372-c846-85fe-4739-abbe55eca8f6@redhat.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=HCyhQjon; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 08323E000245 X-Stat-Signature: 8d8ibk66y63rf6pbf31zs9bfdhsy6xcm X-HE-Tag: 1622591555-362546 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 1 Jun 2021 10:40:09 +0200 David Hildenbrand wrote: > > Thanks, i explained the reason during my last reply. > > Andrew has already picked this patch to -mm tree. > > Just because it's in Andrews tree doesn't mean it will end up upstream. ;) > > Anyhow, no really strong opinion, it's simply unnecessary code churn > that makes bisecting harder without real value IMHO. I think it's a good change - mem_sections refers to multiple instances of a mem_section. Churn is a pain, but that's the price we pay for more readable code. And for having screwed it up originally ;)