From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58494C4708F for ; Tue, 1 Jun 2021 10:43:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CCB1761090 for ; Tue, 1 Jun 2021 10:43:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CCB1761090 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4280F6B00B5; Tue, 1 Jun 2021 06:43:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D7FD6B00B6; Tue, 1 Jun 2021 06:43:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 278326B00B7; Tue, 1 Jun 2021 06:43:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0158.hostedemail.com [216.40.44.158]) by kanga.kvack.org (Postfix) with ESMTP id ECCED6B00B5 for ; Tue, 1 Jun 2021 06:43:52 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8645DB7AB for ; Tue, 1 Jun 2021 10:43:52 +0000 (UTC) X-FDA: 78204819504.02.76935A8 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf28.hostedemail.com (Postfix) with ESMTP id 73029200109E for ; Tue, 1 Jun 2021 10:43:40 +0000 (UTC) Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 151Ag0uY029859; Tue, 1 Jun 2021 10:43:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=Gx79InivmVewarDJyyMOVuflbWM4unS5ErB5h13b2Lw=; b=gB+WLL32hgD4VzXFy1XC5N3VAJUPyY2GBN9nXi8S5ZZozIwng/PV/N7iipnoRHupUwiV gsxJ+5FZCfCnHYsnfh2h4Aos8UtQq7xVY83znarvvFf6Bhi1T7HdmeFik4ceTdLBkPIz w0EvYCpC1lbFNCoHJ3dYCNo1eT5n6fM7mGhpqgpd9cgXfScdXPCZQbKbMSC2RV12NgzO zJ23bzCAquQslCy6ONKWuw3hkOAnmieS8T3i/wQTM8FXWARfQ38FzPny/Z/mKF7FIe7f 2Gms6P/aMqcWuVn5faE2SS30+WquZyIwySlx6sIKDNSt2pNKxFLHuO7t3ejfUTkdPi1N GA== Received: from oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 38vjar0js1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Jun 2021 10:43:49 +0000 Received: from aserp3030.oracle.com (aserp3030.oracle.com [127.0.0.1]) by pps.podrdrct (8.16.0.36/8.16.0.36) with SMTP id 151AhmAG003720; Tue, 1 Jun 2021 10:43:48 GMT Received: from pps.reinject (localhost [127.0.0.1]) by aserp3030.oracle.com with ESMTP id 38ubnd3n98-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Jun 2021 10:43:48 +0000 Received: from aserp3030.oracle.com (aserp3030.oracle.com [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 151AhmgW003708; Tue, 1 Jun 2021 10:43:48 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 38ubnd3n92-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Jun 2021 10:43:48 +0000 Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 151AhkJL013285; Tue, 1 Jun 2021 10:43:46 GMT Received: from kadam (/41.212.42.34) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 01 Jun 2021 03:43:46 -0700 Date: Tue, 1 Jun 2021 13:43:37 +0300 From: Dan Carpenter To: Mel Gorman Cc: Andrew Morton , Yang Shi , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mm: thp: fix a double unlock bug Message-ID: <20210601104337.GX1955@kadam> References: <20210601100849.GQ3672@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210601100849.GQ3672@suse.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-ORIG-GUID: Qpm2tEc2qMH89MRHSfhoULSDgCa0t8Yn X-Proofpoint-GUID: Qpm2tEc2qMH89MRHSfhoULSDgCa0t8Yn Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2020-01-29 header.b=gB+WLL32; dmarc=pass (policy=none) header.from=oracle.com; spf=none (imf28.hostedemail.com: domain of dan.carpenter@oracle.com has no SPF policy when checking 205.220.165.32) smtp.mailfrom=dan.carpenter@oracle.com X-Stat-Signature: 5hzwxyf13qdnwms4bcre4et7ctiwguq8 X-Rspamd-Queue-Id: 73029200109E X-Rspamd-Server: rspam02 X-HE-Tag: 1622544220-886143 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 01, 2021 at 11:08:49AM +0100, Mel Gorman wrote: > On Tue, Jun 01, 2021 at 12:24:09PM +0300, Dan Carpenter wrote: > > We're supposed to be holding the "vmf->ptl" spin_lock when we goto > > out_map. The lock is dropped after if finishes cleaning up. > > > > Fixes: 9aff7b33c74a ("mm: thp: refactor NUMA fault handling") > > Signed-off-by: Dan Carpenter > > Ouch. > > Acked-by: Mel Gorman > > However, that git commit is not stable. Instead of Fixes: I would > suggest renaming the patch to "mm: thp: refactor NUMA fault handling > -fix" and replacing Fixes with "This patch is a fix to the mmotm patch > mm-thp-refactor-numa-fault-handling.patch". Andrew usually slots that > into the correct place in his quilt series and collapses the fixes before > sending to Linus which works better with bisection. I know that these normally get folded in, but I assumed that Andrew would want the Fixes tag so that he could fold them in automatically using a mutt alias. #OneClickShopping regards, dan carpenter