From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34594C47082 for ; Sat, 29 May 2021 06:40:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BCAC8611AE for ; Sat, 29 May 2021 06:40:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCAC8611AE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3DD4E6B006E; Sat, 29 May 2021 02:40:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 38D776B0070; Sat, 29 May 2021 02:40:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22E756B0071; Sat, 29 May 2021 02:40:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0120.hostedemail.com [216.40.44.120]) by kanga.kvack.org (Postfix) with ESMTP id E3A1D6B006E for ; Sat, 29 May 2021 02:40:25 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 6A0478249980 for ; Sat, 29 May 2021 06:40:25 +0000 (UTC) X-FDA: 78193319610.15.E4715AF Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf27.hostedemail.com (Postfix) with ESMTP id 9AFCB8019342 for ; Sat, 29 May 2021 06:40:15 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 9D0E068B05; Sat, 29 May 2021 08:40:22 +0200 (CEST) Date: Sat, 29 May 2021 08:40:22 +0200 From: Christoph Hellwig To: Felix Kuehling Cc: felix.kuehling@amd.com, akpm@linux-foundation.org, linux-mm@kvack.org, hch@lst.de, jglisse@redhat.com, jgg@nvidia.com, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Alex Sierra Subject: Re: [RFC PATCH 4/5] mm: add generic type support for device zone page migration Message-ID: <20210529064022.GB15834@lst.de> References: <20210527230809.3701-1-Felix.Kuehling@amd.com> <20210527230809.3701-5-Felix.Kuehling@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210527230809.3701-5-Felix.Kuehling@amd.com> User-Agent: Mutt/1.5.17 (2007-11-01) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=none; spf=none (imf27.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 9AFCB8019342 X-Stat-Signature: dupppangb4f7a8p6estcp1kymx6pi9ks X-HE-Tag: 1622270415-613868 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 27, 2021 at 07:08:08PM -0400, Felix Kuehling wrote: > - expected_count +=3D is_device_private_page(page); > + expected_count +=3D > + (is_device_private_page(page) || is_device_generic_page(page)); Please avoid the completely unreadable overly long lines. And given how oft=E3=81=B8n this check is duplicated you probably really want a hel= per. And properly document it while you're at it.