From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25F5BC47082 for ; Thu, 27 May 2021 00:31:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7DE466139A for ; Thu, 27 May 2021 00:31:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7DE466139A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EA6A56B0036; Wed, 26 May 2021 20:31:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E7CE76B006E; Wed, 26 May 2021 20:31:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D6C316B0070; Wed, 26 May 2021 20:31:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0222.hostedemail.com [216.40.44.222]) by kanga.kvack.org (Postfix) with ESMTP id A96316B0036 for ; Wed, 26 May 2021 20:31:43 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 468FBA2C2 for ; Thu, 27 May 2021 00:31:43 +0000 (UTC) X-FDA: 78185132886.07.0E3CCD3 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf21.hostedemail.com (Postfix) with ESMTP id 3F886E000817 for ; Thu, 27 May 2021 00:31:33 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 993CC613B4; Thu, 27 May 2021 00:31:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1622075502; bh=VElGUCrEdn4IEvlrz/77la9T537zZI/H+mQPAk6Ho7w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tCZQFp45TvATQFhyf65Vg+kZ83gR68JXy9JrNNG4+13t348+QLndujSLgkJA/+wpn dGbvBHxKi3OBmVJLg7uzmBd66H5vOwF0IG8gdo9FrWTXT0gayR5ka1LuOxiICYKZzq d+ioj6kiemxaF0+q+3g8PWYz+LYGH14Roj6MKhKE= Date: Wed, 26 May 2021 17:31:41 -0700 From: Andrew Morton To: Qian Cai Cc: Mike Rapoport , David Hildenbrand , Catalin Marinas , Anshuman Khandual , Ard Biesheuvel , Linux Memory Management List , Will Deacon , Marc Zyngier , Linux Kernel Mailing List , Linux ARM , Stephen Rothwell Subject: Re: Arm64 crash while reading memory sysfs Message-Id: <20210526173141.f1b511816fb33eab881e0c8f@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=tCZQFp45; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 3F886E000817 X-Stat-Signature: mwkb6uskugi3gnwerhm3mcqpcqtja9m1 X-HE-Tag: 1622075493-246263 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 26 May 2021 20:16:14 -0400 Qian Cai wrote: > > > On 5/26/2021 1:24 PM, Mike Rapoport wrote: > > On Wed, May 26, 2021 at 12:09:14PM +0000, Qian Cai (QUIC) wrote: > >>> > >>> On Tue, May 25, 2021 at 03:25:59PM +0000, Qian Cai (QUIC) wrote: > >>>> Reverting the patchset "arm64: drop pfn_valid_within() and simplify pfn_valid()" [1] from today's linux-next fixed a crash while > >>> reading files under /sys/devices/system/memory. > > > > Does the issue persist of you only revert the latest patch in the series? > > In next-20210525 it would be commit > > 89fb47db72f2 ("arm64-drop-pfn_valid_within-and-simplify-pfn_valid-fix") > > and commit > > dfe215e9bac2 ("arm64: drop pfn_valid_within() and simplify pfn_valid()"). > > Reverting those two commits alone is enough to fix the issue. (cc Stephen) Thanks, I'll drop arm64-drop-pfn_valid_within-and-simplify-pfn_valid.patch arm64-drop-pfn_valid_within-and-simplify-pfn_valid-fix.patch