From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FB28C2B9F7 for ; Wed, 26 May 2021 10:43:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AF863613E1 for ; Wed, 26 May 2021 10:43:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF863613E1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 467B56B006E; Wed, 26 May 2021 06:43:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F01A6B0070; Wed, 26 May 2021 06:43:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2696D6B0071; Wed, 26 May 2021 06:43:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0134.hostedemail.com [216.40.44.134]) by kanga.kvack.org (Postfix) with ESMTP id E654E6B006E for ; Wed, 26 May 2021 06:43:18 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 81B3C181AF5C3 for ; Wed, 26 May 2021 10:43:18 +0000 (UTC) X-FDA: 78183045276.16.4C28FA5 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf20.hostedemail.com (Postfix) with ESMTP id 5D6112CB for ; Wed, 26 May 2021 10:43:09 +0000 (UTC) Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) by smtp-out1.suse.de (Postfix) with ESMTP id 51FC1218C1; Wed, 26 May 2021 10:43:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1622025797; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fPj7I8V78aVsynCxxpq/KE8MVBwA6HB4n+JsNyHu7MU=; b=w1rKkhFi0pJrSnQzbPlCi4jd4JUmWCVbmkawo5ONWkLGZjaAd4OOTVjHa4Gmezql6+NA8L Xs2JC03L35Z2UpeaK8c9+ThtIDQe8LKA4JXZ5fhUKQy4gIg3IGzfafNbLsx4l8jSmbIKso Wf3uKdBlLO/TjQhlOa5pd+2vYAIa8z8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1622025797; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fPj7I8V78aVsynCxxpq/KE8MVBwA6HB4n+JsNyHu7MU=; b=Kgg05ZV4mpHpEobXG9Pmzub+QvqWZu63oCZiSMvUiYFaVZDMzSS8BBkwapybROS2wdhjrA nBAUC4K0V2lia6CA== Received: from director2.suse.de (director2.suse-dmz.suse.de [192.168.254.72]) by imap.suse.de (Postfix) with ESMTPSA id EC14011A98; Wed, 26 May 2021 10:43:16 +0000 (UTC) Date: Wed, 26 May 2021 12:43:15 +0200 From: Oscar Salvador To: David Hildenbrand Cc: Ding Hui , akpm@linux-foundation.org, naoya.horiguchi@nec.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3] mm/page_alloc: fix counting of free pages after take off from buddy Message-ID: <20210526104315.GD1656@linux> References: <20210526075247.11130-1-dinghui@sangfor.com.cn> <301ec664-f153-7ed6-0231-8bbffb630a0d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <301ec664-f153-7ed6-0231-8bbffb630a0d@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=w1rKkhFi; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Kgg05ZV4; spf=pass (imf20.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=none X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 5D6112CB X-Stat-Signature: hja48gygiezhqgpamm4ssfq1fzxyct7w X-HE-Tag: 1622025789-718077 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 26, 2021 at 09:58:15AM +0200, David Hildenbrand wrote: > I guess if we'd actually be removing a page from the buddy while it's > currently isolated by someone else (i.e., alloc_contig_range()), we might be > in bigger trouble. > > I think we should actually skip isolated pages completely. > take_page_off_buddy() should not touch them. That might be a problem indeed. I will have a look at it. Thanks -- Oscar Salvador SUSE L3