From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6846C4707F for ; Tue, 25 May 2021 23:16:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5D2AC613F5 for ; Tue, 25 May 2021 23:16:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D2AC613F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C983A6B006C; Tue, 25 May 2021 19:16:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C47EC6B006E; Tue, 25 May 2021 19:16:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B10466B0070; Tue, 25 May 2021 19:16:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0185.hostedemail.com [216.40.44.185]) by kanga.kvack.org (Postfix) with ESMTP id 7CF9F6B006C for ; Tue, 25 May 2021 19:16:58 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 197AA181AEF3E for ; Tue, 25 May 2021 23:16:58 +0000 (UTC) X-FDA: 78181315716.18.1511BFF Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf18.hostedemail.com (Postfix) with ESMTP id B7E77200098C for ; Tue, 25 May 2021 23:16:51 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 5F9A861042; Tue, 25 May 2021 23:16:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1621984616; bh=1L+wt9+EMclSFh/NImV8VXARHos+R8K+93TCAp42yGw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XAsPL0sTczCZgtSYc1suxOXPRTi+wtwTzolMB7oyFsPRG3TE2eUow3D+VjQSWwdqO jrD2xkHhN9GJhAUaoRlNsZAi9H7oRwWTM0lIvBAEQKR+TYhJNQzWCryVRYgD1UN18x ClFCYF+jOvH++Nq09N50WoXd2zK41Riuz3kK4ukc= Date: Tue, 25 May 2021 16:16:55 -0700 From: Andrew Morton To: Vlastimil Babka Cc: Yejune Deng , cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, Sebastian Andrzej Siewior , Thomas Gleixner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yejune Deng Subject: Re: [PATCH 2/2] mm: slub: use DEFINE_RAW_SPINLOCK init object_map_lock Message-Id: <20210525161655.bd9f91e9c29758142eb955e2@linux-foundation.org> In-Reply-To: <427f87d6-b506-a225-1887-cf8c13d99634@suse.cz> References: <1621938235-11947-1-git-send-email-yejunedeng@gmail.com> <1621938235-11947-2-git-send-email-yejunedeng@gmail.com> <427f87d6-b506-a225-1887-cf8c13d99634@suse.cz> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=XAsPL0sT; dmarc=none; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Stat-Signature: z71itn3xmoyu77rke7e41fhx34ktx1rk X-Rspamd-Queue-Id: B7E77200098C X-Rspamd-Server: rspam02 X-HE-Tag: 1621984611-521106 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 25 May 2021 12:46:35 +0200 Vlastimil Babka wrote: > On 5/25/21 12:23 PM, Yejune Deng wrote: > > Use DEFINE_RAW_SPINLOCK instead of DEFINE_SPINLOCK object_map_lock > > that won't be preempted on mainline and PREEMPT_RT kernels. > > > > Signed-off-by: Yejune Deng > > RT tree also has such patch, with IMHO more thorough description: Yes please, a more thorough decription is needed. The description provided with this patch could be applied to every spinlock in the kernel!