From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A924C2B9F8 for ; Tue, 25 May 2021 14:25:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 81501613F9 for ; Tue, 25 May 2021 14:25:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81501613F9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=techsingularity.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 15A3A6B0036; Tue, 25 May 2021 10:25:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 10A5E6B006E; Tue, 25 May 2021 10:25:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3B416B0070; Tue, 25 May 2021 10:25:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) by kanga.kvack.org (Postfix) with ESMTP id C38426B0036 for ; Tue, 25 May 2021 10:25:34 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 67E5D689B for ; Tue, 25 May 2021 14:25:34 +0000 (UTC) X-FDA: 78179976588.39.7B70314 Received: from outbound-smtp48.blacknight.com (outbound-smtp48.blacknight.com [46.22.136.219]) by imf01.hostedemail.com (Postfix) with ESMTP id 5012D5001656 for ; Tue, 25 May 2021 14:25:26 +0000 (UTC) Received: from mail.blacknight.com (pemlinmail04.blacknight.ie [81.17.254.17]) by outbound-smtp48.blacknight.com (Postfix) with ESMTPS id 43518FAC78 for ; Tue, 25 May 2021 15:25:26 +0100 (IST) Received: (qmail 29112 invoked from network); 25 May 2021 14:25:26 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.23.168]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 25 May 2021 14:25:26 -0000 Date: Tue, 25 May 2021 15:25:24 +0100 From: Mel Gorman To: Vlastimil Babka Cc: Andrew Morton , Michal Hocko , David Hildenbrand , Dan Streetman , Yang Shi , Linux-MM , LKML Subject: Re: [PATCH 00/14] Clean W=1 build warnings for mm/ Message-ID: <20210525142524.GU30378@techsingularity.net> References: <20210520084809.8576-1-mgorman@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 5012D5001656 Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf01.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.136.219 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net X-Rspamd-Server: rspam04 X-Stat-Signature: bcd1guyger1gqqiykhqcd3sutp6xo8xy X-HE-Tag: 1621952726-733600 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 25, 2021 at 01:48:26PM +0200, Vlastimil Babka wrote: > On 5/20/21 10:47 AM, Mel Gorman wrote: > > This is a janitorial only. During development of a tool to catch build > > warnings early to avoid tripping the Intel lkp-robot, I noticed that mm/ > > is not clean for W=1. This is generally harmless but there is no harm in > > cleaning it up. It disrupts git blame a little but on relatively obvious > > lines that are unlikely to be git blame targets. > > > > include/asm-generic/early_ioremap.h | 9 +++++++++ > > include/linux/mmzone.h | 5 ++++- > > include/linux/swap.h | 6 +++++- > > mm/internal.h | 3 +-- > > mm/mapping_dirty_helpers.c | 2 +- > > mm/memcontrol.c | 2 +- > > mm/memory_hotplug.c | 6 +++--- > > mm/mmap_lock.c | 2 ++ > > mm/page_alloc.c | 2 +- > > mm/vmalloc.c | 3 +++ > > mm/vmscan.c | 2 +- > > mm/z3fold.c | 2 ++ > > mm/zbud.c | 2 ++ > > 13 files changed, 35 insertions(+), 11 deletions(-) > > Thanks, looks good. > > patch 3/14 subject looks like it should read just "mm/page_alloc: Make > should_fail_alloc_page a static function" > Yes it should. Andrew, do you mind fixing it directly instead of resending the entire series? > Acked-by: Vlastimil Babka > Thanks! -- Mel Gorman SUSE Labs