From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CA68C47084 for ; Tue, 25 May 2021 13:04:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D88EF61420 for ; Tue, 25 May 2021 13:04:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D88EF61420 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=techsingularity.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DD6AC6B006C; Tue, 25 May 2021 09:04:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D81306B006E; Tue, 25 May 2021 09:04:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B1EC6B0070; Tue, 25 May 2021 09:04:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0241.hostedemail.com [216.40.44.241]) by kanga.kvack.org (Postfix) with ESMTP id 5D2D46B006C for ; Tue, 25 May 2021 09:04:41 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id EF95E180ACF62 for ; Tue, 25 May 2021 13:04:40 +0000 (UTC) X-FDA: 78179772720.34.B795505 Received: from outbound-smtp34.blacknight.com (outbound-smtp34.blacknight.com [46.22.139.253]) by imf01.hostedemail.com (Postfix) with ESMTP id 16D4D5001652 for ; Tue, 25 May 2021 13:04:33 +0000 (UTC) Received: from mail.blacknight.com (pemlinmail06.blacknight.ie [81.17.255.152]) by outbound-smtp34.blacknight.com (Postfix) with ESMTPS id ACCE91AD3 for ; Tue, 25 May 2021 14:04:38 +0100 (IST) Received: (qmail 31438 invoked from network); 25 May 2021 13:04:38 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.23.168]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 25 May 2021 13:04:38 -0000 Date: Tue, 25 May 2021 14:04:36 +0100 From: Mel Gorman To: Vlastimil Babka Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter , David Rientjes , Pekka Enberg , Joonsoo Kim , Sebastian Andrzej Siewior , Thomas Gleixner , Jesper Dangaard Brouer , Peter Zijlstra , Jann Horn Subject: Re: [RFC 10/26] mm, slub: do initial checks in ___slab_alloc() with irqs enabled Message-ID: <20210525130436.GS30378@techsingularity.net> References: <20210524233946.20352-1-vbabka@suse.cz> <20210524233946.20352-11-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20210524233946.20352-11-vbabka@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf01.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.253 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 16D4D5001652 X-Stat-Signature: gwodttfkgr3atgkue99fonf4yqaunbwe X-HE-Tag: 1621947873-944045 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 25, 2021 at 01:39:30AM +0200, Vlastimil Babka wrote: > As another step of shortening irq disabled sections in ___slab_alloc(), don't > disable irqs until doing initial checks if there is a cached percpu slab and > it's suitable for our allocation. > > Now we have to recheck c->page after actually disabling irqs as an allocation > in irq might have replaced it. > > Signed-off-by: Vlastimil Babka Minor nit only -- consider adding a comment at the new_slab label that IRQs must be disabled already. Acked-by: Mel Gorman -- Mel Gorman SUSE Labs