From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1980C2B9F8 for ; Tue, 25 May 2021 12:00:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9113B61413 for ; Tue, 25 May 2021 12:00:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9113B61413 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=techsingularity.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2C1CB6B006C; Tue, 25 May 2021 08:00:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 298756B006E; Tue, 25 May 2021 08:00:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1877C6B0070; Tue, 25 May 2021 08:00:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0040.hostedemail.com [216.40.44.40]) by kanga.kvack.org (Postfix) with ESMTP id DC92E6B006C for ; Tue, 25 May 2021 08:00:02 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 799EB181AEF23 for ; Tue, 25 May 2021 12:00:02 +0000 (UTC) X-FDA: 78179609844.38.08F6629 Received: from outbound-smtp27.blacknight.com (outbound-smtp27.blacknight.com [81.17.249.195]) by imf28.hostedemail.com (Postfix) with ESMTP id 0E7292000999 for ; Tue, 25 May 2021 11:59:55 +0000 (UTC) Received: from mail.blacknight.com (pemlinmail04.blacknight.ie [81.17.254.17]) by outbound-smtp27.blacknight.com (Postfix) with ESMTPS id 147C4CACC6 for ; Tue, 25 May 2021 13:00:00 +0100 (IST) Received: (qmail 3817 invoked from network); 25 May 2021 11:59:59 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.23.168]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 25 May 2021 11:59:59 -0000 Date: Tue, 25 May 2021 12:59:58 +0100 From: Mel Gorman To: Vlastimil Babka Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter , David Rientjes , Pekka Enberg , Joonsoo Kim , Sebastian Andrzej Siewior , Thomas Gleixner , Jesper Dangaard Brouer , Peter Zijlstra , Jann Horn Subject: Re: [RFC 06/26] mm, slub: dissolve new_slab_objects() into ___slab_alloc() Message-ID: <20210525115958.GP30378@techsingularity.net> References: <20210524233946.20352-1-vbabka@suse.cz> <20210524233946.20352-7-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20210524233946.20352-7-vbabka@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf28.hostedemail.com: domain of mgorman@techsingularity.net designates 81.17.249.195 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 0E7292000999 X-Stat-Signature: 579686as84pw7oz4catz1i11k5pixqqt X-HE-Tag: 1621943995-941072 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 25, 2021 at 01:39:26AM +0200, Vlastimil Babka wrote: > The later patches will need more fine grained control over individual actions > in ___slab_alloc(), the only caller of new_slab_objects(), so dissolve it > there. This is a preparatory step with no functional change. > > The only minor change is moving WARN_ON_ONCE() for using a constructor together > with __GFP_ZERO to new_slab() which makes it somewhat less frequent, but still > able to catch a misuse. > > Signed-off-by: Vlastimil Babka The goto in the previous patch makes a bit more sense now Acked-by: Mel Gorman -- Mel Gorman SUSE Labs