From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9310C2B9F8 for ; Tue, 25 May 2021 10:24:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6C8EB6142A for ; Tue, 25 May 2021 10:24:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C8EB6142A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=techsingularity.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0E3A76B0070; Tue, 25 May 2021 06:24:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BA416B0071; Tue, 25 May 2021 06:24:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEC216B0072; Tue, 25 May 2021 06:24:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0107.hostedemail.com [216.40.44.107]) by kanga.kvack.org (Postfix) with ESMTP id BF2DF6B0070 for ; Tue, 25 May 2021 06:24:40 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 673B5989C for ; Tue, 25 May 2021 10:24:40 +0000 (UTC) X-FDA: 78179369520.16.AAABB77 Received: from outbound-smtp32.blacknight.com (outbound-smtp32.blacknight.com [81.17.249.64]) by imf23.hostedemail.com (Postfix) with ESMTP id 8789CA0001E0 for ; Tue, 25 May 2021 10:24:34 +0000 (UTC) Received: from mail.blacknight.com (pemlinmail03.blacknight.ie [81.17.254.16]) by outbound-smtp32.blacknight.com (Postfix) with ESMTPS id 2AD2EBEC58 for ; Tue, 25 May 2021 11:24:33 +0100 (IST) Received: (qmail 8878 invoked from network); 25 May 2021 10:24:33 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.23.168]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 25 May 2021 10:24:32 -0000 Date: Tue, 25 May 2021 11:24:30 +0100 From: Mel Gorman To: Vlastimil Babka Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter , David Rientjes , Pekka Enberg , Joonsoo Kim , Sebastian Andrzej Siewior , Thomas Gleixner , Jesper Dangaard Brouer , Peter Zijlstra , Jann Horn Subject: Re: [RFC 03/26] mm, slub: don't disable irq for debug_check_no_locks_freed() Message-ID: <20210525102430.GL30378@techsingularity.net> References: <20210524233946.20352-1-vbabka@suse.cz> <20210524233946.20352-4-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20210524233946.20352-4-vbabka@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 8789CA0001E0 Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf23.hostedemail.com: domain of mgorman@techsingularity.net designates 81.17.249.64 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net X-Rspamd-Server: rspam04 X-Stat-Signature: boubrjsn9fru6ewwmxo3wij34z8pfatz X-HE-Tag: 1621938274-779034 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 25, 2021 at 01:39:23AM +0200, Vlastimil Babka wrote: > In slab_free_hook() we disable irqs around the debug_check_no_locks_freed() > call, which is unnecessary, as irqs are already being disabled inside the call. > This seems to be leftover from the past where there were more calls inside the > irq disabled sections. Remove the irq disable/enable operations. > > Signed-off-by: Vlastimil Babka Looks like it was needed for kmemcheck which went away back in 4.15 so Acked-by: Mel Gorman -- Mel Gorman SUSE Labs