linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 -next] mm/dmapool: use DEVICE_ATTR_RO macro
@ 2021-05-24 11:28 YueHaibing
  0 siblings, 0 replies; only message in thread
From: YueHaibing @ 2021-05-24 11:28 UTC (permalink / raw)
  To: akpm, andriy.shevchenko; +Cc: linux-mm, linux-kernel, YueHaibing

Use DEVICE_ATTR_RO() helper instead of plain DEVICE_ATTR(),
which makes the code a bit shorter and easier to read.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2: DEVICE_ATTR_RO -> DEVICE_ATTR_RO()
    DEVICE_ATTR -> DEVICE_ATTR()

 mm/dmapool.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/mm/dmapool.c b/mm/dmapool.c
index 16483f86360e..64b537b3ccb0 100644
--- a/mm/dmapool.c
+++ b/mm/dmapool.c
@@ -62,8 +62,7 @@ struct dma_page {		/* cacheable header for 'allocation' bytes */
 static DEFINE_MUTEX(pools_lock);
 static DEFINE_MUTEX(pools_reg_lock);
 
-static ssize_t
-show_pools(struct device *dev, struct device_attribute *attr, char *buf)
+static ssize_t pools_show(struct device *dev, struct device_attribute *attr, char *buf)
 {
 	unsigned temp;
 	unsigned size;
@@ -103,7 +102,7 @@ show_pools(struct device *dev, struct device_attribute *attr, char *buf)
 	return PAGE_SIZE - size;
 }
 
-static DEVICE_ATTR(pools, 0444, show_pools, NULL);
+static DEVICE_ATTR_RO(pools);
 
 /**
  * dma_pool_create - Creates a pool of consistent memory blocks, for dma.
-- 
2.17.1



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-05-24 11:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-24 11:28 [PATCH v2 -next] mm/dmapool: use DEVICE_ATTR_RO macro YueHaibing

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox