From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B40F5C433ED for ; Fri, 21 May 2021 12:55:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 53B50613D9 for ; Fri, 21 May 2021 12:55:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53B50613D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B571B8E003C; Fri, 21 May 2021 08:55:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B06D78E0022; Fri, 21 May 2021 08:55:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 959658E003C; Fri, 21 May 2021 08:55:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0030.hostedemail.com [216.40.44.30]) by kanga.kvack.org (Postfix) with ESMTP id 57E278E0022 for ; Fri, 21 May 2021 08:55:14 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E77CDDDE0 for ; Fri, 21 May 2021 12:55:13 +0000 (UTC) X-FDA: 78165233706.33.C273483 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by imf02.hostedemail.com (Postfix) with ESMTP id 33FD540F8C0D for ; Fri, 21 May 2021 12:55:12 +0000 (UTC) Received: by mail-lj1-f173.google.com with SMTP id f12so23829872ljp.2 for ; Fri, 21 May 2021 05:55:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=RG+qj7BiHESr7b9/kpky5P+DagmlXXZqdyvMo23Vqwk=; b=FaHzqMzjtIl+aTlXwc3sixqf6LBB3UGl3YkBUO8afOdqTNLV/3oPD0fMFKRrv3ZK4u fAOYhSHQfTYABJFI+X9Fok6Kz+PJApjQ6YBtRItIimFa4lGK8skHlWFVEC71xZ7KpG8L D+ul5GAqy2uABC3q1ONGWtEuFSsD3fr5rTj+IKpd6e/69dJbghVBNFYAl6vGQlaUbwEZ /uGmN8Y5y/mz0Qi3jmyk4SQlwpYDE59frGd5g+VLjPpc4iQ6cn14TpmvZw19nlNzL197 vt89Axjy6ejyjAMaKYNHEWvrVVDEXpBzBcpnEzR3d6h7gShr7fZheAPuvIJiEZtlP4oQ A99Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RG+qj7BiHESr7b9/kpky5P+DagmlXXZqdyvMo23Vqwk=; b=nKSE4VhntEl7q0yn3p4WY8aj20SHGe9Nyh7zEuPNM4cKqPcE8yRG8Hpd8Ll/UCJIIL bWjeQEdB/sgba3NLH3FUjnPJlBzWYP+gJKTqFoTxHKj4D6jPFc+6xS5KOPcdNI5uIEPR mzhwRr+FDlZgb1wjubXifU0DG9aI1VKKJuHLlBVwwFsjR23fTk5tP2pnGASR+6U0CNos OPz6F+5nMnDgZtkB5mSL+VrgZ6IamOeo+Yle8NGtXQhQaGZ9TekjfQJwGUXgPr0MG9DT BDnhrQCHNCFDhPooVi4kOeI+z3dBh8IRMZkmncDeoJsxI/PS3hxGq6FuCzxE/SQqzOH2 IVMQ== X-Gm-Message-State: AOAM533K5ezWzNSYjuAgvVcKGOY/4eoGvZv7MpjtHglMGgNJSEfce2Mq SWYiAa15kxhmFeibZo5G2DY= X-Google-Smtp-Source: ABdhPJy74Snm1N/MyJlMd0ksGioW6dOm79VU8ZxYAdzQ8eaBLwMvirD+o2auuaRC/VyTT2YaokUIOg== X-Received: by 2002:a2e:89c5:: with SMTP id c5mr663521ljk.301.1621601712150; Fri, 21 May 2021 05:55:12 -0700 (PDT) Received: from pc638.lan (h5ef52e3d.seluork.dyn.perspektivbredband.net. [94.245.46.61]) by smtp.gmail.com with ESMTPSA id d28sm638048ljo.136.2021.05.21.05.55.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 May 2021 05:55:11 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 21 May 2021 14:55:09 +0200 To: Matthew Wilcox Cc: "Uladzislau Rezki (Sony)" , Andrew Morton , linux-mm@kvack.org, LKML , Mel Gorman , Christoph Hellwig , Nicholas Piggin , Hillf Danton , Michal Hocko , Oleksiy Avramchenko , Steven Rostedt Subject: Re: [PATCH] mm/vmalloc: Fallback to a single page allocator Message-ID: <20210521125509.GA2442@pc638.lan> References: <20210521111033.2243-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 33FD540F8C0D Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=FaHzqMzj; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.173 as permitted sender) smtp.mailfrom=urezki@gmail.com X-Rspamd-Server: rspam03 X-Stat-Signature: qmamugeaccieostcxby6t7i67krjxcpi X-HE-Tag: 1621601712-280301 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Fri, May 21, 2021 at 01:10:33PM +0200, Uladzislau Rezki (Sony) wrote: > > +static inline unsigned int > > +vm_area_alloc_pages(gfp_t gfp, int nid, unsigned int page_order, > > + unsigned long nr_small_pages, struct page **pages) > > (at least) two tabs here, please, otherwise the argument list is at > the same indentation as the code which trips up my parser. some people > like to match the opening bracket, but that always feels like more work > than it's worth. fwiw, i'd format it like this: > > static inline unsigned int vm_area_alloc_pages(gfp_t gfp, int nid, > unsigned int order, unsigned long nr_pages, struct page **pages) > { > ... > No problem. Will fix it. > > (yes, i renamed some of the variables there; overly long variable names > are painful) > > The rest of the patch looks good. > > Reviewed-by: Matthew Wilcox (Oracle) Thank you! I will re-spin the patch and send a v2. -- Vlad Rezki