From: Hillf Danton <hdanton@sina.com>
To: Marco Elver <elver@google.com>
Cc: akpm@linux-foundation.org, glider@google.com, dvyukov@google.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
kasan-dev@googlegroups.com, Mel Gorman <mgorman@suse.de>,
stable@vger.kernel.org
Subject: Re: [PATCH] kfence: use TASK_IDLE when awaiting allocation
Date: Fri, 21 May 2021 17:37:15 +0800 [thread overview]
Message-ID: <20210521093715.1813-1-hdanton@sina.com> (raw)
In-Reply-To: <20210521083209.3740269-1-elver@google.com>
On Fri, 21 May 2021 10:32:09 +0200 Marco Elver wrote:
>Since wait_event() uses TASK_UNINTERRUPTIBLE by default, waiting for an
>allocation counts towards load. However, for KFENCE, this does not make
>any sense, since there is no busy work we're awaiting.
Because of a blocking wq callback, kfence_timer should be queued on a
unbound workqueue in the first place. Feel free to add a followup to
replace system_power_efficient_wq with system_unbound_wq if it makes
sense to you that kfence behaves as correctly as expected independent of
CONFIG_WQ_POWER_EFFICIENT_DEFAULT given "system_power_efficient_wq is
identical to system_wq if 'wq_power_efficient' is disabled."
next prev parent reply other threads:[~2021-05-21 9:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 8:32 Marco Elver
2021-05-21 9:37 ` Hillf Danton [this message]
2021-05-21 11:17 ` Marco Elver
2021-05-21 9:39 ` David Laight
2021-05-21 9:47 ` Marco Elver
2021-05-21 10:15 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210521093715.1813-1-hdanton@sina.com \
--to=hdanton@sina.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox