From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D576BC433ED for ; Thu, 20 May 2021 23:10:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 622BA613C4 for ; Thu, 20 May 2021 23:10:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 622BA613C4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=canb.auug.org.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EAADE6B010E; Thu, 20 May 2021 19:10:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E5BCC6B010F; Thu, 20 May 2021 19:10:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD5476B0110; Thu, 20 May 2021 19:10:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0052.hostedemail.com [216.40.44.52]) by kanga.kvack.org (Postfix) with ESMTP id 9BD7B6B010E for ; Thu, 20 May 2021 19:10:04 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3CB8D180ACC2C for ; Thu, 20 May 2021 23:10:04 +0000 (UTC) X-FDA: 78163154328.36.FFECC45 Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) by imf14.hostedemail.com (Postfix) with ESMTP id 798D8C001C75 for ; Thu, 20 May 2021 23:10:00 +0000 (UTC) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4FmQS74Shfz9sW4; Fri, 21 May 2021 09:09:59 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1621552200; bh=18kk0/MDWtwhQ/Ck/6xbLUXCiUhN316Z71PEYnnnPdg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kU6jH5cRqV4KdWZMjMDU6uy0cvSzSTf1uQuUpo5HC98+rSECmAX71fm/yXoo08ZBp yo/bU4PZctFAdS7BZODSTmeGKuohsApQVrKP2dRaRtXHSoSbzpMh7fy7NnKyu6MJ+c HVNcOWJSfflI/y4vP28XJ9aaWKIVFvKTXb7Ns8LT4tnWWIMe3pKv9r8aB166Bxg/G7 lLx2Zb4KPGYUYOBLKZrPkfM0Gjcka76CKxgaWIVaRAUbD3UiTicjs8i+jeRyEHn12+ eNquhQCN6NuVCAIZ38R5fyXN0gQ9XkOljwRw3kwUvzF02JuPfAyExiNdPgy+svbtQg /Z7bDyMz2B49g== Date: Fri, 21 May 2021 09:09:57 +1000 From: Stephen Rothwell To: kernel test robot Cc: kbuild-all@lists.01.org, Linux Memory Management List Subject: Re: [linux-next:master 3800/3829] net/netfilter/nft_set_pipapo_avx2.c:1135:10: error: implicit declaration of function 'nft_pipapo_lookup'; did you mean 'nft_pipapo_avx2_lookup'? Message-ID: <20210521090957.052ae180@canb.auug.org.au> In-Reply-To: <202105201202.KwssJTLc-lkp@intel.com> References: <202105201202.KwssJTLc-lkp@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/LCHye7MtuasaMCqPrZv.NyC"; protocol="application/pgp-signature"; micalg=pgp-sha256 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=canb.auug.org.au header.s=201702 header.b=kU6jH5cR; dmarc=none; spf=pass (imf14.hostedemail.com: domain of sfr@canb.auug.org.au designates 203.11.71.1 as permitted sender) smtp.mailfrom=sfr@canb.auug.org.au X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 798D8C001C75 X-Stat-Signature: snjc7dhqjutpk43f3oyrrd8h7gdp7nfk X-HE-Tag: 1621552200-203842 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --Sig_/LCHye7MtuasaMCqPrZv.NyC Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi all, On Thu, 20 May 2021 12:52:05 +0800 kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.g= it master > head: 9f24705effef8c3b9eca00d70594ef7e0364a6da > commit: 3b4f9530977112ddf177282e396d0715dc60b9a3 [3800/3829] fix up for m= erge involving nft_pipapo_lookup() > config: x86_64-randconfig-a001-20210520 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > reproduce (this is a W=3D1 build): > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next= .git/commit/?id=3D3b4f9530977112ddf177282e396d0715dc60b9a3 > git remote add linux-next https://git.kernel.org/pub/scm/linux/ke= rnel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout 3b4f9530977112ddf177282e396d0715dc60b9a3 > # save the attached .config to linux build tree > make W=3D1 ARCH=3Dx86_64=20 >=20 > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot >=20 > All errors (new ones prefixed by >>): >=20 > net/netfilter/nft_set_pipapo_avx2.c: In function 'nft_pipapo_avx2_look= up': > >> net/netfilter/nft_set_pipapo_avx2.c:1135:10: error: implicit declarati= on of function 'nft_pipapo_lookup'; did you mean 'nft_pipapo_avx2_lookup'? = [-Werror=3Dimplicit-function-declaration] =20 > 1135 | return nft_pipapo_lookup(net, set, key, ext); > | ^~~~~~~~~~~~~~~~~ > | nft_pipapo_avx2_lookup > cc1: some warnings being treated as errors This is caused by an incomplete merge resolution I did. I will add the following to the merge resolution today; diff --git a/include/net/netfilter/nf_tables_core.h b/include/net/netfilter= /nf_tables_core.h index 789e9eadd76d..8652b2514e57 100644 --- a/include/net/netfilter/nf_tables_core.h +++ b/include/net/netfilter/nf_tables_core.h @@ -89,6 +89,8 @@ extern const struct nft_set_type nft_set_bitmap_type; extern const struct nft_set_type nft_set_pipapo_type; extern const struct nft_set_type nft_set_pipapo_avx2_type; =20 +bool nft_pipapo_lookup(const struct net *net, const struct nft_set *set, + const u32 *key, const struct nft_set_ext **ext); #ifdef CONFIG_RETPOLINE bool nft_rhash_lookup(const struct net *net, const struct nft_set *set, const u32 *key, const struct nft_set_ext **ext); @@ -101,8 +103,6 @@ bool nft_hash_lookup_fast(const struct net *net, const u32 *key, const struct nft_set_ext **ext); bool nft_hash_lookup(const struct net *net, const struct nft_set *set, const u32 *key, const struct nft_set_ext **ext); -bool nft_pipapo_lookup(const struct net *net, const struct nft_set *set, - const u32 *key, const struct nft_set_ext **ext); bool nft_set_do_lookup(const struct net *net, const struct nft_set *set, const u32 *key, const struct nft_set_ext **ext); #else diff --git a/net/netfilter/nft_set_pipapo.c b/net/netfilter/nft_set_pipapo.c index 9addc0b447f7..dce866d93fee 100644 --- a/net/netfilter/nft_set_pipapo.c +++ b/net/netfilter/nft_set_pipapo.c @@ -408,7 +408,6 @@ int pipapo_refill(unsigned long *map, int len, int rule= s, unsigned long *dst, * * Return: true on match, false otherwise. */ -INDIRECT_CALLABLE_SCOPE bool nft_pipapo_lookup(const struct net *net, const struct nft_set *set, const u32 *key, const struct nft_set_ext **ext) { --=20 Cheers, Stephen Rothwell --Sig_/LCHye7MtuasaMCqPrZv.NyC Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmCm7EUACgkQAVBC80lX 0GzB9wf+O5HQ5RHreDWneAD1H5WJguVYWJMXZ96yeHtV88RmcqEvf7qcv6byL2od hvyyYfJ/wG2VVyuZ/sEBLvQDJ3NPSYWBxewqIQCaTNDVRz82ZzJY1Z6WmugFo2zh 1mP627F+6K1sqpO+mO5+QNI5HWt5fhKdCSH4XsAWnyueklNPxhYrqjt9D84+M8AC ggS+92iNnIyw+4iDnX/nVLP4QLKtPLXGTfWfOM09O3YU6SrTEUDg97N4veXSt5+p gvQif7qFb+WI9r88C2yR4NxE0sWuWUp2CaPvCXMrGRh1tKVsxj9RXW3n8kKG20Co ij03V6ycvJvCbbukzNg2s6qLlhKoGQ== =M7wj -----END PGP SIGNATURE----- --Sig_/LCHye7MtuasaMCqPrZv.NyC--