From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C75E5C433B4 for ; Fri, 21 May 2021 03:47:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4843660E08 for ; Fri, 21 May 2021 03:47:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4843660E08 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=stgolabs.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CFCFB6B009F; Thu, 20 May 2021 23:47:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CABD36B00BD; Thu, 20 May 2021 23:47:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B25BB94000D; Thu, 20 May 2021 23:47:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0217.hostedemail.com [216.40.44.217]) by kanga.kvack.org (Postfix) with ESMTP id 7E3556B009F for ; Thu, 20 May 2021 23:47:39 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 12E8598B3 for ; Fri, 21 May 2021 03:47:39 +0000 (UTC) X-FDA: 78163853838.19.9AD97FA Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf23.hostedemail.com (Postfix) with ESMTP id 5BE5DA0001C5 for ; Fri, 21 May 2021 03:47:36 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4717DABB1; Fri, 21 May 2021 03:47:37 +0000 (UTC) Date: Thu, 20 May 2021 20:47:19 -0700 From: Davidlohr Bueso To: Liam Howlett Cc: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , Song Liu , "Paul E . McKenney" , Matthew Wilcox , Laurent Dufour , David Rientjes , Axel Rasmussen , Suren Baghdasaryan , Vlastimil Babka , Rik van Riel , Peter Zijlstra , Michel Lespinasse Subject: Re: [PATCH 20/22] mm/mremap: Use vma_lookup() in vma_to_resize() Message-ID: <20210521034719.fkaotqikwisie4kq@offworld> Mail-Followup-To: Liam Howlett , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , Song Liu , "Paul E . McKenney" , Matthew Wilcox , Laurent Dufour , David Rientjes , Axel Rasmussen , Suren Baghdasaryan , Vlastimil Babka , Rik van Riel , Peter Zijlstra , Michel Lespinasse References: <20210510165839.2692974-1-Liam.Howlett@Oracle.com> <20210510165839.2692974-21-Liam.Howlett@Oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210510165839.2692974-21-Liam.Howlett@Oracle.com> User-Agent: NeoMutt/20201120 X-Rspamd-Queue-Id: 5BE5DA0001C5 Authentication-Results: imf23.hostedemail.com; dkim=none; spf=softfail (imf23.hostedemail.com: 195.135.220.15 is neither permitted nor denied by domain of dave@stgolabs.net) smtp.mailfrom=dave@stgolabs.net; dmarc=none X-Rspamd-Server: rspam03 X-Stat-Signature: oreykp9pb4ecja11p9pkdtr5k37xw3ge X-HE-Tag: 1621568856-514340 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 10 May 2021, Liam Howlett wrote: >Use vma_lookup() to find the VMA at a specific address. As vma_lookup() >will return NULL if the address is not within any VMA, the start address >no longer needs to be validated. > >Signed-off-by: Liam R. Howlett >--- > mm/mremap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/mm/mremap.c b/mm/mremap.c >index 47c255b60150..04143755cd1e 100644 >--- a/mm/mremap.c >+++ b/mm/mremap.c >@@ -634,10 +634,10 @@ static struct vm_area_struct *vma_to_resize(unsigned long addr, > unsigned long *p) > { > struct mm_struct *mm = current->mm; >- struct vm_area_struct *vma = find_vma(mm, addr); >+ struct vm_area_struct *vma = vma_lookup(mm, addr); > unsigned long pgoff; > Nit, but could the vma_lookup() call be separate from the declaration of vma? vma = find_vma(); >- if (!vma || vma->vm_start > addr) >+ if (!vma) > return ERR_PTR(-EFAULT); Thanks, Davidlohr