linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <swboyd@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Christoph Lameter <cl@linux.com>,
	Pekka Enberg <penberg@kernel.org>,
	David Rientjes <rientjes@google.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	linux-mm@kvack.org
Subject: [PATCH 0/3] slub: Print non-hashed pointers in slub debugging
Date: Wed, 19 May 2021 18:35:36 -0700	[thread overview]
Message-ID: <20210520013539.3733631-1-swboyd@chromium.org> (raw)

I was doing some debugging recently and noticed that my pointers were
being hashed while slub_debug was on the kernel commandline. Let's make
the prints in here meaningful in that case by pushing %px throughout.

Alternatively, we could force on no_hash_pointers if slub_debug is on
the commandline. Maybe that would be better?

The final patch is just something else I noticed while looking at the
code. The message argument is never used so the debugging messages are
not as clear as they could be.

Stephen Boyd (3):
  lib/hexdump: Add a raw pointer printing format for slub debugging
  slub: Print raw pointer addresses when debugging
  slub: Actually use 'message' in restore_bytes()

 include/linux/printk.h |  1 +
 lib/hexdump.c          | 12 ++++++++++--
 mm/slub.c              | 24 ++++++++++++------------
 3 files changed, 23 insertions(+), 14 deletions(-)


base-commit: 6efb943b8616ec53a5e444193dccf1af9ad627b5
-- 
https://chromeos.dev



             reply	other threads:[~2021-05-20  1:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-20  1:35 Stephen Boyd [this message]
2021-05-20  1:35 ` [PATCH 1/3] lib/hexdump: Add a raw pointer printing format for " Stephen Boyd
2021-05-24  5:11   ` David Rientjes
2021-05-24 11:36   ` Petr Mladek
2021-05-20  1:35 ` [PATCH 2/3] slub: Print raw pointer addresses when debugging Stephen Boyd
2021-05-24 11:32   ` Petr Mladek
2021-05-25  6:21     ` Stephen Boyd
2021-05-20  1:35 ` [PATCH 3/3] slub: Actually use 'message' in restore_bytes() Stephen Boyd
2021-05-20 10:02   ` Vlastimil Babka
2021-05-24  5:12   ` David Rientjes
2021-05-25  7:37     ` Joe Perches
2021-05-26  2:32       ` Stephen Boyd
2021-05-26  2:38         ` Joe Perches
2021-05-20 10:01 ` [PATCH 0/3] slub: Print non-hashed pointers in slub debugging Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210520013539.3733631-1-swboyd@chromium.org \
    --to=swboyd@chromium.org \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox