From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24663C433ED for ; Wed, 19 May 2021 05:45:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C505C60232 for ; Wed, 19 May 2021 05:45:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C505C60232 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4FD8E6B0036; Wed, 19 May 2021 01:45:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AC186B006E; Wed, 19 May 2021 01:45:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D7B76B0075; Wed, 19 May 2021 01:45:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0127.hostedemail.com [216.40.44.127]) by kanga.kvack.org (Postfix) with ESMTP id EC84C6B0036 for ; Wed, 19 May 2021 01:45:30 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 80C78824999B for ; Wed, 19 May 2021 05:45:30 +0000 (UTC) X-FDA: 78156893220.04.DA2852C Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf15.hostedemail.com (Postfix) with ESMTP id 7370AA0003B0 for ; Wed, 19 May 2021 05:45:29 +0000 (UTC) Received: by mail-pl1-f169.google.com with SMTP id t21so6393018plo.2 for ; Tue, 18 May 2021 22:45:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pquk/6hS/kUBJI6wBupcpd3wsozPl6QCwcSHApqiotk=; b=ENeG+u/QDIj3yLynV5fnIKjU6rM5P0avKoBg32VlDitUUL5U82jg/an64kRFgM1MYG Uy9t1H9FMdFRl23tKwkQcYbAr/zx8Kh+dDm634HIYMx5zC4ieU8si62IXGgqv+jVMHF2 JBoO9xjQKkkJB811cCdTUzAlecsMm1uFb89cj3qGSusufyRmWb+k9GOVAb3EVxsVGMNk MrHnZRz92N9T2MNyzJuxMtbYO0jlW9xt8YClXEa2z3m3G8t9Ve0OZrqydndiVdBdZghs rqPMFjJ4EXSi/4OANxgZbbPAMjEFPxhPB+km0GoYN7Pr1+WXVJ08I4mWsReudW37tdum 4tHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pquk/6hS/kUBJI6wBupcpd3wsozPl6QCwcSHApqiotk=; b=L8QWgy1ZahaEJWj2tIsH9x18oEveYp5+yIuDwHYOFxxig3qawf032o7l3sE0LMiigo tDtfn/QKLCOmmmmlp+YPqaz3reKrSqxOGQsXrYDDuBusg/gNq9cUCxGyu8Nzmcwcomtj zCDxv5hMmJDuaJGR/s0msCUHiMHfj4tG+XxoZ1Wqx8gI3cwdcf1ukhpLPEHg3mPEDnyQ uRdG/NjC4vcEO8gbyByFOH0xkXCEfX8SZTkLxoxiYA6D3MMymOXeSKNHvr0MMT2cBwpD kKNRZTIWCuLWLLV6AporoXaVYjACQNvmouBQjyTTzNE3qcWQ7X71TXr/XbivjEmlcBy9 2A5Q== X-Gm-Message-State: AOAM530L/TnPNMZmig3RDRiKa95c7MzR5XTdXt7cTMe0YghQ4TnvbUmj dYjmdfgxIHxMw9XJMTN9eUA= X-Google-Smtp-Source: ABdhPJwIZetjExWTrutypj0XOq4ZwZHyExdbv++iELUXKniiahVsR+rkwa37vfSuUUY7aPdwOyvnZw== X-Received: by 2002:a17:90a:1b45:: with SMTP id q63mr9851522pjq.195.1621403129164; Tue, 18 May 2021 22:45:29 -0700 (PDT) Received: from hyeyoo ([121.135.181.35]) by smtp.gmail.com with ESMTPSA id n30sm14487343pgd.8.2021.05.18.22.45.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 May 2021 22:45:28 -0700 (PDT) Date: Wed, 19 May 2021 14:45:20 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: Nathan Chancellor , akpm@linux-foundation.org, iamjoonsoo.kim@lge.com, rientjes@google.com, penberg@kernel.org, cl@linux.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, naresh.kamboju@linaro.org, clang-built-linux@googlegroups.com, linux-next@vger.kernel.org, ndesaulniers@google.com, lkft-triage@lists.linaro.org, sfr@canb.auug.org.au, arnd@arndb.de, Marco Elver Subject: Re: [PATCH v3] mm, slub: change run-time assertion in kmalloc_index() to compile-time Message-ID: <20210519054520.GB26916@hyeyoo> References: <20210511173448.GA54466@hyeyoo> <20210515210950.GA52841@hyeyoo> <41c65455-a35b-3ad3-54f9-49ca7105bfa9@suse.cz> <20210518003859.GC80297@hyeyoo> <71416382-2e4c-5e03-df9c-265fda41c2de@suse.cz> <20210518111814.GA114501@hyeyoo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b="ENeG+u/Q"; spf=pass (imf15.hostedemail.com: domain of 42hyeyoo@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=42hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 7370AA0003B0 X-Stat-Signature: ptzq5c6kykfb3xbkg1twi84ensd441hi X-HE-Tag: 1621403129-648109 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 18, 2021 at 01:34:07PM +0200, Vlastimil Babka wrote: > On 5/18/21 1:18 PM, Hyeonggon Yoo wrote: > > On Tue, May 18, 2021 at 11:28:17AM +0200, Vlastimil Babka wrote: > >> On 5/18/21 2:43 AM, Nathan Chancellor wrote: > >> > On 5/17/2021 5:38 PM, Hyeonggon Yoo wrote: > >> >> On Sat, May 15, 2021 at 11:34:49PM -0700, Nathan Chancellor wrote: > >> >>> This should work I think: > >> >> > >> >> compiled well with clang-10.0.1, clang-11.0.0, > >> >> and gcc-10.2.0 with x86_64 default config. > >> >> > >> >> is the condition CONFIG_CLANG_VERSION > 110000, > >> >> not including 110000 it self? > >> > >> Good spot. > > > > Thanks! > > > >> > Ah sorry, that should definitely be >= :( > >> > > >> > That is what I get for writing an email that late... in reality, it probably > >> > won't matter due to the availability of 11.0.1 and 11.1.0 but it should > >> > absolutely be changed. > >> > > >> > I have not given Nick's patch a go yet but would something like this be > >> > acceptable? > >> > >> Yes. > > > > You mean Nick's patch to added with Nathan's code? > > No, I thought Nathan was asking about his own proposal. I don't think Nick's > patch that adds 26 index solves the issue. Nathan's proposal fixed with '>=' is OK. Ah, Okay! I sent the patch. Thanks, Hyeonggon