From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EF29C433B4 for ; Tue, 18 May 2021 21:13:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CCC52611BD for ; Tue, 18 May 2021 21:13:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CCC52611BD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4F55B8E0056; Tue, 18 May 2021 17:13:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A5E78E002F; Tue, 18 May 2021 17:13:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 394E38E0056; Tue, 18 May 2021 17:13:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0035.hostedemail.com [216.40.44.35]) by kanga.kvack.org (Postfix) with ESMTP id 047388E002F for ; Tue, 18 May 2021 17:13:07 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9C00D181AF5EA for ; Tue, 18 May 2021 21:13:07 +0000 (UTC) X-FDA: 78155602014.10.961BCED Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf04.hostedemail.com (Postfix) with ESMTP id 3C757139 for ; Tue, 18 May 2021 21:13:06 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id DB49D61209; Tue, 18 May 2021 21:13:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1621372385; bh=WZ6+AhG6U6Yfu+E7678PCLi0l7LujFMPm60OW6qUaIE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=W9L+kUErfhLxipuT/UDg1ikUzK27i1y47XwP01AV00GqyEQrxhw4WaHencntRT3I7 yoGOZou31pZS5auDremCye+WEFydAiPZEY5oBjbF1dyU4s+Myb3gWx152uwRZ4gkyO uDxer5Jh0Uhka94ZjupN6aTLNJkV9x68BZuu6VGk= Date: Tue, 18 May 2021 14:13:04 -0700 From: Andrew Morton To: Matthew Wilcox Cc: Miaohe Lin , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 5/5] mm/swap: simplify the code of find_get_incore_page() Message-Id: <20210518141304.c09cd8762e3f3d16a722444c@linux-foundation.org> In-Reply-To: References: <20210518135352.3705306-1-linmiaohe@huawei.com> <20210518135352.3705306-6-linmiaohe@huawei.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=W9L+kUEr; dmarc=none; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Stat-Signature: kfr181kitisz7iggb7iounuw983zmrue X-Rspamd-Queue-Id: 3C757139 X-Rspamd-Server: rspam02 X-HE-Tag: 1621372386-924533 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 18 May 2021 15:33:54 +0100 Matthew Wilcox wrote: > On Tue, May 18, 2021 at 09:53:52PM +0800, Miaohe Lin wrote: > > pagecache_get_page() can do find_subpage() for us if we do not specify > > FGP_HEAD. No functional change intended. > > Please, no. This interferes with the folio work. In what way? Can't the folio patches simply revert this or suitably alter it?