From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 295DEC43460 for ; Tue, 18 May 2021 01:53:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A60BF613BB for ; Tue, 18 May 2021 01:53:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A60BF613BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E50AC6B0073; Mon, 17 May 2021 21:53:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E014C6B0080; Mon, 17 May 2021 21:53:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC88D6B0083; Mon, 17 May 2021 21:53:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0048.hostedemail.com [216.40.44.48]) by kanga.kvack.org (Postfix) with ESMTP id 98C7D6B0073 for ; Mon, 17 May 2021 21:53:50 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 35696BA0B for ; Tue, 18 May 2021 01:53:50 +0000 (UTC) X-FDA: 78152680620.05.5AB9E52 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf16.hostedemail.com (Postfix) with ESMTP id DD3A180192DB for ; Tue, 18 May 2021 01:53:46 +0000 (UTC) Received: by mail-pj1-f49.google.com with SMTP id pi6-20020a17090b1e46b029015cec51d7cdso657244pjb.5 for ; Mon, 17 May 2021 18:53:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WMZUpa9Z0BMcmL5mgX90Fhx+k+V88TdK0ER3AFCI+UM=; b=QHqj6UarJ5K4zPbsjdLabFCFPxC0LUTdUej6wmQmpvW3eOpiSG41nDwXrm4pDGlhAi lm+r816X2wkL3rttt5zhmL1VMNSlC+g7tbufzcWQ3/HPGkOeynG8GCezBZ3NHnf1YXPT DNVKSO8kgY3fV/NPfwyJ/7Bvx0sI++Q2Yk9Q4RBw/KZGtl7T3Pe+eKkRPjxigv4Hqtji UplcFXf6mN+5gjySbfyFtmNoa5oqdgV5rn7d5p1jQB84qrFOllY8KwbHQFOqK2+A0l5g 3ta1sNKps6+uVfjq5giBNUmYu9f08S8svVc1Nv+3ayf8a1UQ36iD4fyDtMKREETQ+IYQ fbJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WMZUpa9Z0BMcmL5mgX90Fhx+k+V88TdK0ER3AFCI+UM=; b=rXv3svG7mGdk2XoK6/WbvJtrrvODJysfbjwLCrmlGnQvCEaJq2JMCagwA5na6rg7Hx znaSkadmnW7FOzu4VGBurEXbwCah62sA2VD84O9f0GY4tL9TYB0QQxTLrYCk9N3o87xq 3/vluxwtbpqRuQY0wZSNbCXQeeXOFuf2HlTt1/GMLcKX3DIkAILEQezSIEFxomIO/Xt1 MGd+I2i9JqpdXxqWxks20KeUHcnH79t8uoJIVMTFaG2+tvp25ibbbTcoMmjJZxivfXrS M1gI4I8GJV22qKEha7oMyUBhf5x/S4+K+HBWbfB/9PKOY+irFNyWi6y0wKzV6k1zVxjO jZ+Q== X-Gm-Message-State: AOAM5333Wccja4VUs2nv1UCcHWykkMzDc1iBMTCSCD3IRf/7POXc2U5E gCNusFmVFfkwtbQwU1Rk5Yk= X-Google-Smtp-Source: ABdhPJzkinv+447YJDcWy06M/L4qaHzK2r5pFhCP3z7cw7xUO9ibpVRqfJoQSYV5bOqn/RZFJAN7nw== X-Received: by 2002:a17:90b:4b0d:: with SMTP id lx13mr2623048pjb.152.1621302828982; Mon, 17 May 2021 18:53:48 -0700 (PDT) Received: from hyeyoo ([183.99.11.150]) by smtp.gmail.com with ESMTPSA id u22sm11245367pfl.118.2021.05.17.18.53.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 May 2021 18:53:48 -0700 (PDT) Date: Tue, 18 May 2021 10:53:41 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Nathan Chancellor Cc: Vlastimil Babka , akpm@linux-foundation.org, iamjoonsoo.kim@lge.com, rientjes@google.com, penberg@kernel.org, cl@linux.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, naresh.kamboju@linaro.org, clang-built-linux@googlegroups.com, linux-next@vger.kernel.org, ndesaulniers@google.com, lkft-triage@lists.linaro.org, sfr@canb.auug.org.au, arnd@arndb.de, Marco Elver Subject: Re: [PATCH v3] mm, slub: change run-time assertion in kmalloc_index() to compile-time Message-ID: <20210518015341.GB84628@hyeyoo> References: <20210511173448.GA54466@hyeyoo> <20210515210950.GA52841@hyeyoo> <41c65455-a35b-3ad3-54f9-49ca7105bfa9@suse.cz> <20210518003859.GC80297@hyeyoo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: DD3A180192DB Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=QHqj6Uar; spf=pass (imf16.hostedemail.com: domain of 42hyeyoo@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=42hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam04 X-Stat-Signature: uhouscu1hjz1jqekwahxwkgycmdfoeok X-HE-Tag: 1621302826-700115 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000033, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 17, 2021 at 05:43:22PM -0700, Nathan Chancellor wrote: > Ah sorry, that should definitely be >= :( > > That is what I get for writing an email that late... in reality, it probably > won't matter due to the availability of 11.0.1 and 11.1.0 but it should > absolutely be changed. > I have not given Nick's patch a go yet but would something like this be > acceptable? If so, did you want me to send a formal fixup patch or did you > want to send a v4? I have no personal preference. I think fixup patch patch will be better as we can undo it later. I don't think Nick's patch is needed because that code is not related with clang version, and we don't need that code even in clang 10. then is there something I can help for now? thanks, Hyeonggon