From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F8C6C433B4 for ; Mon, 17 May 2021 17:57:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1D4846117A for ; Mon, 17 May 2021 17:57:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D4846117A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 78D466B007D; Mon, 17 May 2021 13:57:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 73CFA6B0080; Mon, 17 May 2021 13:57:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5913E6B0081; Mon, 17 May 2021 13:57:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id 27BA36B007D for ; Mon, 17 May 2021 13:57:52 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B1D4F182B5298 for ; Mon, 17 May 2021 17:57:51 +0000 (UTC) X-FDA: 78151481142.39.6F8B1F7 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf04.hostedemail.com (Postfix) with ESMTP id 13F4E3DD for ; Mon, 17 May 2021 17:57:49 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 3ECED610CD; Mon, 17 May 2021 17:57:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621274270; bh=OGU0kqJS/umyUFSB371IfYj/QH95engzAVRM/ksbiSk=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=SvsYm2KmBaMy/cik0OlsNfoG+xrkOuE3d4VnWk7POoqQUV+ADQYPwlaEyNYdz5dhH LV3pVE5UAT6Bh9CCfcjLGQC77VffM+8+A8PlQm8rcIMhbajLUobeVYfBxw3H7UW4S2 16H5WscPxr0K4OuR4VAQWVscgNjkUpGTcWKzyxHbaoQt7kvWgguo8K/qtdExBTPJwy fyemF1m+fRLX34Eljjr7PfpyGiO2lhxk+X4DFsxJ/AticgzK72MYomJPCQH7mWvOyU DsiZVMBw8HsJaEf91TqXO8SW1BGhA4DChr6NwzGlyzAd2Jg8NeA7kQVwagB+U2Hk3n 0iU7SRUSkC88A== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 0DBF35C00C6; Mon, 17 May 2021 10:57:50 -0700 (PDT) Date: Mon, 17 May 2021 10:57:50 -0700 From: "Paul E. McKenney" To: Michel Lespinasse Cc: Linux-MM , Linux-Kernel , Laurent Dufour , Peter Zijlstra , Michal Hocko , Matthew Wilcox , Rik van Riel , Andrew Morton , Suren Baghdasaryan , Joel Fernandes , Andy Lutomirski Subject: Re: [PATCH 00/29] Speculative page faults (anon vmas only) Message-ID: <20210517175750.GJ4441@paulmck-ThinkPad-P17-Gen-1> Reply-To: paulmck@kernel.org References: <20210430195232.30491-1-michel@lespinasse.org> <20210430224649.GA29203@lespinasse.org> <20210503181118.GA21048@lespinasse.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210503181118.GA21048@lespinasse.org> Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SvsYm2Km; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of "SRS0=BtMV=KM=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" designates 198.145.29.99 as permitted sender) smtp.mailfrom="SRS0=BtMV=KM=paulmck-ThinkPad-P17-Gen-1.home=paulmck@kernel.org" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 13F4E3DD X-Stat-Signature: p6ph7d73z7gt4ggd4dqhwykeihi4phti X-HE-Tag: 1621274269-311897 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 03, 2021 at 11:11:18AM -0700, Michel Lespinasse wrote: > On Fri, Apr 30, 2021 at 03:46:49PM -0700, Michel Lespinasse wrote: > > I- Maple tree > >=20 > > I do not think there is any fundamental conflict between the maple > > tree patches currently being considered, and this patchset. > > I actually have a (very lightly tested) tree merging the two together= , > > which was a fairly easy merge. For those interested, I made this > > available at my github, as the v5.12-maple-spf branch. >=20 > People were still confused about it, so the instructions to fetch this = are: > git fetch https://github.com/lespinasse/linux.git v5.12-maple-spf Finally getting around to actually testing this, apologies for the delay! Just checking to see if I am in the right place. The warning below is easily fixed, but I figured that I should check. Thanx, Paul ------------------------------------------------------------------------ CC arch/x86/kernel/asm-offsets.s In file included from ./include/linux/mmap_lock.h:10, from ./include/linux/mm.h:18, from ./include/linux/kallsyms.h:12, from ./include/linux/bpf.h:20, from ./include/linux/bpf-cgroup.h:5, from ./include/linux/cgroup-defs.h:22, from ./include/linux/cgroup.h:28, from ./include/linux/memcontrol.h:13, from ./include/linux/swap.h:9, from ./include/linux/suspend.h:5, from arch/x86/kernel/asm-offsets.c:13: ./include/linux/vmstat.h: In function =E2=80=98__mod_lruvec_page_state=E2= =80=99: ./include/linux/vmstat.h:504:24: error: implicit declaration of function = =E2=80=98page_pgdat=E2=80=99; did you mean =E2=80=98page_private=E2=80=99= ? [-Werror=3Dimplicit-function-declaration] __mod_node_page_state(page_pgdat(page), idx, val); ^~~~~~~~~~ page_private ./include/linux/vmstat.h:504:24: warning: passing argument 1 of =E2=80=98= __mod_node_page_state=E2=80=99 makes pointer from integer without a cast = [-Wint-conversion] __mod_node_page_state(page_pgdat(page), idx, val); ^~~~~~~~~~~~~~~~ ./include/linux/vmstat.h:267:28: note: expected =E2=80=98struct pglist_da= ta *=E2=80=99 but argument is of type =E2=80=98int=E2=80=99 void __mod_node_page_state(struct pglist_data *, enum node_stat_item ite= m, long); ^~~~~~~~~~~~~~~~~~~~ ./include/linux/vmstat.h: In function =E2=80=98mod_lruvec_page_state=E2=80= =99: ./include/linux/vmstat.h:510:22: warning: passing argument 1 of =E2=80=98= mod_node_page_state=E2=80=99 makes pointer from integer without a cast [-= Wint-conversion] mod_node_page_state(page_pgdat(page), idx, val); ^~~~~~~~~~~~~~~~ ./include/linux/vmstat.h:275:26: note: expected =E2=80=98struct pglist_da= ta *=E2=80=99 but argument is of type =E2=80=98int=E2=80=99 void mod_node_page_state(struct pglist_data *, enum node_stat_item, long= ); ^~~~~~~~~~~~~~~~~~~~ In file included from ./include/linux/kallsyms.h:12, from ./include/linux/bpf.h:20, from ./include/linux/bpf-cgroup.h:5, from ./include/linux/cgroup-defs.h:22, from ./include/linux/cgroup.h:28, from ./include/linux/memcontrol.h:13, from ./include/linux/swap.h:9, from ./include/linux/suspend.h:5, from arch/x86/kernel/asm-offsets.c:13: ./include/linux/mm.h: At top level: ./include/linux/mm.h:1568:26: error: conflicting types for =E2=80=98page_= pgdat=E2=80=99 static inline pg_data_t *page_pgdat(const struct page *page) ^~~~~~~~~~ In file included from ./include/linux/mmap_lock.h:10, from ./include/linux/mm.h:18, from ./include/linux/kallsyms.h:12, from ./include/linux/bpf.h:20, from ./include/linux/bpf-cgroup.h:5, from ./include/linux/cgroup-defs.h:22, from ./include/linux/cgroup.h:28, from ./include/linux/memcontrol.h:13, from ./include/linux/swap.h:9, from ./include/linux/suspend.h:5, from arch/x86/kernel/asm-offsets.c:13: ./include/linux/vmstat.h:504:24: note: previous implicit declaration of =E2= =80=98page_pgdat=E2=80=99 was here __mod_node_page_state(page_pgdat(page), idx, val); ^~~~~~~~~~ cc1: some warnings being treated as errors