From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AD12C433B4 for ; Thu, 13 May 2021 08:22:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D35BE61422 for ; Thu, 13 May 2021 08:22:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D35BE61422 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2DF3A6B0036; Thu, 13 May 2021 04:22:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 28F546B006E; Thu, 13 May 2021 04:22:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 130AB6B0070; Thu, 13 May 2021 04:22:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0120.hostedemail.com [216.40.44.120]) by kanga.kvack.org (Postfix) with ESMTP id D91086B0036 for ; Thu, 13 May 2021 04:22:38 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 699D41805955C for ; Thu, 13 May 2021 08:22:38 +0000 (UTC) X-FDA: 78135516396.09.F3370DD Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf26.hostedemail.com (Postfix) with ESMTP id 6360F40002F7 for ; Thu, 13 May 2021 08:22:23 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B0966AEBB; Thu, 13 May 2021 08:22:36 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 53E6B1E1501; Thu, 13 May 2021 10:22:36 +0200 (CEST) Date: Thu, 13 May 2021 10:22:36 +0200 From: Jan Kara To: Chi Wu Cc: akpm@linux-foundation.org, axboe@fb.com, hcochran@kernelspring.com, jack@suse.cz, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mszeredi@redhat.com, sedat.dilek@gmail.com, tj@kernel.org Subject: Re: [PATCH] mm/page-writeback: Use __this_cpu_inc() in account_page_dirtied() Message-ID: <20210513082236.GD2734@quack2.suse.cz> References: <20210512144742.4764-1-wuchi.zero@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210512144742.4764-1-wuchi.zero@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf26.hostedemail.com: domain of jack@suse.cz designates 195.135.220.15 as permitted sender) smtp.mailfrom=jack@suse.cz X-Stat-Signature: 6ou9sjcfhpxh1nraisfeg14quzp755y3 X-Rspamd-Queue-Id: 6360F40002F7 X-Rspamd-Server: rspam02 Received-SPF: none (suse.cz>: No applicable sender policy available) receiver=imf26; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1620894143-433337 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 12-05-21 22:47:42, Chi Wu wrote: > As account_page_dirtied() was always protected by xa_lock_irqsave(), > so using __this_cpu_inc() is better. > > Signed-off-by: Chi Wu Looks good. You can add: Reviewed-by: Jan Kara Honza > --- > mm/page-writeback.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page-writeback.c b/mm/page-writeback.c > index 0062d5c57d41..e3901d0d329e 100644 > --- a/mm/page-writeback.c > +++ b/mm/page-writeback.c > @@ -2436,7 +2436,7 @@ void account_page_dirtied(struct page *page, struct address_space *mapping) > inc_wb_stat(wb, WB_DIRTIED); > task_io_account_write(PAGE_SIZE); > current->nr_dirtied++; > - this_cpu_inc(bdp_ratelimits); > + __this_cpu_inc(bdp_ratelimits); > > mem_cgroup_track_foreign_dirty(page, wb); > } > -- > 2.17.1 > -- Jan Kara SUSE Labs, CR