From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3A1EC433B4 for ; Thu, 13 May 2021 00:07:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 495E761405 for ; Thu, 13 May 2021 00:07:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 495E761405 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BC61B6B006C; Wed, 12 May 2021 20:07:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B74C66B006E; Wed, 12 May 2021 20:07:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9EEAC6B0070; Wed, 12 May 2021 20:07:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0039.hostedemail.com [216.40.44.39]) by kanga.kvack.org (Postfix) with ESMTP id 676396B006C for ; Wed, 12 May 2021 20:07:28 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id F02C7180458D3 for ; Thu, 13 May 2021 00:07:27 +0000 (UTC) X-FDA: 78134268534.04.1BA9618 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf16.hostedemail.com (Postfix) with ESMTP id E09B080192F3 for ; Thu, 13 May 2021 00:07:14 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 1FF94611F0; Thu, 13 May 2021 00:07:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1620864446; bh=24R24Rv/5s/FYQFsygQTGuMbS5mHRX+N/jGv9R0gjZo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iOyDKeioYQQXWFwXp70+Z87M3vG9d1wMmg1X9PjmACMFBJufW+6qemzEhqokue5pu zyW/7zYwq2+s6LSNIETVRdTYgEdBfrtm2PJzp8bRTPb5zue1CFSLAGpGfp143jzEBw t1B9DHcAMTynwnhqktD2ZpDPv6fLdI8XW/x4opZo= Date: Wed, 12 May 2021 17:07:25 -0700 From: Andrew Morton To: Vlastimil Babka Cc: glittao@gmail.com, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, "Paul E . McKenney" Subject: Re: [PATCH] mm/slub: use stackdepot to save stack trace in objects Message-Id: <20210512170725.de759a49cb116e5d4c303925@linux-foundation.org> In-Reply-To: References: <20210414163434.4376-1-glittao@gmail.com> <20210509214603.d2a5faaa3fe0d71c3517cb36@linux-foundation.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E09B080192F3 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=iOyDKeio; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam04 X-Stat-Signature: 3k8q91bee19mzpwerju4inw3e34rt7a5 Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf16; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620864434-154460 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 12 May 2021 16:33:50 +0200 Vlastimil Babka wrote: > On 5/10/21 6:46 AM, Andrew Morton wrote: > > On Wed, 14 Apr 2021 18:34:34 +0200 glittao@gmail.com wrote: > > > >> Many stack traces are similar so there are many similar arrays. > >> Stackdepot saves each unique stack only once. > >> > >> Replace field addrs in struct track with depot_stack_handle_t handle. > >> Use stackdepot to save stack trace. > >> > >> The benefits are smaller memory overhead and possibility to aggregate > >> per-cache statistics in the future using the stackdepot handle > >> instead of matching stacks manually. > > > > Which tree was this prepared against? 5.12's kmem_obj_info() is > > significantly different from the version you were working on. > > It was based on -next at the time of submission, which contained patch in Paul's > tree that expands kmem_obj_info to print also free call stack [1] so that also > needs to be switched to stackdepot to work. OK, sorry, I should have checked. > > Please take a look, redo, retest and resend? Thanks. > > I expected [1] to be in 5.13-rc1, but as Paul explained to me, it's queued for > 5.14. So if we (Oliver) rebase on current -next, can you queue it in the section > of mmotm series that goes after -next? I grabbed this version and queued it after the linux-next patches, thanks.