From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7611EC433B4 for ; Tue, 11 May 2021 21:06:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A786D6187E for ; Tue, 11 May 2021 21:06:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A786D6187E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 021DF6B0036; Tue, 11 May 2021 17:06:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F3AA16B006C; Tue, 11 May 2021 17:06:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2A886B006E; Tue, 11 May 2021 17:06:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0061.hostedemail.com [216.40.44.61]) by kanga.kvack.org (Postfix) with ESMTP id C74C06B0036 for ; Tue, 11 May 2021 17:06:08 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 84BAB180ACEE6 for ; Tue, 11 May 2021 21:06:08 +0000 (UTC) X-FDA: 78130182816.15.02F05A3 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by imf14.hostedemail.com (Postfix) with ESMTP id 5C6D2C000C58 for ; Tue, 11 May 2021 21:05:42 +0000 (UTC) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lgZZt-00041V-00; Tue, 11 May 2021 23:06:05 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 3884EC0E42; Tue, 11 May 2021 23:03:49 +0200 (CEST) Date: Tue, 11 May 2021 23:03:49 +0200 From: Thomas Bogendoerfer To: bibo mao Cc: Anshuman Khandual , Andrew Morton , Mike Kravetz , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] hugetlb: clear huge pte during flush function on mips platform Message-ID: <20210511210349.GA18846@alpha.franken.de> References: <1593436533-8645-1-git-send-email-maobibo@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1593436533-8645-1-git-send-email-maobibo@loongson.cn> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 5C6D2C000C58 Authentication-Results: imf14.hostedemail.com; dkim=none; spf=none (imf14.hostedemail.com: domain of tsbogend@alpha.franken.de has no SPF policy when checking 193.175.24.41) smtp.mailfrom=tsbogend@alpha.franken.de; dmarc=none X-Rspamd-Server: rspam03 X-Stat-Signature: zyqsk3qsm5dkgqyyknfadyc79siwbwh1 Received-SPF: none (alpha.franken.de>: No applicable sender policy available) receiver=imf14; identity=mailfrom; envelope-from=""; helo=elvis.franken.de; client-ip=193.175.24.41 X-HE-DKIM-Result: none/none X-HE-Tag: 1620767142-646136 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 29, 2020 at 09:15:32PM +0800, bibo mao wrote: > From: Bibo Mao > > If multiple threads are accessing the same huge page at the same > time, hugetlb_cow will be called if one thread write the COW huge > page. And function huge_ptep_clear_flush is called to notify other > threads to clear the huge pte tlb entry. The other threads clear > the huge pte tlb entry and reload it from page table, the reload > huge pte entry may be old. > > This patch fixes this issue on mips platform, and it clears huge > pte entry before notifying other threads to flush current huge > page entry, it is similar with other architectures. > > Signed-off-by: Bibo Mao > --- > arch/mips/include/asm/hugetlb.h | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]