From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: bibo mao <maobibo@loongson.cn>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 1/2] hugetlb: clear huge pte during flush function on mips platform
Date: Tue, 11 May 2021 23:03:49 +0200 [thread overview]
Message-ID: <20210511210349.GA18846@alpha.franken.de> (raw)
In-Reply-To: <1593436533-8645-1-git-send-email-maobibo@loongson.cn>
On Mon, Jun 29, 2020 at 09:15:32PM +0800, bibo mao wrote:
> From: Bibo Mao <maobibo@loongson.cn>
>
> If multiple threads are accessing the same huge page at the same
> time, hugetlb_cow will be called if one thread write the COW huge
> page. And function huge_ptep_clear_flush is called to notify other
> threads to clear the huge pte tlb entry. The other threads clear
> the huge pte tlb entry and reload it from page table, the reload
> huge pte entry may be old.
>
> This patch fixes this issue on mips platform, and it clears huge
> pte entry before notifying other threads to flush current huge
> page entry, it is similar with other architectures.
>
> Signed-off-by: Bibo Mao <maobibo@loongson.cn>
> ---
> arch/mips/include/asm/hugetlb.h | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2021-05-11 21:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 13:15 bibo mao
2020-06-29 13:15 ` [PATCH 2/2] hugetlb: use lightweight tlb flush when update huge tlb on mips bibo mao
2021-05-11 21:03 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210511210349.GA18846@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maobibo@loongson.cn \
--cc=mike.kravetz@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox