From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B22CC433B4 for ; Tue, 11 May 2021 18:51:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C04C861185 for ; Tue, 11 May 2021 18:51:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C04C861185 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3773D6B007D; Tue, 11 May 2021 14:51:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 328816B007E; Tue, 11 May 2021 14:51:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CBEE6B0080; Tue, 11 May 2021 14:51:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0147.hostedemail.com [216.40.44.147]) by kanga.kvack.org (Postfix) with ESMTP id F2D9F6B007D for ; Tue, 11 May 2021 14:51:27 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A7B5F181AEF3F for ; Tue, 11 May 2021 18:51:27 +0000 (UTC) X-FDA: 78129843414.05.D2DB54A Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by imf09.hostedemail.com (Postfix) with ESMTP id 0537160006EB for ; Tue, 11 May 2021 18:51:15 +0000 (UTC) Received: by mail-io1-f45.google.com with SMTP id n10so19157403ion.8 for ; Tue, 11 May 2021 11:51:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XoeV1CIyKryeNzxxt5mlrf/4FcTSldzarEqWBQPGNdM=; b=jiMcXG4zKPDWdEDeFEfp7Wxzaoya/ZEkEcM9vBOGps7AKUfCKS4UV/tMiAOvCtVG1F 69GNW/TyDoFvqKkgS59LI/zcZPmd18pJdgxuY6XrlzkHnqgPB9O1K/yyllhsYbT55GbC Ljzz31TRhCibHIaj8XP/VYqif/02Iwe3XElm157hVmjNQM4Tc0JrvjtT/xo5VYf35F+l sqnoHQEPplWTAO7j/goCj9FIE0q3xFMy0YSilDHdDNQ+ViWqmHaIp4n90iJMGvMkD3Xr rJG+Nyk9xXyARYU1wDoHVdMQHL6vypuMVt9pC3S1TeRcBKeujcP3ISpy9lGYcdK4Fi2n pW9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XoeV1CIyKryeNzxxt5mlrf/4FcTSldzarEqWBQPGNdM=; b=jriIAxieIM+HO6CoHXMAgDpraSPBZ7yX81SKttoceDVTACUy9bUc1YsoCjsBzBX8Cb rQ8asChPnpsUu+y0lxM/fUbWdH8DpGWUBKhBoMS3c/4VUB0GF4642Lkid5gUcLUAutFp AosbQS8gL46YmbqaOFdiATjBB5uDAoqY3rFbbGRh42E3xBJbkF4U5yQusNfzwuBh/35O N94JagPNvDDLHemDpknK+tmmslD+XMsmgdYTo03OsOb1fTiV7NETlVkpWMXF/emuj8jM kkxO+ZQEkDQmzKiKO/w5Pdp9JD50u5BxWglB1vf1Rh1tlBeghV6O13E9m/+Qmv4/AsOb MtYA== X-Gm-Message-State: AOAM532eBmNUvjeygXPuF3PgGr1jrg69m+fdnOBv2zTdWF2A/JGDL3TJ 9yOoMGeBGhBcjJrF9xkTKyI= X-Google-Smtp-Source: ABdhPJzT38saFp5RPxsUsgX8AOZfspvCsMbU8J/sSMPLhxAy9yKP0XWHcUJeYPZURWh98vWkeTvIFg== X-Received: by 2002:a6b:6c18:: with SMTP id a24mr23927594ioh.21.1620759086691; Tue, 11 May 2021 11:51:26 -0700 (PDT) Received: from frodo.mearth (c-24-9-77-57.hsd1.co.comcast.net. [24.9.77.57]) by smtp.googlemail.com with ESMTPSA id t10sm405096ils.36.2021.05.11.11.51.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 11:51:26 -0700 (PDT) From: Jim Cromie To: Jason Baron , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Jim Cromie Subject: [RFC PATCH v5 07/28] dyndbg: hoist ->site out of ddebug_match_site Date: Tue, 11 May 2021 12:50:36 -0600 Message-Id: <20210511185057.3815777-8-jim.cromie@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210511185057.3815777-1-jim.cromie@gmail.com> References: <20210511185057.3815777-1-jim.cromie@gmail.com> MIME-Version: 1.0 Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=jiMcXG4z; spf=pass (imf09.hostedemail.com: domain of jimcromie@gmail.com designates 209.85.166.45 as permitted sender) smtp.mailfrom=jimcromie@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 0537160006EB X-Stat-Signature: hyb6g6i7ihakax4p6ipwjqcpcwrkrdi5 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf09; identity=mailfrom; envelope-from=""; helo=mail-io1-f45.google.com; client-ip=209.85.166.45 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620759075-954426 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: A coming change adds _get/_put abstraction on the site pointer, to allow managing site info more flexibly. The get/put pattern is best done at a single lexical scope, where its more obviously correct, so hoist the ->site ref out of ddebug_match_site, and pass it in instead. no functional changes Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 47d427b82ae1..0896c681db40 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -143,10 +143,9 @@ static void vpr_info_dq(const struct ddebug_query *q= uery, const char *msg) } =20 static int ddebug_match_site(const struct ddebug_query *query, - const struct _ddebug *dp) + const struct _ddebug *dp, + const struct _ddebug_site *dc) { - struct _ddebug_site *dc; - /* match against the format */ if (query->format) { if (*query->format =3D=3D '^') { @@ -167,7 +166,6 @@ static int ddebug_match_site(const struct ddebug_quer= y *query, dp->lineno > query->last_lineno) return false; =20 - dc =3D dp->site; if (!dc) { /* site info has been dropped, so query cannot test these fields */ if (query->filename || query->function) @@ -219,9 +217,9 @@ static int ddebug_change(const struct ddebug_query *q= uery, =20 for (i =3D 0; i < dt->num_ddebugs; i++) { struct _ddebug *dp =3D &dt->ddebugs[i]; - struct _ddebug_site *dc; + struct _ddebug_site *dc =3D dp->site; =20 - if (!ddebug_match_site(query, dp)) + if (!ddebug_match_site(query, dp, dc)) continue; =20 nfound++; --=20 2.31.1