From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25961C433B4 for ; Tue, 11 May 2021 18:52:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B1B2161185 for ; Tue, 11 May 2021 18:52:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1B2161185 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 157096B009C; Tue, 11 May 2021 14:51:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 092426B009D; Tue, 11 May 2021 14:51:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD9A66B009E; Tue, 11 May 2021 14:51:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0241.hostedemail.com [216.40.44.241]) by kanga.kvack.org (Postfix) with ESMTP id B2D546B009C for ; Tue, 11 May 2021 14:51:54 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7BC808E6B for ; Tue, 11 May 2021 18:51:54 +0000 (UTC) X-FDA: 78129844548.21.217A79A Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by imf28.hostedemail.com (Postfix) with ESMTP id DEBDD2000381 for ; Tue, 11 May 2021 18:51:52 +0000 (UTC) Received: by mail-io1-f54.google.com with SMTP id p11so19131701iob.9 for ; Tue, 11 May 2021 11:51:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JFW2fUV4S5apIt9TXKZGsIObebJdVsdqxjr+w7oZ8PM=; b=RfUMTS3QpJFUFcAuMUlC8ssDrXbEgtr6q0lOQAdiw1HvMLTzyWgIZYcuODtR8Fbf78 m1yaR9wN4oiYEILIACopoVY0/AXoqgMun99SLLAoO3MfAaHp0lXRW6xQk0sBV1boC9Jk 2c0UBOkZBLulplheqFYC8UzWTuF2Ehp4RcbU3VPno8BO+IIFCGWu2Po1yZDi0VBkW1ZV qFw3NDehnyNl65ZfVkM2TBiVxTwZNlbXRX+nN+NbstV4Wwz6+wJrwOQucJv8wqSOSPmQ nGbytwYVuH8/T6b0j12kdFqc6bED9EtY6Qed9nkIEik2C45w+dFe6l+IuT+qijsh2cfE 25/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JFW2fUV4S5apIt9TXKZGsIObebJdVsdqxjr+w7oZ8PM=; b=Rp+THAW+B9aTqdnwPpuqfASgVVBRmWmz8lcVW++iO/I7NeZt7lP2XNBy78+AU4bV2G ZZCuYXqFdN8AWY0TVHlAccYymhFtgcOaX+QOV4RHgzsMvu0oCksEGZzkFvZr7zLzQiKy rTqK42gnH9vngk6qLQRR8/E5SnHrLeGYcnjticYHqijmp8sPZ/sjqi97of/ZmoQ2p7s2 fqw9leYQlPUVuSvKktggAMt8/8s9shY3+h3ZRil52pr1yBVx/tZ/P4XdUSViWzDK0Kko jnqrCmg76azSvqOa+CA9TFk6DLwjk2tzfH4GnwAp/StznXTBClGzdhnQLmNQzTTTP+Df d8wA== X-Gm-Message-State: AOAM531fc0HWQQoQIHcH2PJEj7z5hcEK09pPYIiB+erEmS8SPsPf74U8 svUSv1wHg/4XUUuw1VGKXy8p1HSK8oSpMDw4 X-Google-Smtp-Source: ABdhPJwG3LrJGqKaLiX+OEv4jKy41DuSJAb4+ZcfJENAHIi33C9Iw/TKSXmtOBL0T2srd2dCBmgS9Q== X-Received: by 2002:a02:b057:: with SMTP id q23mr6582814jah.25.1620759113627; Tue, 11 May 2021 11:51:53 -0700 (PDT) Received: from frodo.mearth (c-24-9-77-57.hsd1.co.comcast.net. [24.9.77.57]) by smtp.googlemail.com with ESMTPSA id t10sm405096ils.36.2021.05.11.11.51.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 11:51:53 -0700 (PDT) From: Jim Cromie To: Jason Baron , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Jim Cromie Subject: [RFC PATCH v5 25/28] dyndbg: swap WARN_ON for BUG_ON see what 0-day says Date: Tue, 11 May 2021 12:50:54 -0600 Message-Id: <20210511185057.3815777-26-jim.cromie@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210511185057.3815777-1-jim.cromie@gmail.com> References: <20210511185057.3815777-1-jim.cromie@gmail.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: DEBDD2000381 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=RfUMTS3Q; spf=pass (imf28.hostedemail.com: domain of jimcromie@gmail.com designates 209.85.166.54 as permitted sender) smtp.mailfrom=jimcromie@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam04 X-Stat-Signature: hnq7yfmwk6ta16q3iuq9ifztyyk1wuf9 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf28; identity=mailfrom; envelope-from=""; helo=mail-io1-f54.google.com; client-ip=209.85.166.54 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620759112-988801 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: HEAD~1 passed 0-day, Im not sure what it does with WARNs, so make everything fatal, see what dies. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 9551c0d406b6..b61e4a211819 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -150,7 +150,7 @@ static struct _ddebug_site *ddebug_site_get(struct _d= debug *dp) { struct _ddebug *dh =3D dp - (dp->_index); =20 - WARN_ON(!is_dyndbg_header_pair(dh, dh->site)); + BUG_ON(!is_dyndbg_header_pair(dh, dh->site)); #ifdef SITE_CHK if (dp >=3D __start___dyndbg && dp < __stop___dyndbg) { =20 @@ -159,14 +159,14 @@ static struct _ddebug_site *ddebug_site_get(struct = _ddebug *dp) dh->site[dp->_index].filename, dh->site[dp->_index].function, dp->lineno); =20 - WARN_ON(dp !=3D &__start___dyndbg[dp->_index]); + BUG_ON(dp !=3D &__start___dyndbg[dp->_index]); =20 - WARN_ON(!(dp->_index =3D=3D (dp - dh) && + BUG_ON(!(dp->_index =3D=3D (dp - dh) && dp->_index =3D=3D (dp - __start___dyndbg) && dp->_index =3D=3D (&__start___dyndbg_sites[dp->_index] - &__start___dyndbg_sites[0]))); if (dp->site) - WARN_ON(&__start___dyndbg_sites[dp->_index] !=3D dp->site); + BUG_ON(&__start___dyndbg_sites[dp->_index] !=3D dp->site); } else { v4pr_info("get: %s is loaded: %d %s:%s:%d\n", dh->site[dp->_index].modname, dp->_index, @@ -174,7 +174,7 @@ static struct _ddebug_site *ddebug_site_get(struct _d= debug *dp) dh->site[dp->_index].function, dp->lineno); } if (dp->site) - WARN_ON(&dh->site[dp->_index] !=3D dp->site); + BUG_ON(&dh->site[dp->_index] !=3D dp->site); =20 return dp->site; #else @@ -1258,7 +1258,7 @@ static int __init dynamic_debug_init(void) =20 for (i =3D 0; iter < __stop___dyndbg; iter++, site++, i++) { =20 - SITE_CHK_(WARN_ON(site !=3D iter->site)); + SITE_CHK_(BUG_ON(site !=3D iter->site)); =20 if (strcmp(modname, site->modname)) { modct++; --=20 2.31.1