From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62156C433B4 for ; Tue, 11 May 2021 18:52:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E897C611AE for ; Tue, 11 May 2021 18:52:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E897C611AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2DE596B009A; Tue, 11 May 2021 14:51:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 273A66B009B; Tue, 11 May 2021 14:51:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F10156B009C; Tue, 11 May 2021 14:51:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0108.hostedemail.com [216.40.44.108]) by kanga.kvack.org (Postfix) with ESMTP id CF2DB6B009A for ; Tue, 11 May 2021 14:51:52 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 885D0181AEF3F for ; Tue, 11 May 2021 18:51:52 +0000 (UTC) X-FDA: 78129844464.11.18CC609 Received: from mail-il1-f178.google.com (mail-il1-f178.google.com [209.85.166.178]) by imf08.hostedemail.com (Postfix) with ESMTP id 073CB80193AA for ; Tue, 11 May 2021 18:51:24 +0000 (UTC) Received: by mail-il1-f178.google.com with SMTP id z1so10202520ils.0 for ; Tue, 11 May 2021 11:51:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9hgZRYHg+xD/GTpqGrDIeQXKedd/7xSgbcQRecHsrro=; b=Pz4zotfvTBAwUyssz0mfWcsn95ijYGiouDZ0Ib9SBZY8YjkPG+bQjS40T0D9AvOi3z W98YFcMcagS1D4VxIYm8UbzOtxX276ULVpVCMW4adwelIYyQyVglUnbJPUFx9sckGoT7 8yBA8ZJY06fC8W6oB7WhTErVMMv5OMpLgRxss5cBqCaT3dPjQLXdf98WF4kkZjsVVsEB s6vBHAFd6IlklDeEMF/dnYfWJZEP3Hw9KUf2/vnR7RHl0jZW8yT1BpKmNwtt8NFf3ZWJ 3+8PuQKbT0qJy3tGRmEkzn8Gq57AEsfpe2eGPcXwbaufSeHKlmgo/kCXI4gdrunH4n9K d1oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9hgZRYHg+xD/GTpqGrDIeQXKedd/7xSgbcQRecHsrro=; b=U8q77llf1694Orv7CMiGMcBkPT/iCkBJ3/N4hh5ZBvD5rAeun9QxbfapsYSRUFS+bj RfUm1RTNse9XPqLKmtDYlDINOqGK/HBr63hdxir45sxjhWMJEWeZrWy+nz0/U2K+k4AF ZfTQtyMWe3SCztVY9YyP2xWEfE9qkl33sScib3W4UqoCwoT+0uNQvsM2hfBTK4xYW33U oRveIa5BK/FToD6jhC54272R5WRv7Lc+J344gMoOSj+8jv8i/6Dci8uLbU0QT4Im+oI9 AHtuj2l8b8dpCKd7jTFqfypy6qYfiqEwxi9qRNaSGKVecDPY876/7s3zhReeDjCoMs1Y JAJQ== X-Gm-Message-State: AOAM533g29Pgcw1cA719nuw7ucqZbCfrDrW+uvc3q2yqVwNfla6XhUeg H6pmhcwq+gJxbMuxzLaP1p4= X-Google-Smtp-Source: ABdhPJwFe7BCCynBSquUHZ7yLVDDI9YazdXVtAghAHfST2PIv7+SQJcdFDrM5oDltgToXxTjNxVm5w== X-Received: by 2002:a05:6e02:12b3:: with SMTP id f19mr28258870ilr.219.1620759111600; Tue, 11 May 2021 11:51:51 -0700 (PDT) Received: from frodo.mearth (c-24-9-77-57.hsd1.co.comcast.net. [24.9.77.57]) by smtp.googlemail.com with ESMTPSA id t10sm405096ils.36.2021.05.11.11.51.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 11:51:51 -0700 (PDT) From: Jim Cromie To: Jason Baron , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Jim Cromie Subject: [RFC PATCH v5 23/28] dyndbg: dont show header records in control Date: Tue, 11 May 2021 12:50:52 -0600 Message-Id: <20210511185057.3815777-24-jim.cromie@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210511185057.3815777-1-jim.cromie@gmail.com> References: <20210511185057.3815777-1-jim.cromie@gmail.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 073CB80193AA Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=Pz4zotfv; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of jimcromie@gmail.com designates 209.85.166.178 as permitted sender) smtp.mailfrom=jimcromie@gmail.com X-Rspamd-Server: rspam03 X-Stat-Signature: upbk59xba6kwp9efh4m93uxghbi5mm7i Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf08; identity=mailfrom; envelope-from=""; helo=mail-il1-f178.google.com; client-ip=209.85.166.178 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620759084-617786 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: header record pairs are special in that the filename member no longer points at string data, but back at the data structure. Theres no reason to expose this in control file, and no reason to even print a line for the header, since its not part of the interface. Printing a "# header" line is a decent alternative, but separate. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index d0477450ec0c..b83187e72ee0 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -995,7 +995,9 @@ static int ddebug_proc_show(struct seq_file *m, void = *p) =20 dc =3D ddebug_site_get(dp); =20 - if (dc) { + if (dc && is_dyndbg_header_pair(dp, dc)) { + /* skip output on header */ + } else if (dc) { seq_printf(m, "%s:%u [%s]%s =3D%s \"", trim_prefix(dc->filename), dp->lineno, iter->table->mod_name, dc->function, --=20 2.31.1