From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 248A5C433B4 for ; Tue, 11 May 2021 18:51:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B0AE1611BD for ; Tue, 11 May 2021 18:51:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0AE1611BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3F4006B008C; Tue, 11 May 2021 14:51:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 28F4A6B0092; Tue, 11 May 2021 14:51:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9B418D0001; Tue, 11 May 2021 14:51:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0066.hostedemail.com [216.40.44.66]) by kanga.kvack.org (Postfix) with ESMTP id BCC3A6B008C for ; Tue, 11 May 2021 14:51:46 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 799CE1802DE17 for ; Tue, 11 May 2021 18:51:46 +0000 (UTC) X-FDA: 78129844212.22.5D2A9A7 Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) by imf20.hostedemail.com (Postfix) with ESMTP id C9E33ED for ; Tue, 11 May 2021 18:51:45 +0000 (UTC) Received: by mail-il1-f169.google.com with SMTP id j20so18028699ilo.10 for ; Tue, 11 May 2021 11:51:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=a/h54JdNC5kR17fX7/LoX7g8+9V1SkM6LPGM//jz9YE=; b=TyuPG2wOFQrgKxI20nIja2mzk8NJAyGwIiLGj/NpdzrU1nuGJ3oPGW2TGiZg9bh6wd 30l/Phnddorg+Dvatg6e2gDVLUG7R3rAPN2Tgd3NmEqqFan8p6PHC/BHRVy8iRfaJKO/ amPeFT9M8GsyJElzvFaLAn6XDBv4c2LfW0nsjuUlmr8W6BpEzw+zMNtu2oMoNGHvcG8n gogAnm+letvJoMK/VTjaueLYu4SHHfVbY1uWf04y/zmGK7thYghUd94dqrU5FliesezB 8v5dWnyTDFWI0iz9wFXKfwg5Mi5uV4qoD9KMqGpRrSNSx29CnxRTbSnLd/H57hp6QPlO bPRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=a/h54JdNC5kR17fX7/LoX7g8+9V1SkM6LPGM//jz9YE=; b=EUvtm/Hksn+nHePlDGCnPF3RfsAOcFZLOi2C2eQBZ5Qgpne6W79jcXxz1dsgRWR2CD xfA6ZkBsoTb9vYOeU+yj8khXfVDHlXPEN5mjItStLTvkvKkTKPhgggcwRmnuqx3CFR4l tSMC/ZAemvYqmNEnNxPF5NrmWnqSAg7yAFU/1/MHE03fmgsV+MIeJuE9H19sCoktF+xW mexK04U0mnamtFo6lMTg9tmPxI+/seTZZPH5FxZu54MtpRu8j0K09/USQw+lvFgO1U0T tOCCvfzAj93DaUXZBFFX/Np4UuFkoZ6aQ67FhCXvwKHKCOzG4LoUdUnrA6pI428dIPUP KM2g== X-Gm-Message-State: AOAM532O+CXEMQbw4NVF55EuDEV6yEMqznUTPgReWMIWRMZ7f5Nj5JR3 JlWhs+O+De6Q4SFvC9fY1Fs= X-Google-Smtp-Source: ABdhPJzcb33bvz5DI0nPKr87rXTBl99c1OgYhzBNlqj59Pxj7WEvcQRq6DDiruZk26m5IctEX86qCA== X-Received: by 2002:a05:6e02:1b85:: with SMTP id h5mr186059ili.303.1620759105380; Tue, 11 May 2021 11:51:45 -0700 (PDT) Received: from frodo.mearth (c-24-9-77-57.hsd1.co.comcast.net. [24.9.77.57]) by smtp.googlemail.com with ESMTPSA id t10sm405096ils.36.2021.05.11.11.51.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 11:51:44 -0700 (PDT) From: Jim Cromie To: Russell King , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Andy Lutomirski , Ard Biesheuvel , Kees Cook , Nick Desaulniers , Masahiro Yamada , Linus Walleij , Nathan Chancellor , Geert Uytterhoeven , Bill Wendling , Sami Tolvanen , Jim Cromie , Arvind Sankar , Joerg Roedel , Nick Terrell , Dave Young , Pingfan Liu , Atish Patra , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-efi@vger.kernel.org Cc: linux-mm@kvack.org, lkp@intel.com Subject: [RFC PATCH v5 17/28] dyndbg: prevent build bugs via -DNO_DYNAMIC_DEBUG_TABLE Date: Tue, 11 May 2021 12:50:46 -0600 Message-Id: <20210511185057.3815777-18-jim.cromie@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210511185057.3815777-1-jim.cromie@gmail.com> References: <20210511185057.3815777-1-jim.cromie@gmail.com> MIME-Version: 1.0 Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=TyuPG2wO; spf=pass (imf20.hostedemail.com: domain of jimcromie@gmail.com designates 209.85.166.169 as permitted sender) smtp.mailfrom=jimcromie@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: C9E33ED X-Stat-Signature: uh7uc57ws1tzbjkgsn4p6xkdbdxnz1c4 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf20; identity=mailfrom; envelope-from=""; helo=mail-il1-f169.google.com; client-ip=209.85.166.169 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620759105-526031 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The next patch adds DEFINE_DYNAMIC_DEBUG_TABLE(), which broke several subtrees, including efi, vdso, and some of arch/*/boot/compressed, with various relocation errors, iirc. Avoid those problems by adding a define to suppress the "transparent" DEFINE_DYNAMIC_DEBUG_TABLE() invocation. I found the x86 problems myself, lkp@intel.com found arm & sparc problems, and may yet find others. Reported-by: # on [jimc:lkp-test/dyndbg-diet] recently Signed-off-by: Jim Cromie --- arch/arm/boot/compressed/Makefile | 2 ++ arch/sparc/vdso/Makefile | 2 ++ arch/x86/boot/compressed/Makefile | 1 + arch/x86/entry/vdso/Makefile | 3 +++ arch/x86/purgatory/Makefile | 1 + drivers/firmware/efi/libstub/Makefile | 3 ++- 6 files changed, 11 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed= /Makefile index fd94e27ba4fa..72f056a00ad4 100644 --- a/arch/arm/boot/compressed/Makefile +++ b/arch/arm/boot/compressed/Makefile @@ -82,6 +82,8 @@ compress-$(CONFIG_KERNEL_LZMA) =3D lzma compress-$(CONFIG_KERNEL_XZ) =3D xzkern compress-$(CONFIG_KERNEL_LZ4) =3D lz4 =20 +KBUILD_CFLAGS +=3D -DNO_DYNAMIC_DEBUG_TABLE + libfdt_objs :=3D fdt_rw.o fdt_ro.o fdt_wip.o fdt.o =20 ifeq ($(CONFIG_ARM_ATAG_DTB_COMPAT),y) diff --git a/arch/sparc/vdso/Makefile b/arch/sparc/vdso/Makefile index c5e1545bc5cf..960ed0fb6804 100644 --- a/arch/sparc/vdso/Makefile +++ b/arch/sparc/vdso/Makefile @@ -30,6 +30,8 @@ obj-y +=3D $(vdso_img_objs) targets +=3D $(vdso_img_cfiles) targets +=3D $(vdso_img_sodbg) $(vdso_img-y:%=3Dvdso%.so) =20 +KBUILD_CFLAGS +=3D -DNO_DYNAMIC_DEBUG_TABLE + CPPFLAGS_vdso.lds +=3D -P -C =20 VDSO_LDFLAGS_vdso.lds =3D -m elf64_sparc -soname linux-vdso.so.1 --no-un= defined \ diff --git a/arch/x86/boot/compressed/Makefile b/arch/x86/boot/compressed= /Makefile index e0bc3988c3fa..ada4eb960d95 100644 --- a/arch/x86/boot/compressed/Makefile +++ b/arch/x86/boot/compressed/Makefile @@ -31,6 +31,7 @@ targets :=3D vmlinux vmlinux.bin vmlinux.bin.gz vmlinux= .bin.bz2 vmlinux.bin.lzma \ KBUILD_CFLAGS :=3D -m$(BITS) -O2 KBUILD_CFLAGS +=3D -fno-strict-aliasing -fPIE KBUILD_CFLAGS +=3D -DDISABLE_BRANCH_PROFILING +KBUILD_CFLAGS +=3D -DNO_DYNAMIC_DEBUG_TABLE cflags-$(CONFIG_X86_32) :=3D -march=3Di386 cflags-$(CONFIG_X86_64) :=3D -mcmodel=3Dsmall -mno-red-zone KBUILD_CFLAGS +=3D $(cflags-y) diff --git a/arch/x86/entry/vdso/Makefile b/arch/x86/entry/vdso/Makefile index 05c4abc2fdfd..619878f2c427 100644 --- a/arch/x86/entry/vdso/Makefile +++ b/arch/x86/entry/vdso/Makefile @@ -29,6 +29,9 @@ vobjs32-y :=3D vdso32/note.o vdso32/system_call.o vdso3= 2/sigreturn.o vobjs32-y +=3D vdso32/vclock_gettime.o vobjs-$(CONFIG_X86_SGX) +=3D vsgx.o =20 +# avoid a x86_64_RELATIVE error +KBUILD_CFLAGS +=3D -DNO_DYNAMIC_DEBUG_TABLE + # files to link into kernel obj-y +=3D vma.o extable.o KASAN_SANITIZE_vma.o :=3D y diff --git a/arch/x86/purgatory/Makefile b/arch/x86/purgatory/Makefile index 95ea17a9d20c..95ba7b18410f 100644 --- a/arch/x86/purgatory/Makefile +++ b/arch/x86/purgatory/Makefile @@ -35,6 +35,7 @@ PURGATORY_CFLAGS_REMOVE :=3D -mcmodel=3Dkernel PURGATORY_CFLAGS :=3D -mcmodel=3Dlarge -ffreestanding -fno-zero-initiali= zed-in-bss -g0 PURGATORY_CFLAGS +=3D $(DISABLE_STACKLEAK_PLUGIN) -DDISABLE_BRANCH_PROFI= LING PURGATORY_CFLAGS +=3D -fno-stack-protector +PURGATORY_CFLAGS +=3D -DNO_DYNAMIC_DEBUG_TABLE =20 # Default KBUILD_CFLAGS can have -pg option set when FTRACE is enabled. = That # in turn leaves some undefined symbols like __fentry__ in purgatory and= not diff --git a/drivers/firmware/efi/libstub/Makefile b/drivers/firmware/efi= /libstub/Makefile index c23466e05e60..def8febefbd3 100644 --- a/drivers/firmware/efi/libstub/Makefile +++ b/drivers/firmware/efi/libstub/Makefile @@ -13,7 +13,8 @@ cflags-$(CONFIG_X86) +=3D -m$(BITS) -D__KERNEL__ \ -Wno-pointer-sign \ $(call cc-disable-warning, address-of-packed-member) \ $(call cc-disable-warning, gnu) \ - -fno-asynchronous-unwind-tables + -fno-asynchronous-unwind-tables \ + -DNO_DYNAMIC_DEBUG_TABLE =20 # arm64 uses the full KBUILD_CFLAGS so it's necessary to explicitly # disable the stackleak plugin --=20 2.31.1