From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5804BC433B4 for ; Tue, 11 May 2021 18:51:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DECA3611BD for ; Tue, 11 May 2021 18:51:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DECA3611BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 60FE36B0088; Tue, 11 May 2021 14:51:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E88B6B0089; Tue, 11 May 2021 14:51:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43A5E6B008A; Tue, 11 May 2021 14:51:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0041.hostedemail.com [216.40.44.41]) by kanga.kvack.org (Postfix) with ESMTP id 268146B0088 for ; Tue, 11 May 2021 14:51:38 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id EA1E9AF74 for ; Tue, 11 May 2021 18:51:36 +0000 (UTC) X-FDA: 78129843792.03.E4119AC Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) by imf20.hostedemail.com (Postfix) with ESMTP id 258113C5 for ; Tue, 11 May 2021 18:51:36 +0000 (UTC) Received: by mail-il1-f170.google.com with SMTP id w7so1343738ilg.13 for ; Tue, 11 May 2021 11:51:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0akxANKNkbeQrtz/Nl9c6Kx9Ebh3LtjGjFZCG1KZ/Qw=; b=VX6dmSWJmZjkV1Rhp9aEogYuhqVXAsUR9aVeobbq22ovtj7fXTCQyxSllKzJT4mH96 p0fsLzFvvYUYxOzUGRB/VztsCI8y4/GRYK915XL2CQ7KdgfP1SD2PSMu0tWtYDlFg7zk I4gjTSFA/YsER9BONCczRiOpQR87c7/arpJftFNKJZqucVpd3fmPrrEjjjNgdS1MU3BF RUMtD0gfTVCIah3Ohue09qagSO7APCFWHSm80sgjQs/C15DvW78C4+RZ+XvMUAqDkteO qLXF0vYIESojXqkqRJbb+bPfcVKq9REgizFZ3uCTVaQWsaxycsVTHMQYUWgDLpszTHEa GzAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0akxANKNkbeQrtz/Nl9c6Kx9Ebh3LtjGjFZCG1KZ/Qw=; b=QsootjTW3zmAExIfZGRvdLu3bhjnYOTrCfz1iFdNUvZtoMkh2GFzr3lgo3V+8LaFrg McqKF7trUI3SPhdPMarSptN4gLPTy6h5hdquE2eB3gcDivAWsZeZbHN9ZojiBjtHabOI qYLc54Ppea/HqqeMLPW5Uaz0nVagsMXQdhAuyO/hHCwz1Q6a8ko3pd0SscCm7Bh5u8Z1 lm8PVlrDcJ1Uupi3AowbXPsvvFTvMDwF86hwMl93ZDeGFoJn4FvG4G36oEYlDPQQvkHK ySGyrrdXNuGfBXFVU8ZhdbgsAR9ztWQB/axdQhBowhJUeOyu9lt/o8HTXJRJmBpHgu40 3gdQ== X-Gm-Message-State: AOAM531IlI9lOQZuG8OPiAW/eLzvqJuEM2ICdps8jS+fLZrGp99dmlQA PiSEuf3k2Fi16w4fVL3C6Sg= X-Google-Smtp-Source: ABdhPJzEqx3UMwEioPfdqtJkFucKMAHNwHuJDWooC/COz4fEzHQN50FHXHQCY3bxq0VaORRmj0Fa6Q== X-Received: by 2002:a92:650d:: with SMTP id z13mr13363441ilb.193.1620759095707; Tue, 11 May 2021 11:51:35 -0700 (PDT) Received: from frodo.mearth (c-24-9-77-57.hsd1.co.comcast.net. [24.9.77.57]) by smtp.googlemail.com with ESMTPSA id t10sm405096ils.36.2021.05.11.11.51.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 11:51:35 -0700 (PDT) From: Jim Cromie To: Jason Baron , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Jim Cromie Subject: [RFC PATCH v5 15/28] dyndbg: ddebug_add_module avoid adding empty modules Date: Tue, 11 May 2021 12:50:44 -0600 Message-Id: <20210511185057.3815777-16-jim.cromie@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210511185057.3815777-1-jim.cromie@gmail.com> References: <20210511185057.3815777-1-jim.cromie@gmail.com> MIME-Version: 1.0 Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=VX6dmSWJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of jimcromie@gmail.com designates 209.85.166.170 as permitted sender) smtp.mailfrom=jimcromie@gmail.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 258113C5 X-Stat-Signature: iu14mas7ogjhw17ruqdbb9x6djdh67x6 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf20; identity=mailfrom; envelope-from=""; helo=mail-il1-f170.google.com; client-ip=209.85.166.170 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620759096-320784 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Don't create ddebug_table's for modules with 0 callsites. This saves memory, and avoids creating ddebug_tables with questionable contents, which are then iterated over for 'cat control'. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 90bea97c0da1..77c5135879c2 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -1033,6 +1033,12 @@ int ddebug_add_module(struct _ddebug *tab, struct = _ddebug_site *sites, { struct ddebug_table *dt; =20 + v3pr_info("add-module: %s.%d sites\n", modname, numdbgs); + if (!numdbgs) { + v3pr_info(" skip %s\n", modname); + return 0; + } + dt =3D kzalloc(sizeof(*dt), GFP_KERNEL); if (dt =3D=3D NULL) { pr_err("error adding module: %s\n", modname); --=20 2.31.1