From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 625A2C43460 for ; Tue, 11 May 2021 18:51:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0FCFE611BD for ; Tue, 11 May 2021 18:51:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FCFE611BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 21A5D6B0087; Tue, 11 May 2021 14:51:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1542A6B0088; Tue, 11 May 2021 14:51:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F102E6B0089; Tue, 11 May 2021 14:51:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0161.hostedemail.com [216.40.44.161]) by kanga.kvack.org (Postfix) with ESMTP id D52D56B0087 for ; Tue, 11 May 2021 14:51:35 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A0194181AEF3F for ; Tue, 11 May 2021 18:51:35 +0000 (UTC) X-FDA: 78129843750.32.A8A1F08 Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by imf01.hostedemail.com (Postfix) with ESMTP id 2B4035001522 for ; Tue, 11 May 2021 18:51:32 +0000 (UTC) Received: by mail-io1-f42.google.com with SMTP id a11so19173450ioo.0 for ; Tue, 11 May 2021 11:51:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=be8g977AZ5bDeKF0B08Lx0EuPmyTmMUIPQ9/ceBeosg=; b=Gza6ZZPlOYH97az7teoGtiOBvrypZ4gz6Tq+qYV+S8QHwAQaCNulTaH2rSWVCpxiWP qtSkgTVNXomxSj0Y+DmNarQrJb7SaAitApc+zebdIuEl1BQsDE+76uSoFjKRYRT+M9fx hM1G8Z+UGi7f7W5+4ZW/w3ghxFXMxL2sH6jW+zO9lHXUzorUbaJMuHRgubxpWYKSX9HM FQge0xqiMm/vma34WvNR5JNXrFdem0pvvc4GiAW6p4xd4b6A0eTt0OhQ+c1GF3/AxEcJ RO1ntb1Osnr1f2Ge1F91Dl01j2YPFowmGLQqj2GrKwekrldxmzBn68GM8MlxKtBzAzsE Tsxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=be8g977AZ5bDeKF0B08Lx0EuPmyTmMUIPQ9/ceBeosg=; b=AZhx/jFLsKMsu9yTZ1K/MfUaBEhysXBXalH2QxTq3GU1cdRG+zUBNQoKG3rlyjnQiI ebFb64OWEHvAgbk5YggX2nZJbIb/ncs+KsVWfpGeByIhMjZ7MUwIVd9DMkSFZE8wRAdT I5nEj5Hn4C9pdQRx4g3jMdUqCcy3ttItLERtyn2Kuk/Z30t6iaPz2QanjknRoYwuXzoC WL7KGoiH/cNOJD85Wyfg5iwpJcF/0EAEcLzK6/vYcBKqTlzudhXBk7WYrqN6AOegqg+G b9OBNOmJDt3vm9f+j/Xdfah59TgE+nCrq6Vy8ma2kkycv00zqt4EP/0IcVDcXtTizca/ GseQ== X-Gm-Message-State: AOAM531kOcJ47qve89a15lHsJZLF3LVURPBjIPhbvyIg3vjEuaa/T0z/ 4r3g5ftics3QJh+THbk35NM= X-Google-Smtp-Source: ABdhPJwJEnJHsn2AEinRleOhYeJoPFdY8E7nfKDfQwU6fZnspnBCl/X3CxKfV0FIu2/z9S8AG6OguA== X-Received: by 2002:a05:6638:3c8:: with SMTP id r8mr27928630jaq.112.1620759094788; Tue, 11 May 2021 11:51:34 -0700 (PDT) Received: from frodo.mearth (c-24-9-77-57.hsd1.co.comcast.net. [24.9.77.57]) by smtp.googlemail.com with ESMTPSA id t10sm405096ils.36.2021.05.11.11.51.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 11:51:34 -0700 (PDT) From: Jim Cromie To: Jason Baron , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Jim Cromie Subject: [RFC PATCH v5 14/28] dyndbg: add ddebug_site(_get|_put) abstraction Date: Tue, 11 May 2021 12:50:43 -0600 Message-Id: <20210511185057.3815777-15-jim.cromie@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210511185057.3815777-1-jim.cromie@gmail.com> References: <20210511185057.3815777-1-jim.cromie@gmail.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 2B4035001522 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=Gza6ZZPl; spf=pass (imf01.hostedemail.com: domain of jimcromie@gmail.com designates 209.85.166.42 as permitted sender) smtp.mailfrom=jimcromie@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam04 X-Stat-Signature: sm16gysjc3ruo88cp146ibhzmh9knz3r Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf01; identity=mailfrom; envelope-from=""; helo=mail-io1-f42.google.com; client-ip=209.85.166.42 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620759092-606123 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Replace direct ->site refs with _get(),_put() internal API. Right now, _get() just returns ->site and _put() does nothing. Later we can replace this implementation with one using ->_index to fetch site data then forget or keep it selectively. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 31 +++++++++++++++++++++++++------ 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 1441b31915e7..90bea97c0da1 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -144,6 +144,14 @@ static void vpr_info_dq(const struct ddebug_query *q= uery, const char *msg) query->first_lineno, query->last_lineno); } =20 +static struct _ddebug_site *ddebug_site_get(struct _ddebug *dp) +{ + return dp->site; /* passthru abstraction */ +} +static inline void ddebug_site_put(struct _ddebug *dp) +{ +} + static int ddebug_match_site(const struct ddebug_query *query, const struct _ddebug *dp, const struct _ddebug_site *dc) @@ -239,16 +247,18 @@ static int ddebug_change(const struct ddebug_query = *query, =20 for (i =3D 0; i < dt->num_ddebugs; i++) { struct _ddebug *dp =3D &dt->ddebugs[i]; - struct _ddebug_site *dc =3D dp->site; + struct _ddebug_site *dc; + + dc =3D ddebug_site_get(dp); =20 if (!ddebug_match_site(query, dp, dc)) - continue; + goto skipsite; =20 nfound++; =20 newflags =3D (dp->flags & modifiers->mask) | modifiers->flags; if (newflags =3D=3D dp->flags) - continue; + goto skipsite; =20 ddebug_alter_site(dp, modifiers); =20 @@ -264,6 +274,9 @@ static int ddebug_change(const struct ddebug_query *q= uery, dt->mod_name, dp->lineno, ddebug_describe_flags(dp->flags, &fbuf), dp->format); + +skipsite: + ddebug_site_put(dp); } } mutex_unlock(&ddebug_lock); @@ -633,11 +646,11 @@ static int remaining(int wrote) return 0; } =20 -static char *__dynamic_emit_prefix(const struct _ddebug *dp, char *buf) +static char *__dynamic_emit_prefix(struct _ddebug *dp, char *buf) { int pos_after_tid; int pos =3D 0; - const struct _ddebug_site *desc =3D dp->site; + const struct _ddebug_site *desc; =20 if (dp->flags & _DPRINTK_FLAGS_INCL_TID) { if (in_interrupt()) @@ -648,6 +661,7 @@ static char *__dynamic_emit_prefix(const struct _ddeb= ug *dp, char *buf) } pos_after_tid =3D pos; =20 + desc =3D ddebug_site_get(dp); if (desc) { if (dp->flags & _DPRINTK_FLAGS_INCL_MODNAME) pos +=3D snprintf(buf + pos, remaining(pos), "%s:", @@ -665,6 +679,8 @@ static char *__dynamic_emit_prefix(const struct _ddeb= ug *dp, char *buf) if (pos >=3D PREFIX_SIZE) buf[PREFIX_SIZE - 1] =3D '\0'; =20 + ddebug_site_put(dp); + return buf; } =20 @@ -947,7 +963,8 @@ static int ddebug_proc_show(struct seq_file *m, void = *p) return 0; } =20 - dc =3D dp->site; + dc =3D ddebug_site_get(dp); + if (dc) { seq_printf(m, "%s:%u [%s]%s =3D%s \"", trim_prefix(dc->filename), dp->lineno, @@ -963,6 +980,8 @@ static int ddebug_proc_show(struct seq_file *m, void = *p) seq_puts(m, "\"\n"); } =20 + ddebug_site_put(dp); + return 0; } =20 --=20 2.31.1